You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2022/09/22 17:49:05 UTC
[native-toolchain-CR] IMPALA-11605: Switch back to a patched flatbuffers 1.9.0
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19032
Change subject: IMPALA-11605: Switch back to a patched flatbuffers 1.9.0
......................................................................
IMPALA-11605: Switch back to a patched flatbuffers 1.9.0
In IMPALA-9999, we moved to flatbuffers 1.12 to fix
a compilation issue of flatbuffers with newer GCC.
This requires Impala to use flatbuffers 1.12 for
Java as well, and that created a conflict with Hive.
This switches back to flatbuffers 1.9 (the same as
Hive) with a patch for the compilation issue.
Testing:
- Built flatbuffers with GCC 10
Change-Id: Icd3b537ce7ffac61a311045453d4e063175a3300
---
M buildall.sh
M source/flatbuffers/build.sh
A source/flatbuffers/flatbuffers-1.9.0-patches/0001-PATCH-Fix-GCC8-build-remove-unnecessary-const-qualifier.patch
3 files changed, 17 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/32/19032/1
--
To view, visit http://gerrit.cloudera.org:8080/19032
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icd3b537ce7ffac61a311045453d4e063175a3300
Gerrit-Change-Number: 19032
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[native-toolchain-CR] IMPALA-11605: Switch back to a patched flatbuffers 1.9.0
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19032 )
Change subject: IMPALA-11605: Switch back to a patched flatbuffers 1.9.0
......................................................................
Patch Set 1: Verified+1
Builds fine, and the resulting Impala change passes GVO, going ahead with merging this.
--
To view, visit http://gerrit.cloudera.org:8080/19032
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd3b537ce7ffac61a311045453d4e063175a3300
Gerrit-Change-Number: 19032
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Sep 2022 05:27:55 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-11605: Switch back to a patched flatbuffers 1.9.0
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19032 )
Change subject: IMPALA-11605: Switch back to a patched flatbuffers 1.9.0
......................................................................
IMPALA-11605: Switch back to a patched flatbuffers 1.9.0
In IMPALA-9999, we moved to flatbuffers 1.12 to fix
a compilation issue of flatbuffers with newer GCC.
This requires Impala to use flatbuffers 1.12 for
Java as well, and that created a conflict with Hive.
This switches back to flatbuffers 1.9 (the same as
Hive) with a patch for the compilation issue.
Testing:
- Built flatbuffers with GCC 10
Change-Id: Icd3b537ce7ffac61a311045453d4e063175a3300
Reviewed-on: http://gerrit.cloudera.org:8080/19032
Reviewed-by: Michael Smith <mi...@cloudera.com>
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Tested-by: Joe McDonnell <jo...@cloudera.com>
---
M buildall.sh
M source/flatbuffers/build.sh
A source/flatbuffers/flatbuffers-1.9.0-patches/0001-PATCH-Fix-GCC8-build-remove-unnecessary-const-qualifier.patch
3 files changed, 17 insertions(+), 2 deletions(-)
Approvals:
Michael Smith: Looks good to me, but someone else must approve
Wenzhe Zhou: Looks good to me, approved
Joe McDonnell: Verified
--
To view, visit http://gerrit.cloudera.org:8080/19032
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icd3b537ce7ffac61a311045453d4e063175a3300
Gerrit-Change-Number: 19032
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[native-toolchain-CR] IMPALA-11605: Switch back to a patched flatbuffers 1.9.0
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19032 )
Change subject: IMPALA-11605: Switch back to a patched flatbuffers 1.9.0
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/19032
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd3b537ce7ffac61a311045453d4e063175a3300
Gerrit-Change-Number: 19032
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Sep 2022 23:38:16 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-11605: Switch back to a patched flatbuffers 1.9.0
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19032 )
Change subject: IMPALA-11605: Switch back to a patched flatbuffers 1.9.0
......................................................................
Patch Set 1: Code-Review+2
Looks good to me and carry over +1 from Michael.
--
To view, visit http://gerrit.cloudera.org:8080/19032
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd3b537ce7ffac61a311045453d4e063175a3300
Gerrit-Change-Number: 19032
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Sep 2022 02:48:04 +0000
Gerrit-HasComments: No