[GitHub] [maven-dependency-plugin] pzygielo commented on a change in pull request #47: Fix possible NPEx

[GitBox <gi...@apache.org>]

pzygielo commented on a change in pull request #47:
URL: https://github.com/apache/maven-dependency-plugin/pull/47#discussion_r418949044



##########
File path: src/main/java/org/apache/maven/plugins/dependency/tree/TreeMojo.java
##########
@@ -479,9 +479,12 @@ public static boolean containsVersion( VersionRange allowedRange, ArtifactVersio
                     return true;
                 }
             }
+            return false;
+        }
+        else
+        {
+            // only singular versions ever have a recommendedVersion
+            return recommendedVersion.compareTo(theVersion) <= 0;

Review comment:
       Corrected. :cry: I don't know how it happened as it is clearly reported by `verify`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org