You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2025/10/03 07:42:12 UTC
[kudu-CR] KUDU-1261 instantiate templates for RowPtr::GetArray()
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23490
Change subject: KUDU-1261 instantiate templates for RowPtr::GetArray()
......................................................................
KUDU-1261 instantiate templates for RowPtr::GetArray()
This patch adds KuduScanBatch::RowPtr::GetArray<>() template
instantiations for all the necessary column data types.
Since Kudu C++ client API still officially supports C++98, it's
necessary to have template instantiations for RowPtr::GetArray(),
similar to RowPtr::Get() for non-array getters. Otherwise, there
might be linker errors: see [1] for details.
This patch also contains a fix for a crash if trying to read an empty
boolean array using the RowPtr::GetArray typed accessor.
The corresponding end-to-end tests are included in client-test.cc,
along with scenarios of calling the RowPtr::GetArray() on a column
that is a null array.
[1] https://isocpp.org/wiki/faq/templates#separate-template-fn-defn-from-decl
Change-Id: I50b36c48959b00874921c6b56d210cf7358619f4
---
M src/kudu/client/client-test.cc
M src/kudu/client/scan_batch.cc
M src/kudu/client/scan_batch.h
M src/kudu/common/partial_row.h
4 files changed, 384 insertions(+), 36 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/23490/1
--
To view, visit http://gerrit.cloudera.org:8080/23490
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I50b36c48959b00874921c6b56d210cf7358619f4
Gerrit-Change-Number: 23490
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] KUDU-1261 instantiate templates for RowPtr::GetArray()
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23490 )
Change subject: KUDU-1261 instantiate templates for RowPtr::GetArray()
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1933/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23490
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50b36c48959b00874921c6b56d210cf7358619f4
Gerrit-Change-Number: 23490
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Fri, 03 Oct 2025 10:23:15 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 instantiate templates for RowPtr::GetArray()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: KUDU-1261 instantiate templates for RowPtr::GetArray()
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/23490
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I50b36c48959b00874921c6b56d210cf7358619f4
Gerrit-Change-Number: 23490
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[kudu-CR] KUDU-1261 instantiate templates for RowPtr::GetArray()
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23490 )
Change subject: KUDU-1261 instantiate templates for RowPtr::GetArray()
......................................................................
Patch Set 3: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1936/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23490
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50b36c48959b00874921c6b56d210cf7358619f4
Gerrit-Change-Number: 23490
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Oct 2025 18:34:37 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 instantiate templates for RowPtr::GetArray()
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23490 )
Change subject: KUDU-1261 instantiate templates for RowPtr::GetArray()
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1932/
--
To view, visit http://gerrit.cloudera.org:8080/23490
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50b36c48959b00874921c6b56d210cf7358619f4
Gerrit-Change-Number: 23490
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 03 Oct 2025 07:42:20 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 instantiate templates for RowPtr::GetArray()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Riza Suminto, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23490
to look at the new patch set (#2).
Change subject: KUDU-1261 instantiate templates for RowPtr::GetArray()
......................................................................
KUDU-1261 instantiate templates for RowPtr::GetArray()
This patch adds KuduScanBatch::RowPtr::GetArray<>() template
instantiations for all the necessary column data types.
Since Kudu C++ client API still officially supports C++98, it's
necessary to have template instantiations for RowPtr::GetArray(),
similar to RowPtr::Get() for non-array getters. Otherwise, there
might be linker errors: see [1] for details.
This patch also contains a fix for a crash if trying to read an empty
boolean array using the RowPtr::GetArray typed accessor.
The corresponding end-to-end tests are included in client-test.cc,
along with scenarios of calling the RowPtr::GetArray() on a column
that is a null array.
[1] https://isocpp.org/wiki/faq/templates#separate-template-fn-defn-from-decl
Change-Id: I50b36c48959b00874921c6b56d210cf7358619f4
---
M src/kudu/client/client-test.cc
M src/kudu/client/scan_batch.cc
M src/kudu/client/scan_batch.h
M src/kudu/common/partial_row.h
4 files changed, 404 insertions(+), 38 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/23490/2
--
To view, visit http://gerrit.cloudera.org:8080/23490
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I50b36c48959b00874921c6b56d210cf7358619f4
Gerrit-Change-Number: 23490
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[kudu-CR] KUDU-1261 instantiate templates for RowPtr::GetArray()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23490 )
Change subject: KUDU-1261 instantiate templates for RowPtr::GetArray()
......................................................................
Patch Set 1:
> Overall looks good.
> Just one thing: there seems to be a build error in release mode.
Thank you for the review! Indeed, I missed adding instantiations for DECIMAL32 and DECIMAL64 -- didn't notice that since I was using debug builds for testing and verification. I'm updating the patch shortly.
--
To view, visit http://gerrit.cloudera.org:8080/23490
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50b36c48959b00874921c6b56d210cf7358619f4
Gerrit-Change-Number: 23490
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Oct 2025 16:27:33 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 instantiate templates for RowPtr::GetArray()
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23490 )
Change subject: KUDU-1261 instantiate templates for RowPtr::GetArray()
......................................................................
Patch Set 2:
Build Aborted
http://jenkins.kudu.apache.org/job/pre_commit/1935/ : ABORTED
--
To view, visit http://gerrit.cloudera.org:8080/23490
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50b36c48959b00874921c6b56d210cf7358619f4
Gerrit-Change-Number: 23490
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Oct 2025 17:11:23 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 instantiate templates for RowPtr::GetArray()
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/23490 )
Change subject: KUDU-1261 instantiate templates for RowPtr::GetArray()
......................................................................
Patch Set 1: Code-Review+1
Overall looks good.
Just one thing: there seems to be a build error in release mode.
--
To view, visit http://gerrit.cloudera.org:8080/23490
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50b36c48959b00874921c6b56d210cf7358619f4
Gerrit-Change-Number: 23490
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Fri, 03 Oct 2025 09:36:49 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 instantiate templates for RowPtr::GetArray()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Riza Suminto, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23490
to look at the new patch set (#3).
Change subject: KUDU-1261 instantiate templates for RowPtr::GetArray()
......................................................................
KUDU-1261 instantiate templates for RowPtr::GetArray()
This patch adds KuduScanBatch::RowPtr::GetArray<>() template
instantiations for all the necessary column data types.
Since Kudu C++ client API still officially supports C++98, it's
necessary to have template instantiations for RowPtr::GetArray(),
similar to RowPtr::Get() for non-array getters. Otherwise, there
might be linker errors: see [1] for details.
This patch also contains a fix for a crash if trying to read an empty
boolean array using the RowPtr::GetArray typed accessor.
The corresponding end-to-end tests are included in client-test.cc,
along with scenarios of calling the RowPtr::GetArray() on a column
that is a null array.
[1] https://isocpp.org/wiki/faq/templates#separate-template-fn-defn-from-decl
Change-Id: I50b36c48959b00874921c6b56d210cf7358619f4
---
M src/kudu/client/client-test.cc
M src/kudu/client/scan_batch.cc
M src/kudu/client/scan_batch.h
M src/kudu/common/partial_row.h
4 files changed, 407 insertions(+), 38 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/23490/3
--
To view, visit http://gerrit.cloudera.org:8080/23490
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I50b36c48959b00874921c6b56d210cf7358619f4
Gerrit-Change-Number: 23490
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[kudu-CR] KUDU-1261 instantiate templates for RowPtr::GetArray()
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23490 )
Change subject: KUDU-1261 instantiate templates for RowPtr::GetArray()
......................................................................
Patch Set 3:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1936/
--
To view, visit http://gerrit.cloudera.org:8080/23490
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50b36c48959b00874921c6b56d210cf7358619f4
Gerrit-Change-Number: 23490
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Oct 2025 17:11:27 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 instantiate templates for RowPtr::GetArray()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23490 )
Change subject: KUDU-1261 instantiate templates for RowPtr::GetArray()
......................................................................
KUDU-1261 instantiate templates for RowPtr::GetArray()
This patch adds KuduScanBatch::RowPtr::GetArray<>() template
instantiations for all the necessary column data types.
Since Kudu C++ client API still officially supports C++98, it's
necessary to have template instantiations for RowPtr::GetArray(),
similar to RowPtr::Get() for non-array getters. Otherwise, there
might be linker errors: see [1] for details.
This patch also contains a fix for a crash if trying to read an empty
boolean array using the RowPtr::GetArray typed accessor.
The corresponding end-to-end tests are included in client-test.cc,
along with scenarios of calling the RowPtr::GetArray() on a column
that is a null array.
[1] https://isocpp.org/wiki/faq/templates#separate-template-fn-defn-from-decl
Change-Id: I50b36c48959b00874921c6b56d210cf7358619f4
Reviewed-on: http://gerrit.cloudera.org:8080/23490
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Tested-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/client/client-test.cc
M src/kudu/client/scan_batch.cc
M src/kudu/client/scan_batch.h
M src/kudu/common/partial_row.h
4 files changed, 407 insertions(+), 38 deletions(-)
Approvals:
Abhishek Chennaka: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/23490
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I50b36c48959b00874921c6b56d210cf7358619f4
Gerrit-Change-Number: 23490
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[kudu-CR] KUDU-1261 instantiate templates for RowPtr::GetArray()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23490 )
Change subject: KUDU-1261 instantiate templates for RowPtr::GetArray()
......................................................................
Patch Set 3: Verified+1
unrelated java test failure (TSAN): org.apache.kudu.client.TestKuduClient
--
To view, visit http://gerrit.cloudera.org:8080/23490
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50b36c48959b00874921c6b56d210cf7358619f4
Gerrit-Change-Number: 23490
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Oct 2025 18:59:31 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 instantiate templates for RowPtr::GetArray()
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23490 )
Change subject: KUDU-1261 instantiate templates for RowPtr::GetArray()
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1933/
--
To view, visit http://gerrit.cloudera.org:8080/23490
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50b36c48959b00874921c6b56d210cf7358619f4
Gerrit-Change-Number: 23490
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Fri, 03 Oct 2025 09:12:17 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 instantiate templates for RowPtr::GetArray()
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23490 )
Change subject: KUDU-1261 instantiate templates for RowPtr::GetArray()
......................................................................
Patch Set 1:
Build Aborted
http://jenkins.kudu.apache.org/job/pre_commit/1932/ : ABORTED
--
To view, visit http://gerrit.cloudera.org:8080/23490
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50b36c48959b00874921c6b56d210cf7358619f4
Gerrit-Change-Number: 23490
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Fri, 03 Oct 2025 09:12:03 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 instantiate templates for RowPtr::GetArray()
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23490 )
Change subject: KUDU-1261 instantiate templates for RowPtr::GetArray()
......................................................................
Patch Set 2:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1935/
--
To view, visit http://gerrit.cloudera.org:8080/23490
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50b36c48959b00874921c6b56d210cf7358619f4
Gerrit-Change-Number: 23490
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Oct 2025 16:30:02 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 instantiate templates for RowPtr::GetArray()
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23490 )
Change subject: KUDU-1261 instantiate templates for RowPtr::GetArray()
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/23490
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50b36c48959b00874921c6b56d210cf7358619f4
Gerrit-Change-Number: 23490
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Oct 2025 17:14:05 +0000
Gerrit-HasComments: No