You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/09/28 18:01:00 UTC
[jira] [Commented] (IGNITE-6416) SQL: DDL tests should not check
internal structures, but rather rely on expected public behavior
[ https://issues.apache.org/jira/browse/IGNITE-6416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16184563#comment-16184563 ]
ASF GitHub Bot commented on IGNITE-6416:
----------------------------------------
GitHub user alexpaschenko opened a pull request:
https://github.com/apache/ignite/pull/2774
IGNITE-6416
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-6416
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/2774.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2774
----
commit 52d9168e5879470161b4a72735bfcd849dfa13c6
Author: Alexander Paschenko <al...@gmail.com>
Date: 2017-09-28T17:56:23Z
IGNITE-6416 Dynamic columns tests refactoring.
commit e7d3eec3b7ff5dcefc396ffab62455271db70618
Author: Alexander Paschenko <al...@gmail.com>
Date: 2017-09-28T18:00:21Z
Minor.
----
> SQL: DDL tests should not check internal structures, but rather rely on expected public behavior
> ------------------------------------------------------------------------------------------------
>
> Key: IGNITE-6416
> URL: https://issues.apache.org/jira/browse/IGNITE-6416
> Project: Ignite
> Issue Type: Task
> Components: sql
> Affects Versions: 2.3
> Reporter: Vladimir Ozerov
> Assignee: Alexander Paschenko
>
> We need to review our DDL tests. Looks like there are a lot waits in the tests which mask concurrency bugs (e.g. see IGNITE-6403). Instead, we should do the following:
> 1) If we want to tests asynchronous propagation of changes to clients, separate test should be created for this
> 2) For all other cases we should not use private API at all, and do not perform any waits.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)