You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Gabriel39 (via GitHub)" <gi...@apache.org> on 2024/10/16 08:02:59 UTC
[PR] [minor](refactor) Delete unused code [doris]
Gabriel39 opened a new pull request, #41953:
URL: https://github.com/apache/doris/pull/41953
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [minor](refactor) Delete unused code [doris]
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 commented on PR #41953:
URL: https://github.com/apache/doris/pull/41953#issuecomment-2416024859
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [minor](refactor) Delete unused code [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41953:
URL: https://github.com/apache/doris/pull/41953#issuecomment-2416247552
TeamCity be ut coverage result:
Function Coverage: 37.47% (9709/25912)
Line Coverage: 28.73% (80605/280601)
Region Coverage: 28.17% (41716/148069)
Branch Coverage: 24.75% (21209/85698)
Coverage Report: http://coverage.selectdb-in.cc/coverage/46a7572f3ced8b30df148ed722a1b645a3c768f0_46a7572f3ced8b30df148ed722a1b645a3c768f0/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [minor](refactor) Delete unused code [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41953:
URL: https://github.com/apache/doris/pull/41953#issuecomment-2416050133
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [minor](refactor) Delete unused code [doris]
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 merged PR #41953:
URL: https://github.com/apache/doris/pull/41953
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [minor](refactor) Delete unused code [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41953:
URL: https://github.com/apache/doris/pull/41953#issuecomment-2416304534
<details>
<summary>TPC-DS: <b>Total hot run time: 192778 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 46a7572f3ced8b30df148ed722a1b645a3c768f0, data reload: false
query1 905 405 400 400
query2 6248 2186 2087 2087
query3 8682 200 205 200
query4 34227 23575 23520 23520
query5 3420 497 470 470
query6 275 170 162 162
query7 4189 288 302 288
query8 289 244 241 241
query9 9499 2767 2744 2744
query10 438 274 273 273
query11 18070 15187 15306 15187
query12 160 106 99 99
query13 1575 431 410 410
query14 8596 7691 7304 7304
query15 254 165 185 165
query16 7972 474 494 474
query17 1655 608 592 592
query18 2155 319 309 309
query19 293 161 167 161
query20 121 120 112 112
query21 217 108 111 108
query22 4952 4860 4663 4663
query23 35321 34271 34720 34271
query24 10964 2793 2785 2785
query25 602 409 397 397
query26 949 159 170 159
query27 2334 278 283 278
query28 7529 2428 2428 2428
query29 698 428 428 428
query30 278 151 154 151
query31 1058 807 812 807
query32 99 61 58 58
query33 775 299 282 282
query34 923 515 519 515
query35 892 747 747 747
query36 1127 960 970 960
query37 152 88 90 88
query38 4056 3881 3839 3839
query39 1483 1415 1439 1415
query40 207 99 100 99
query41 48 46 49 46
query42 119 103 100 100
query43 546 503 502 502
query44 1283 815 814 814
query45 196 168 163 163
query46 1157 700 758 700
query47 1958 1881 1896 1881
query48 440 325 328 325
query49 977 440 437 437
query50 802 387 396 387
query51 7204 7007 7018 7007
query52 106 89 96 89
query53 259 189 181 181
query54 1113 435 445 435
query55 84 77 79 77
query56 282 270 290 270
query57 1305 1165 1141 1141
query58 223 222 236 222
query59 3204 3052 3001 3001
query60 298 262 269 262
query61 109 100 102 100
query62 855 663 682 663
query63 229 193 188 188
query64 3889 641 622 622
query65 3290 3176 3197 3176
query66 846 309 312 309
query67 16210 15991 15755 15755
query68 4759 551 553 551
query69 520 282 287 282
query70 1196 1077 1096 1077
query71 385 274 270 270
query72 7044 3958 3958 3958
query73 776 351 354 351
query74 10501 9012 8907 8907
query75 3373 2667 2646 2646
query76 3023 877 924 877
query77 517 306 307 306
query78 10824 9732 9712 9712
query79 1164 591 596 591
query80 950 450 467 450
query81 579 240 247 240
query82 400 151 143 143
query83 192 139 138 138
query84 263 73 71 71
query85 1428 308 282 282
query86 419 306 295 295
query87 4629 4341 4363 4341
query88 3923 2196 2164 2164
query89 403 293 284 284
query90 2262 187 184 184
query91 132 102 98 98
query92 66 49 49 49
query93 1619 541 538 538
query94 1217 287 281 281
query95 354 248 245 245
query96 608 275 285 275
query97 3373 3195 3131 3131
query98 221 197 194 194
query99 1607 1327 1318 1318
Total cold run time: 299398 ms
Total hot run time: 192778 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [minor](refactor) Delete unused code [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41953:
URL: https://github.com/apache/doris/pull/41953#issuecomment-2416024662
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [minor](refactor) Delete unused code [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41953:
URL: https://github.com/apache/doris/pull/41953#issuecomment-2416272773
<details>
<summary>TPC-H: <b>Total hot run time: 41338 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 46a7572f3ced8b30df148ed722a1b645a3c768f0, data reload: false
------ Round 1 ----------------------------------
q1 17584 7423 7273 7273
q2 2041 290 277 277
q3 12223 1044 1097 1044
q4 10564 867 794 794
q5 7756 3072 3059 3059
q6 242 152 145 145
q7 1026 622 595 595
q8 9360 1933 1927 1927
q9 6596 6460 6424 6424
q10 7103 2403 2426 2403
q11 442 245 254 245
q12 410 222 224 222
q13 17779 3001 2977 2977
q14 254 215 216 215
q15 578 518 519 518
q16 656 588 593 588
q17 974 528 522 522
q18 7447 6829 6735 6735
q19 1363 902 964 902
q20 493 189 186 186
q21 4059 3304 3278 3278
q22 1161 1030 1009 1009
Total cold run time: 110111 ms
Total hot run time: 41338 ms
----- Round 2, with runtime_filter_mode=off -----
q1 7267 7310 7213 7213
q2 332 237 228 228
q3 3067 2982 2964 2964
q4 2120 1839 1864 1839
q5 5762 5793 5832 5793
q6 226 150 147 147
q7 2274 1837 1792 1792
q8 3396 3454 3536 3454
q9 8985 8941 8956 8941
q10 3602 3584 3535 3535
q11 594 494 494 494
q12 858 608 628 608
q13 9192 3191 3142 3142
q14 314 266 295 266
q15 587 541 520 520
q16 703 652 647 647
q17 1876 1622 1620 1620
q18 8457 7778 7508 7508
q19 1759 1485 1472 1472
q20 2139 1884 1870 1870
q21 5417 5436 5442 5436
q22 1165 1140 1076 1076
Total cold run time: 70092 ms
Total hot run time: 60565 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [minor](refactor) Delete unused code [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41953:
URL: https://github.com/apache/doris/pull/41953#issuecomment-2416424256
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [minor](refactor) Delete unused code [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41953:
URL: https://github.com/apache/doris/pull/41953#issuecomment-2416317311
<details>
<summary>ClickBench: <b>Total hot run time: 32.8 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 46a7572f3ced8b30df148ed722a1b645a3c768f0, data reload: false
query1 0.03 0.04 0.02
query2 0.07 0.03 0.02
query3 0.23 0.07 0.07
query4 1.63 0.10 0.10
query5 0.51 0.49 0.52
query6 1.14 0.73 0.73
query7 0.02 0.01 0.01
query8 0.04 0.04 0.03
query9 0.55 0.51 0.50
query10 0.55 0.55 0.54
query11 0.14 0.11 0.10
query12 0.13 0.10 0.11
query13 0.60 0.59 0.59
query14 2.80 2.80 2.70
query15 0.90 0.82 0.85
query16 0.38 0.35 0.40
query17 1.03 1.09 1.06
query18 0.20 0.19 0.20
query19 1.93 1.80 1.95
query20 0.02 0.01 0.01
query21 15.37 0.60 0.60
query22 2.49 2.28 1.72
query23 17.17 0.92 0.79
query24 2.57 1.58 1.27
query25 0.26 0.10 0.06
query26 0.58 0.14 0.13
query27 0.04 0.04 0.04
query28 10.18 1.10 1.07
query29 12.56 3.24 3.20
query30 0.24 0.07 0.05
query31 2.88 0.38 0.37
query32 3.26 0.45 0.46
query33 3.00 3.02 3.05
query34 17.05 4.56 4.50
query35 4.52 4.53 4.54
query36 0.70 0.50 0.47
query37 0.08 0.06 0.06
query38 0.05 0.03 0.03
query39 0.03 0.02 0.02
query40 0.16 0.12 0.12
query41 0.07 0.02 0.02
query42 0.03 0.02 0.02
query43 0.04 0.03 0.03
Total cold run time: 106.23 s
Total hot run time: 32.8 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [minor](refactor) Delete unused code [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41953:
URL: https://github.com/apache/doris/pull/41953#issuecomment-2416424179
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org