You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/30 09:45:51 UTC

[GitHub] [arrow-datafusion] comphead opened a new pull request, #2390: Dev

comphead opened a new pull request, #2390:
URL: https://github.com/apache/arrow-datafusion/pull/2390

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #2380.
   
    # Rationale for this change
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   # What changes are included in this PR?
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   Added Decimal to be valid types for coercion, to be converted to f64
   
   # Are there any user-facing changes?
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] andygrove commented on pull request #2390: Support type-coercion from Decimal to Float64

Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #2390:
URL: https://github.com/apache/arrow-datafusion/pull/2390#issuecomment-1113994454

   Thanks @comphead! The fix looks good but there are 26 commits in this PR for some reason. Could you rebase against master?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] comphead closed pull request #2390: Support type-coercion from Decimal to Float64

Posted by GitBox <gi...@apache.org>.
comphead closed pull request #2390: Support type-coercion from Decimal to Float64
URL: https://github.com/apache/arrow-datafusion/pull/2390


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] comphead commented on pull request #2390: Support type-coercion from Decimal to Float64

Posted by GitBox <gi...@apache.org>.
comphead commented on PR #2390:
URL: https://github.com/apache/arrow-datafusion/pull/2390#issuecomment-1114051682

   Closing in prefer to https://github.com/apache/arrow-datafusion/pull/2396 to resolve some commit history issues


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org