You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/04/08 19:05:57 UTC

[GitHub] [incubator-tvm] kparzysz-quic opened a new pull request #5282: [LLVM] Fix generation of LLVM intrinsics

kparzysz-quic opened a new pull request #5282: [LLVM] Fix generation of LLVM intrinsics
URL: https://github.com/apache/incubator-tvm/pull/5282
 
 
   The type list in the call to `llvm::Intrinsic::getDeclaration` is not the intrinsic's signature, it's the list of overloaded types. Without this fix, the updated unit test would cause the following error:
   ```
   TVMError: LLVM module verification failed with the following errors:
   Intrinsic name not mangled correctly for type arguments! Should be: llvm.ctlz.i32
   i32 (i32, i1)* @llvm.ctlz.i32.i1
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] tqchen merged pull request #5282: [LLVM] Fix generation of LLVM intrinsics

Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #5282: [LLVM] Fix generation of LLVM intrinsics
URL: https://github.com/apache/incubator-tvm/pull/5282
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] tqchen edited a comment on issue #5282: [LLVM] Fix generation of LLVM intrinsics

Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on issue #5282: [LLVM] Fix generation of LLVM intrinsics
URL: https://github.com/apache/incubator-tvm/pull/5282#issuecomment-611722366
 
 
   The CI error was due to a flaky problem which is fixed now by https://github.com/apache/incubator-tvm/pull/5293

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] tqchen commented on issue #5282: [LLVM] Fix generation of LLVM intrinsics

Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #5282: [LLVM] Fix generation of LLVM intrinsics
URL: https://github.com/apache/incubator-tvm/pull/5282#issuecomment-611722366
 
 
   The CI error was due to a flaky problem which is fixed now

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] kparzysz-quic commented on issue #5282: [LLVM] Fix generation of LLVM intrinsics

Posted by GitBox <gi...@apache.org>.
kparzysz-quic commented on issue #5282: [LLVM] Fix generation of LLVM intrinsics
URL: https://github.com/apache/incubator-tvm/pull/5282#issuecomment-611250027
 
 
   I guess I didn't get everything...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] tqchen commented on issue #5282: [LLVM] Fix generation of LLVM intrinsics

Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #5282: [LLVM] Fix generation of LLVM intrinsics
URL: https://github.com/apache/incubator-tvm/pull/5282#issuecomment-611767350
 
 
   OK https://github.com/apache/incubator-tvm/pull/5297 temporary disabled the crt test

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] kparzysz-quic commented on issue #5282: [LLVM] Fix generation of LLVM intrinsics

Posted by GitBox <gi...@apache.org>.
kparzysz-quic commented on issue #5282: [LLVM] Fix generation of LLVM intrinsics
URL: https://github.com/apache/incubator-tvm/pull/5282#issuecomment-611743041
 
 
   Same failure again: https://ci.tvm.ai/blue/organizations/jenkins/tvm/detail/PR-5282/9/pipeline/152...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] kparzysz-quic commented on issue #5282: [LLVM] Fix generation of LLVM intrinsics

Posted by GitBox <gi...@apache.org>.
kparzysz-quic commented on issue #5282: [LLVM] Fix generation of LLVM intrinsics
URL: https://github.com/apache/incubator-tvm/pull/5282#issuecomment-611293789
 
 
   The entire `tests/python/unittest/test_target_codegen_llvm.py` passes for me, I don't know what's going on.  I'll look into it tomorrow.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] tqchen commented on issue #5282: [LLVM] Fix generation of LLVM intrinsics

Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #5282: [LLVM] Fix generation of LLVM intrinsics
URL: https://github.com/apache/incubator-tvm/pull/5282#issuecomment-611158504
 
 
   cc @kparzysz-quic please look into the CI problem

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] kparzysz-quic commented on issue #5282: [LLVM] Fix generation of LLVM intrinsics

Posted by GitBox <gi...@apache.org>.
kparzysz-quic commented on issue #5282: [LLVM] Fix generation of LLVM intrinsics
URL: https://github.com/apache/incubator-tvm/pull/5282#issuecomment-611191988
 
 
   Yes, I'm working on it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] kparzysz-quic commented on a change in pull request #5282: [LLVM] Fix generation of LLVM intrinsics

Posted by GitBox <gi...@apache.org>.
kparzysz-quic commented on a change in pull request #5282: [LLVM] Fix generation of LLVM intrinsics
URL: https://github.com/apache/incubator-tvm/pull/5282#discussion_r405922346
 
 

 ##########
 File path: src/target/llvm/codegen_llvm.cc
 ##########
 @@ -698,21 +698,33 @@ llvm::Value* CodeGenLLVM::CreateIntrinsic(const CallNode* op) {
         sig_type.push_back(arg_value.back()->getType());
       }
     }
+    // LLVM's prefetch intrinsic returns "void", while TVM's prefetch
+    // returns int32. This causes problems because prefetch is one of
+    // those intrinsics that is generated automatically via the
 
 Review comment:
   Will do.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5282: [LLVM] Fix generation of LLVM intrinsics

Posted by GitBox <gi...@apache.org>.
tqchen commented on a change in pull request #5282: [LLVM] Fix generation of LLVM intrinsics
URL: https://github.com/apache/incubator-tvm/pull/5282#discussion_r405921326
 
 

 ##########
 File path: src/target/llvm/codegen_llvm.cc
 ##########
 @@ -698,21 +698,33 @@ llvm::Value* CodeGenLLVM::CreateIntrinsic(const CallNode* op) {
         sig_type.push_back(arg_value.back()->getType());
       }
     }
+    // LLVM's prefetch intrinsic returns "void", while TVM's prefetch
+    // returns int32. This causes problems because prefetch is one of
+    // those intrinsics that is generated automatically via the
 
 Review comment:
   I see, let us leave a TODO here, hopefully after we introduce the type system to type the intrinsics, we will be able to use the same type as LLVM

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services