You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Lukas Theussl <lt...@apache.org> on 2011/02/11 09:00:33 UTC
Re: svn commit: r1069599 - /maven/pom/trunk/asf/pom.xml
Brian,
I am happy about this :) however site-plugin-2.2 uses doxia-1.1 and has
a prereq of maven 2.2, I seem to remember some resistance last time to
use it by default. Is this no issue anymore?
I'd also appreciate some explanations concerning your comment in the
vote thread 'preparations to make Maven3 builds use the correct site
plugin'. What's the plan there?
Thanks,
-Lukas
brianf@apache.org wrote:
> Author: brianf
> Date: Thu Feb 10 22:50:03 2011
> New Revision: 1069599
>
> URL: http://svn.apache.org/viewvc?rev=1069599&view=rev
> Log:
> set the site version back to 2.2
>
> Modified:
> maven/pom/trunk/asf/pom.xml
>
> Modified: maven/pom/trunk/asf/pom.xml
> URL: http://svn.apache.org/viewvc/maven/pom/trunk/asf/pom.xml?rev=1069599&r1=1069598&r2=1069599&view=diff
> ==============================================================================
> --- maven/pom/trunk/asf/pom.xml (original)
> +++ maven/pom/trunk/asf/pom.xml Thu Feb 10 22:50:03 2011
> @@ -215,7 +215,7 @@ under the License.
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-site-plugin</artifactId>
> -<version>2.0.1</version>
> +<version>2.2</version>
> </plugin>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r1069599 - /maven/pom/trunk/asf/pom.xml
Posted by Arnaud Héritier <ar...@exoplatform.com>.
Perhaps we should add some docs on apache site to recommend to
projects to use at least 2.2.1 or 3.0.x ?
I'm not sure we have such guidelines about Maven for Apache projects ?
On Fri, Feb 11, 2011 at 12:15 PM, Benjamin Bentmann
<be...@udo.edu> wrote:
> Lukas Theussl wrote:
>
>> however site-plugin-2.2 uses doxia-1.1 and has
>> a prereq of maven 2.2, I seem to remember some resistance last time to
>> use it by default. Is this no issue anymore?
>
> This parent POM like any other parent POM provides default values, i.e.
> something that projects can override as they see fit. Correct me if I'm
> mistaken, but I'm under the impression that Site Plugin 2.2 is generally an
> improvement over version 2.0.1 and as such a better default version. So I
> support this version bump.
>
> On a related note, I'm also under the impression that using Maven 2.2.1 is
> recommended over using Maven 2.0.x, i.e. I don't see a big issue with the
> plugin's prerequisite.
>
>
> Benjamin
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r1069599 - /maven/pom/trunk/asf/pom.xml
Posted by Lukas Theussl <lt...@apache.org>.
Brian Fox wrote:
> On Fri, Feb 11, 2011 at 9:07 AM, Jason van Zyl<ja...@sonatype.com> wrote:
>>
>> On Feb 11, 2011, at 7:54 AM, Jesse Farinacci wrote:
>>
>>> Greetings,
>>>
>>> On Fri, Feb 11, 2011 at 6:15 AM, Benjamin Bentmann
>>> <be...@udo.edu> wrote:
>>>>
>>>> This parent POM like any other parent POM provides default values, i.e.
>>>> something that projects can override as they see fit. Correct me if I'm
>>>> mistaken, but I'm under the impression that Site Plugin 2.2 is generally an
>>>> improvement over version 2.0.1 and as such a better default version. So I
>>>> support this version bump.
>>>
>>> By that logic, which I happen to agree with, then shouldn't the
>>> compiler plugin start using 1.5 by default then?
>>
>> This is not set in the POM but the default is 1.5 now:
>>
>> http://svn.apache.org/repos/asf/maven/plugins/trunk/maven-compiler-plugin/src/main/java/org/apache/maven/plugin/AbstractCompilerMojo.java
>>
>
> Right, but setting it to 1.4 in the ASF pom keeps any Apache project
> at 1.4 unless they override. I'm fine to flip the source/target.
>
> What about the site version? If 2.2 requires a more recent version of
> Maven, then perhaps we should go with the safer version. I think the
> ASF pom isn't a place to be particularly progressive in settings, it
> should be minimal sensible defaults.
For the record, I agree with Benjamin that 2.2 is a sensible default.
The main concerns last time, IIRC were about doxia being rather new and
untested, that should be obsolete by now.
Since it's recommended best practice anyway to specify the version of
*every* plugin you use, I think it's reasonable to set as defaults
whatever we recommend to use. So unless a given version is known to
break things, I see no reason not to be progressive with defaults.
-Lukas
>
>>>
>>> -Jesse
>>>
>>> --
>>> There are 10 types of people in this world, those
>>> that can read binary and those that can not.
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>
>>
>> Thanks,
>>
>> Jason
>>
>> ----------------------------------------------------------
>> Jason van Zyl
>> Founder, Apache Maven
>> http://twitter.com/jvanzyl
>> ---------------------------------------------------------
>>
>> A man enjoys his work when he understands the whole and when he
>> is responsible for the quality of the whole
>>
>> -- Christopher Alexander, A Pattern Language
>>
>>
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r1069599 - /maven/pom/trunk/asf/pom.xml
Posted by Brian Fox <br...@infinity.nu>.
On Fri, Feb 11, 2011 at 9:07 AM, Jason van Zyl <ja...@sonatype.com> wrote:
>
> On Feb 11, 2011, at 7:54 AM, Jesse Farinacci wrote:
>
>> Greetings,
>>
>> On Fri, Feb 11, 2011 at 6:15 AM, Benjamin Bentmann
>> <be...@udo.edu> wrote:
>>>
>>> This parent POM like any other parent POM provides default values, i.e.
>>> something that projects can override as they see fit. Correct me if I'm
>>> mistaken, but I'm under the impression that Site Plugin 2.2 is generally an
>>> improvement over version 2.0.1 and as such a better default version. So I
>>> support this version bump.
>>
>> By that logic, which I happen to agree with, then shouldn't the
>> compiler plugin start using 1.5 by default then?
>
> This is not set in the POM but the default is 1.5 now:
>
> http://svn.apache.org/repos/asf/maven/plugins/trunk/maven-compiler-plugin/src/main/java/org/apache/maven/plugin/AbstractCompilerMojo.java
>
Right, but setting it to 1.4 in the ASF pom keeps any Apache project
at 1.4 unless they override. I'm fine to flip the source/target.
What about the site version? If 2.2 requires a more recent version of
Maven, then perhaps we should go with the safer version. I think the
ASF pom isn't a place to be particularly progressive in settings, it
should be minimal sensible defaults.
>>
>> -Jesse
>>
>> --
>> There are 10 types of people in this world, those
>> that can read binary and those that can not.
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>
> Thanks,
>
> Jason
>
> ----------------------------------------------------------
> Jason van Zyl
> Founder, Apache Maven
> http://twitter.com/jvanzyl
> ---------------------------------------------------------
>
> A man enjoys his work when he understands the whole and when he
> is responsible for the quality of the whole
>
> -- Christopher Alexander, A Pattern Language
>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r1069599 - /maven/pom/trunk/asf/pom.xml
Posted by Jesse Farinacci <ji...@gmail.com>.
WOO WOO!!! Nice one :-)
On Fri, Feb 11, 2011 at 9:07 AM, Jason van Zyl <ja...@sonatype.com> wrote:
> This is not set in the POM but the default is 1.5 now:
> http://svn.apache.org/repos/asf/maven/plugins/trunk/maven-compiler-plugin/src/main/java/org/apache/maven/plugin/AbstractCompilerMojo.java
-Jesse
--
There are 10 types of people in this world, those
that can read binary and those that can not.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r1069599 - /maven/pom/trunk/asf/pom.xml
Posted by Jason van Zyl <ja...@sonatype.com>.
On Feb 11, 2011, at 7:54 AM, Jesse Farinacci wrote:
> Greetings,
>
> On Fri, Feb 11, 2011 at 6:15 AM, Benjamin Bentmann
> <be...@udo.edu> wrote:
>>
>> This parent POM like any other parent POM provides default values, i.e.
>> something that projects can override as they see fit. Correct me if I'm
>> mistaken, but I'm under the impression that Site Plugin 2.2 is generally an
>> improvement over version 2.0.1 and as such a better default version. So I
>> support this version bump.
>
> By that logic, which I happen to agree with, then shouldn't the
> compiler plugin start using 1.5 by default then?
This is not set in the POM but the default is 1.5 now:
http://svn.apache.org/repos/asf/maven/plugins/trunk/maven-compiler-plugin/src/main/java/org/apache/maven/plugin/AbstractCompilerMojo.java
>
> -Jesse
>
> --
> There are 10 types of people in this world, those
> that can read binary and those that can not.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
Thanks,
Jason
----------------------------------------------------------
Jason van Zyl
Founder, Apache Maven
http://twitter.com/jvanzyl
---------------------------------------------------------
A man enjoys his work when he understands the whole and when he
is responsible for the quality of the whole
-- Christopher Alexander, A Pattern Language
Re: svn commit: r1069599 - /maven/pom/trunk/asf/pom.xml
Posted by nicolas de loof <ni...@gmail.com>.
2011/2/11 Jesse Farinacci <ji...@gmail.com>
> Hi,
>
> On Fri, Feb 11, 2011 at 7:58 AM, nicolas de loof
> <ni...@gmail.com> wrote:
> > It does, since version 2.3, but the version set by super-pom is more
> > conservative
> > Maybe you suggested Apache POM should set a recent compiler plugin
> version ?
>
> Check http://svn.apache.org/viewvc/maven/pom/trunk/asf/pom.xml?view=markup
> line 126-127. If you're going to bump from the ancient Maven 2.0.x
> line to Maven 2.2.x line, why not go all the way? Let's get default
> values out of 1990s and into 2000s. :-)
>
I missed this one.
+1 to start working in XIth century ;)
>
> -Jesse
>
> --
> There are 10 types of people in this world, those
> that can read binary and those that can not.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: svn commit: r1069599 - /maven/pom/trunk/asf/pom.xml
Posted by Jesse Farinacci <ji...@gmail.com>.
Hi,
On Fri, Feb 11, 2011 at 7:58 AM, nicolas de loof
<ni...@gmail.com> wrote:
> It does, since version 2.3, but the version set by super-pom is more
> conservative
> Maybe you suggested Apache POM should set a recent compiler plugin version ?
Check http://svn.apache.org/viewvc/maven/pom/trunk/asf/pom.xml?view=markup
line 126-127. If you're going to bump from the ancient Maven 2.0.x
line to Maven 2.2.x line, why not go all the way? Let's get default
values out of 1990s and into 2000s. :-)
-Jesse
--
There are 10 types of people in this world, those
that can read binary and those that can not.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r1069599 - /maven/pom/trunk/asf/pom.xml
Posted by nicolas de loof <ni...@gmail.com>.
>
>
> By that logic, which I happen to agree with, then shouldn't the
> compiler plugin start using 1.5 by default then?
>
It does, since version 2.3, but the version set by super-pom is more
conservative
Maybe you suggested Apache POM should set a recent compiler plugin version ?
Nicolas
>
> -Jesse
>
> --
> There are 10 types of people in this world, those
> that can read binary and those that can not.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: svn commit: r1069599 - /maven/pom/trunk/asf/pom.xml
Posted by Jesse Farinacci <ji...@gmail.com>.
Greetings,
On Fri, Feb 11, 2011 at 6:15 AM, Benjamin Bentmann
<be...@udo.edu> wrote:
>
> This parent POM like any other parent POM provides default values, i.e.
> something that projects can override as they see fit. Correct me if I'm
> mistaken, but I'm under the impression that Site Plugin 2.2 is generally an
> improvement over version 2.0.1 and as such a better default version. So I
> support this version bump.
By that logic, which I happen to agree with, then shouldn't the
compiler plugin start using 1.5 by default then?
-Jesse
--
There are 10 types of people in this world, those
that can read binary and those that can not.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r1069599 - /maven/pom/trunk/asf/pom.xml
Posted by Benjamin Bentmann <be...@udo.edu>.
Lukas Theussl wrote:
> however site-plugin-2.2 uses doxia-1.1 and has
> a prereq of maven 2.2, I seem to remember some resistance last time to
> use it by default. Is this no issue anymore?
This parent POM like any other parent POM provides default values, i.e.
something that projects can override as they see fit. Correct me if I'm
mistaken, but I'm under the impression that Site Plugin 2.2 is generally
an improvement over version 2.0.1 and as such a better default version.
So I support this version bump.
On a related note, I'm also under the impression that using Maven 2.2.1
is recommended over using Maven 2.0.x, i.e. I don't see a big issue with
the plugin's prerequisite.
Benjamin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r1069599 - /maven/pom/trunk/asf/pom.xml
Posted by Brian Fox <br...@infinity.nu>.
On Fri, Feb 11, 2011 at 3:00 AM, Lukas Theussl <lt...@apache.org> wrote:
>
> Brian,
>
> I am happy about this :) however site-plugin-2.2 uses doxia-1.1 and has a
> prereq of maven 2.2, I seem to remember some resistance last time to use it
> by default. Is this no issue anymore?
>
I didn't bump it to 2.2, Olivier did I think and I accidentally
reverted it and then put it back. I don't know what the concerns are
around 2.2
> I'd also appreciate some explanations concerning your comment in the vote
> thread 'preparations to make Maven3 builds use the correct site plugin'.
> What's the plan there?
>
> Thanks,
> -Lukas
>
>
> brianf@apache.org wrote:
>>
>> Author: brianf
>> Date: Thu Feb 10 22:50:03 2011
>> New Revision: 1069599
>>
>> URL: http://svn.apache.org/viewvc?rev=1069599&view=rev
>> Log:
>> set the site version back to 2.2
>>
>> Modified:
>> maven/pom/trunk/asf/pom.xml
>>
>> Modified: maven/pom/trunk/asf/pom.xml
>> URL:
>> http://svn.apache.org/viewvc/maven/pom/trunk/asf/pom.xml?rev=1069599&r1=1069598&r2=1069599&view=diff
>>
>> ==============================================================================
>> --- maven/pom/trunk/asf/pom.xml (original)
>> +++ maven/pom/trunk/asf/pom.xml Thu Feb 10 22:50:03 2011
>> @@ -215,7 +215,7 @@ under the License.
>> <plugin>
>> <groupId>org.apache.maven.plugins</groupId>
>> <artifactId>maven-site-plugin</artifactId>
>> -<version>2.0.1</version>
>> +<version>2.2</version>
>> </plugin>
>> <plugin>
>> <groupId>org.apache.maven.plugins</groupId>
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org