You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/01/17 22:33:55 UTC

[GitHub] redsanket commented on a change in pull request #23577: [SPARK-26658][PySpark] : Call pickle.dump with protocol version 3 for Python 3…

redsanket commented on a change in pull request #23577: [SPARK-26658][PySpark] : Call pickle.dump with protocol version 3 for Python 3…
URL: https://github.com/apache/spark/pull/23577#discussion_r248867243
 
 

 ##########
 File path: python/pyspark/broadcast.py
 ##########
 @@ -29,8 +29,10 @@
 
 if sys.version < '3':
     import cPickle as pickle
+    protocol = 2
 else:
     import pickle
+    protocol = 3
 
 Review comment:
   guess we can use pickle.DEFAULT_PROTOCOL and pickle.DEFAULT_PROTOCOL - 1 just a thought not sure it matters 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org