You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/10 16:01:34 UTC
[GitHub] [spark] huangxiaopingRD opened a new pull request, #38191: [SPARK-40735] Consistently invoke bash with /usr/bin/env bash in scri…
huangxiaopingRD opened a new pull request, #38191:
URL: https://github.com/apache/spark/pull/38191
### What changes were proposed in this pull request?
Consistently invoke bash with /usr/bin/env bash in scripts to make code more portable
### Why are the changes needed?
some bash still use #!/bin/bash
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
no need test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huangxiaopingRD commented on pull request #38191: [SPARK-40735] Consistently invoke bash with /usr/bin/env bash in scripts to make code more portable
Posted by GitBox <gi...@apache.org>.
huangxiaopingRD commented on PR #38191:
URL: https://github.com/apache/spark/pull/38191#issuecomment-1274088033
> Can you try retriggering tests? I think that's an unrelated failure
Check passed. Please help to review, thanks~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #38191: [SPARK-40735] Consistently invoke bash with /usr/bin/env bash in scripts to make code more portable
Posted by GitBox <gi...@apache.org>.
srowen closed pull request #38191: [SPARK-40735] Consistently invoke bash with /usr/bin/env bash in scripts to make code more portable
URL: https://github.com/apache/spark/pull/38191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huangxiaopingRD commented on pull request #38191: [SPARK-40735] Consistently invoke bash with /usr/bin/env bash in scripts to make code more portable
Posted by GitBox <gi...@apache.org>.
huangxiaopingRD commented on PR #38191:
URL: https://github.com/apache/spark/pull/38191#issuecomment-1273624942
> Sounds good. Is there any situation in which this wouldn't work? I can't think of one
"#!/bin/bash" specifies that the path of bash is under the bin directory. Once there is no bash command in the bin directory, the execution will fail, but usually this is unlikely to happen unless the user changes the bash command, such as , with multiple versions of the bash command installed. "#!/usr/bin/env bash" will look for the bash command according to the path set in the environment variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #38191: [SPARK-40735] Consistently invoke bash with /usr/bin/env bash in scripts to make code more portable
Posted by GitBox <gi...@apache.org>.
srowen commented on PR #38191:
URL: https://github.com/apache/spark/pull/38191#issuecomment-1273627962
Right I know that, just wondering if the new version ever doesnt work but I can't think of a scenario
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #38191: [SPARK-40735] Consistently invoke bash with /usr/bin/env bash in scripts to make code more portable
Posted by GitBox <gi...@apache.org>.
srowen commented on PR #38191:
URL: https://github.com/apache/spark/pull/38191#issuecomment-1274686819
Merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #38191: [SPARK-40735] Consistently invoke bash with /usr/bin/env bash in scripts to make code more portable
Posted by GitBox <gi...@apache.org>.
srowen commented on PR #38191:
URL: https://github.com/apache/spark/pull/38191#issuecomment-1273913601
Can you try retriggering tests? I think that's an unrelated failure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #38191: [SPARK-40735] Consistently invoke bash with /usr/bin/env bash in scripts to make code more portable
Posted by GitBox <gi...@apache.org>.
srowen commented on PR #38191:
URL: https://github.com/apache/spark/pull/38191#issuecomment-1273602424
Sounds good. Is there any situation in which this wouldn't work? I can't think of one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huangxiaopingRD commented on pull request #38191: [SPARK-40735] Consistently invoke bash with /usr/bin/env bash in scripts to make code more portable
Posted by GitBox <gi...@apache.org>.
huangxiaopingRD commented on PR #38191:
URL: https://github.com/apache/spark/pull/38191#issuecomment-1273632976
> Right I know that, just wondering if the new version ever doesnt work but I can't think of a scenario
Hahahaha, you're right to be worried, but I can't think of any scenario that could go wrong either. I have tested it on mac and linux and it is normal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org