[GitHub] incubator-samoa pull request #59: SAMOA-65 Apache Kafka integration componen...

[gdfm <gi...@git.apache.org>]

Github user gdfm commented on a diff in the pull request:

    https://github.com/apache/incubator-samoa/pull/59#discussion_r125465790
  
    --- Diff: samoa-api/pom.xml ---
    @@ -1,129 +1,154 @@
    -<?xml version="1.0" encoding="UTF-8"?>
    -<!--
    -  #%L
    -  SAMOA
    -  %%
    -  Copyright (C) 2014 - 2015 Apache Software Foundation
    -  %%
    -  Licensed under the Apache License, Version 2.0 (the "License");
    -  you may not use this file except in compliance with the License.
    -  You may obtain a copy of the License at
    -  
    -       http://www.apache.org/licenses/LICENSE-2.0
    -  
    -  Unless required by applicable law or agreed to in writing, software
    -  distributed under the License is distributed on an "AS IS" BASIS,
    -  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    -  See the License for the specific language governing permissions and
    -  limitations under the License.
    -  #L%
    -  -->
    -
    -<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    -  <modelVersion>4.0.0</modelVersion>
    -  <properties>
    -    <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
    -  </properties>
    -
    -  <name>samoa-api</name>
    -  <description>API and algorithms for SAMOA</description>
    -
    -  <artifactId>samoa-api</artifactId>
    -  <parent>
    -    <groupId>org.apache.samoa</groupId>
    -    <artifactId>samoa</artifactId>
    -    <version>0.5.0-incubating-SNAPSHOT</version>
    -  </parent>
    -
    -  <dependencies>
    -    <dependency>
    -      <groupId>com.yammer.metrics</groupId>
    -      <artifactId>metrics-core</artifactId>
    -      <version>${metrics-core.version}</version>
    -    </dependency>
    -
    -    <dependency>
    -      <groupId>net.jcip</groupId>
    -      <artifactId>jcip-annotations</artifactId>
    -      <version>${jcip-annotations.version}</version>
    -    </dependency>
    -
    -    <dependency>
    -      <groupId>org.apache.commons</groupId>
    -      <artifactId>commons-lang3</artifactId>
    -      <version>${commons-lang3.version}</version>
    -    </dependency>
    -
    -    <dependency>
    -      <groupId>com.github.javacliparser</groupId>
    -      <artifactId>javacliparser</artifactId>
    -      <version>${javacliparser.version}</version>
    -    </dependency>
    -
    -    <dependency>
    -      <groupId>org.apache.samoa</groupId>
    -      <artifactId>samoa-instances</artifactId>
    -      <version>${project.version}</version>
    -    </dependency>
    -
    -    <dependency>
    -      <groupId>com.google.guava</groupId>
    -      <artifactId>guava</artifactId>
    -      <version>${guava.version}</version>
    -    </dependency>
    -
    -    <dependency>
    -      <groupId>com.esotericsoftware.kryo</groupId>
    -      <artifactId>kryo</artifactId>
    -      <version>${kryo.version}</version>
    -    </dependency>
    -
    -    <dependency>
    -      <groupId>com.dreizak</groupId>
    -      <artifactId>miniball</artifactId>
    -      <version>${miniball.version}</version>
    -    </dependency>
    -
    -    <dependency>
    -      <groupId>org.apache.hadoop</groupId>
    -      <artifactId>hadoop-common</artifactId>
    -      <version>${hadoop.version}</version>
    -    </dependency>
    -    <dependency>
    -      <groupId>org.apache.hadoop</groupId>
    -      <artifactId>hadoop-hdfs</artifactId>
    -      <version>${hadoop.version}</version>
    -    </dependency>
    -    <dependency>
    -      <groupId>org.apache.hadoop</groupId>
    -      <artifactId>hadoop-minicluster</artifactId>
    -      <version>${hadoop.version}</version>
    -      <scope>test</scope>
    -    </dependency>
    -  </dependencies>
    -
    -  <build>
    -    <plugins>
    -      <plugin>
    -        <groupId>org.apache.maven.plugins</groupId>
    -        <artifactId>maven-dependency-plugin</artifactId>
    -        <version>${maven-dependency-plugin.version}</version>
    -        <executions>
    -          <execution>
    -            <id>copy-dependencies</id>
    -            <phase>package</phase>
    -            <goals>
    -              <goal>copy-dependencies</goal>
    -            </goals>
    -            <configuration>
    -              <outputDirectory>${project.build.directory}/lib</outputDirectory>
    -              <overWriteReleases>false</overWriteReleases>
    -              <overWriteSnapshots>false</overWriteSnapshots>
    -              <overWriteIfNewer>true</overWriteIfNewer>
    -            </configuration>
    -          </execution>
    -        </executions>
    -      </plugin>
    -    </plugins>
    -  </build>
    -</project>
    +<?xml version="1.0" encoding="UTF-8"?>
    --- End diff --
    
    There are a number of changes in the line endings, it seems to be a Linux/Windows problem.
    Can you please revert them?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---