[GitHub] kimmking commented on a change in pull request #1994: avro serialization implement

[GitBox <gi...@apache.org>]

kimmking commented on a change in pull request #1994: avro serialization implement
URL: https://github.com/apache/incubator-dubbo/pull/1994#discussion_r198242350
 
 

 ##########
 File path: dubbo-serialization/dubbo-serialization-avro/src/main/java/org/apache/dubbo/common/serialize/avro/AvroObjectInput.java
 ##########
 @@ -0,0 +1,103 @@
+package org.apache.dubbo.common.serialize.avro;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.lang.reflect.Type;
+import java.util.HashMap;
+import java.util.Map;
+
+import org.apache.avro.io.BinaryDecoder;
+import org.apache.avro.io.DecoderFactory;
+import org.apache.avro.reflect.ReflectDatumReader;
+import org.apache.avro.util.Utf8;
+import org.apache.dubbo.common.serialize.ObjectInput;
+
+public class AvroObjectInput implements ObjectInput{
+	private DecoderFactory decoderFactory=DecoderFactory.get();;
+	private BinaryDecoder decoder;
+	
+	public AvroObjectInput(InputStream in){
+		init(in);
+	}
+	
+	public void init(InputStream in){
 
 Review comment:
   move to method AvroObjectInput(InputStream in)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org