You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/03 19:36:55 UTC

[GitHub] [arrow] nealrichardson commented on a change in pull request #12536: ARROW-13168: [C++][R] Enable runtime timezone database for Windows

nealrichardson commented on a change in pull request #12536:
URL: https://github.com/apache/arrow/pull/12536#discussion_r819002496



##########
File path: r/R/dplyr-funcs-datetime.R
##########
@@ -15,6 +15,15 @@
 # specific language governing permissions and limitations
 # under the License.
 
+check_locale <- function(locale = Sys.getlocale("LC_TIME")) {

Review comment:
       It looks like this is only about LC_TIME and its use in strftime, so let's name the function and revise the error message to reflect that




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org