[GitHub] [ozone] GeorgeJahad commented on pull request #3824: HDDS-7281. [Snapshot] Handle RocksDB compaction DAG persistence and reconstruction

[GitBox <gi...@apache.org>]

GeorgeJahad commented on PR #3824:
URL: https://github.com/apache/ozone/pull/3824#issuecomment-1276774483

   These lines are confusing to me:  https://github.com/apache/ozone/blob/c7e922fb0c4d4c6c312bd717246c9fd8fde27e6f/hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java#L734-L738
   
   I think something like this would be clearer:
   ```
         Set<CompactionNode> currentLevel = new HashSet<>();
         currentLevel.add(infileNode);
         Set<CompactionNode> nextLevel = new HashSet<>();
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org