[L] Change in asterixdb[trinity]: [ASTERIXDB-3677][COMP] Don't push LIMIT without condition

[AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>]

From Ali Alsuliman <al...@gmail.com>:

Attention is currently required from: Ali Alsuliman.

Hello Anon. E. Moose #1000171, Jenkins, 

I'd like you to reexamine a change. Please visit

    https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21132?usp=email

to look at the new patch set (#3).

The following approvals got outdated and were removed:
Contrib-2 by Anon. E. Moose #1000171, Integration-Tests+1 by Jenkins, Verified+1 by Jenkins, Verified-1 by Anon. E. Moose #1000171


Change subject: [ASTERIXDB-3677][COMP] Don't push LIMIT without condition
......................................................................

[ASTERIXDB-3677][COMP] Don't push LIMIT without condition

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
This patch is to fix the regression caused by:
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20592.

The LIMIT push-down to UNNEST-MAP should have been
done only to the case where there is no condition to
begin with. The other case where there is a LIMIT and
condition, LIMIT should not be pushed down alone without
the condition. To push the LIMIT and the condition, the
current index search runtime needs to be changed so that
the complete tuple is constructed to allow the condition
to be evaluated correctly which was already done in a later
version to accommodate columnar filters.

Ext-ref: MB-71453

Change-Id: Ibb3d38799359d329d5c77cde3c121aeb72fbd2a3
---
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushLimitIntoPrimarySearchRule.java
M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/limit/push-limit-to-join-primary-lookup/push-limit-to-join-primary-lookup.01.ddl.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/limit/push-limit-to-join-primary-lookup/push-limit-to-join-primary-lookup.02.update.sqlpp
A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/limit/push-limit-to-join-primary-lookup/push-limit-to-join-primary-lookup.04.query.sqlpp
A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/limit/push-limit-to-join-primary-lookup/push-limit-to-join-primary-lookup.05.query.sqlpp
A asterixdb/asterix-app/src/test/resources/runtimets/results/limit/push-limit-to-join-primary-lookup/push-limit-to-join-primary-lookup.04.adm
A asterixdb/asterix-app/src/test/resources/runtimets/results/limit/push-limit-to-join-primary-lookup/push-limit-to-join-primary-lookup.05.plan
M asterixdb/asterix-app/src/test/resources/runtimets/results/tpcds/q90/q90.2.plan
8 files changed, 295 insertions(+), 14 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/32/21132/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21132?usp=email
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email

Gerrit-MessageType: newpatchset
Gerrit-Project: asterixdb
Gerrit-Branch: trinity
Gerrit-Change-Id: Ibb3d38799359d329d5c77cde3c121aeb72fbd2a3
Gerrit-Change-Number: 21132
Gerrit-PatchSet: 3
Gerrit-Owner: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Attention: Ali Alsuliman <al...@gmail.com>