You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/10/13 14:38:27 UTC
[GitHub] [iotdb] LIU-WEI-git opened a new pull request #4150: Make SessionPool.executeQueryStatement support querying with timeout.
LIU-WEI-git opened a new pull request #4150:
URL: https://github.com/apache/iotdb/pull/4150
Overload SessionPool.executeQueryStatement and make it support querying with timeout.
<hr>
This PR has:
- [x] been self-reviewed.
- [ ] concurrent read
- [ ] concurrent write
- [ ] concurrent read and write
- [ ] added documentation for new or modified features or behaviors.
- [x] added Javadocs for most classes and all non-trivial methods.
- [x] added comments explaining the "why" and the intent of the code wherever would not be obvious
for an unfamiliar reader.
- [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold
for code coverage.
- [ ] been tested in a test IoTDB cluster.
<hr>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls commented on pull request #4150: Make SessionPool.executeQueryStatement support querying with timeout.
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #4150:
URL: https://github.com/apache/iotdb/pull/4150#issuecomment-942421057
[](https://coveralls.io/builds/43478413)
Coverage increased (+0.007%) to 67.751% when pulling **6d93a8952a8c184ead02ebfcd35d372a96e341ee on LIU-WEI-git:pool_query_timout** into **c662a3e86de46aecc56236f0c2b693a2c479f38d on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls commented on pull request #4150: Make SessionPool.executeQueryStatement support querying with timeout.
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #4150:
URL: https://github.com/apache/iotdb/pull/4150#issuecomment-942421057
[](https://coveralls.io/builds/43478413)
Coverage increased (+0.007%) to 67.751% when pulling **6d93a8952a8c184ead02ebfcd35d372a96e341ee on LIU-WEI-git:pool_query_timout** into **c662a3e86de46aecc56236f0c2b693a2c479f38d on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] wangchao316 merged pull request #4150: Make SessionPool.executeQueryStatement support querying with timeout.
Posted by GitBox <gi...@apache.org>.
wangchao316 merged pull request #4150:
URL: https://github.com/apache/iotdb/pull/4150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] Alima777 commented on pull request #4150: Make SessionPool.executeQueryStatement support querying with timeout.
Posted by GitBox <gi...@apache.org>.
Alima777 commented on pull request #4150:
URL: https://github.com/apache/iotdb/pull/4150#issuecomment-942870086
Good job~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org