You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Jarek Gawor (JIRA)" <ji...@apache.org> on 2008/03/20 15:43:24 UTC

[jira] Created: (GERONIMO-3934) geronimo/start-server --timeout option does not work as expected

geronimo/start-server --timeout option does not work as expected
----------------------------------------------------------------

                 Key: GERONIMO-3934
                 URL: https://issues.apache.org/jira/browse/GERONIMO-3934
             Project: Geronimo
          Issue Type: Bug
      Security Level: public (Regular issues)
          Components: startup/shutdown
    Affects Versions: 2.1, 2.1.1, 2.2
            Reporter: Jarek Gawor
            Assignee: Jarek Gawor


The --timeout option specifies the time in which the server must start up in. However, it looks like the timeout causes the server to shutdown after the given number of seconds even if the server started up successfully.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-3934) geronimo/start-server --timeout option does not work as expected

Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-3934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12580821#action_12580821 ] 

Jarek Gawor commented on GERONIMO-3934:
---------------------------------------

The important bit of code is the following:

                    if (timeout > 0) {
                        log.info("Timeout after: ${timeout} seconds")
                        node.setAttribute('timeout', "${timeout * 1000}")
                    }

That sets the timeout on the Ant Java task which explains why the --timeout option behavior.

We can remove the piece of code but we still need a way to shutdown the server in case it didn't start in time. And I'm not sure how to shutdown the server process started via Ant.

Another way to make timeout option work right is to rewrite the StartServerCommand to use ProcessBuilder API directly to start the server process instead of Ant. But that's a bigger job.


> geronimo/start-server --timeout option does not work as expected
> ----------------------------------------------------------------
>
>                 Key: GERONIMO-3934
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3934
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: startup/shutdown
>    Affects Versions: 2.1, 2.1.1, 2.2
>            Reporter: Jarek Gawor
>            Assignee: Jarek Gawor
>
> The --timeout option specifies the time in which the server must start up in. However, it looks like the timeout causes the server to shutdown after the given number of seconds even if the server started up successfully.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-3934) geronimo/start-server --timeout option does not work as expected

Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-3934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12581084#action_12581084 ] 

Jarek Gawor commented on GERONIMO-3934:
---------------------------------------

--verifyTimeout? There is no such option for start-server but there is one in geronimo-maven-plugin. 

Even if we add --verifyTimeout to start-server, how do we kill the server process?



> geronimo/start-server --timeout option does not work as expected
> ----------------------------------------------------------------
>
>                 Key: GERONIMO-3934
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3934
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: startup/shutdown
>    Affects Versions: 2.1, 2.1.1, 2.2
>            Reporter: Jarek Gawor
>            Assignee: Jarek Gawor
>
> The --timeout option specifies the time in which the server must start up in. However, it looks like the timeout causes the server to shutdown after the given number of seconds even if the server started up successfully.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (GERONIMO-3934) geronimo/start-server --timeout option does not work as expected

Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-3934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jarek Gawor reassigned GERONIMO-3934:
-------------------------------------

    Assignee:     (was: Jarek Gawor)

> geronimo/start-server --timeout option does not work as expected
> ----------------------------------------------------------------
>
>                 Key: GERONIMO-3934
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3934
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: startup/shutdown
>    Affects Versions: 2.1, 2.1.1, 2.2
>            Reporter: Jarek Gawor
>
> The --timeout option specifies the time in which the server must start up in. However, it looks like the timeout causes the server to shutdown after the given number of seconds even if the server started up successfully.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-3934) geronimo/start-server --timeout option does not work as expected

Posted by "Jason Dillon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-3934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12581005#action_12581005 ] 

Jason Dillon commented on GERONIMO-3934:
----------------------------------------

I was mistaken, --verifyTimeout is for the verify bits and --timeout is for the process, meant to kill the server after a set time, used for tests to ensure that the server stops after some time.

> geronimo/start-server --timeout option does not work as expected
> ----------------------------------------------------------------
>
>                 Key: GERONIMO-3934
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3934
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: startup/shutdown
>    Affects Versions: 2.1, 2.1.1, 2.2
>            Reporter: Jarek Gawor
>            Assignee: Jarek Gawor
>
> The --timeout option specifies the time in which the server must start up in. However, it looks like the timeout causes the server to shutdown after the given number of seconds even if the server started up successfully.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.