You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by br...@apache.org on 2016/04/17 14:58:23 UTC
svn commit: r1739599 - /subversion/trunk/subversion/libsvn_diff/binary_diff.c
Author: brane
Date: Sun Apr 17 12:58:23 2016
New Revision: 1739599
URL: http://svn.apache.org/viewvc?rev=1739599&view=rev
Log:
Silence a warning about an implicit narrowing conversion.
* subversion/libsvn_diff/binary_diff.c (base85_value):
Explicitly cast the base-85 digit value from ptrdiff_t to int.
Modified:
subversion/trunk/subversion/libsvn_diff/binary_diff.c
Modified: subversion/trunk/subversion/libsvn_diff/binary_diff.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_diff/binary_diff.c?rev=1739599&r1=1739598&r2=1739599&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_diff/binary_diff.c (original)
+++ subversion/trunk/subversion/libsvn_diff/binary_diff.c Sun Apr 17 12:58:23 2016
@@ -103,7 +103,9 @@ base85_value(int *value, char c)
return svn_error_create(SVN_ERR_DIFF_UNEXPECTED_DATA, NULL,
_("Invalid base85 value"));
- *value = (p - b85str);
+ /* It's safe to cast the ptrdiff_t value of the pointer difference
+ to int because the value will always be in the range [0..84]. */
+ *value = (int)(p - b85str);
return SVN_NO_ERROR;
}