You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/11/26 07:20:05 UTC
[GitHub] [shardingsphere-elasticjob] TeslaCN opened a new pull request #1735: Extract all reloadable objects from ElasticJobExecutor
TeslaCN opened a new pull request #1735:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1735
Fixes #1544
Changes proposed in this pull request:
- Extract `JobErrorHandler`, `ExecutorService` from ElasticJobExecutor into `ExecutorContext`.
- Add interface `Reloadable` and implements `JobErrorHandlerReloadable`, `ExecutorServiceReloadable`.
- Add testcase for implementations of Reloadable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] codecov-io commented on pull request #1735: Extract all reloadable objects from ElasticJobExecutor
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1735:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1735#issuecomment-735027173
# [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1735?src=pr&el=h1) Report
> Merging [#1735](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1735?src=pr&el=desc) (1f7d568) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/1df7beaac29d4907a176710750f7c3dd56c116b1?el=desc) (1df7bea) will **decrease** coverage by `0.08%`.
> The diff coverage is `83.11%`.
[](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1735?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1735 +/- ##
============================================
- Coverage 86.18% 86.10% -0.09%
- Complexity 105 108 +3
============================================
Files 252 255 +3
Lines 5682 5749 +67
Branches 878 885 +7
============================================
+ Hits 4897 4950 +53
- Misses 471 478 +7
- Partials 314 321 +7
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1735?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...asticjob/error/handler/JobErrorHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1735/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1lY29zeXN0ZW0vZWxhc3RpY2pvYi1lcnJvci1oYW5kbGVyL2VsYXN0aWNqb2ItZXJyb3ItaGFuZGxlci10eXBlL2VsYXN0aWNqb2ItZXJyb3ItaGFuZGxlci1nZW5lcmFsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2Vycm9yL2hhbmRsZXIvSm9iRXJyb3JIYW5kbGVyRmFjdG9yeS5qYXZh) | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...r/threadpool/JobExecutorServiceHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1735/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLWluZnJhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9pbmZyYS9oYW5kbGVyL3RocmVhZHBvb2wvSm9iRXhlY3V0b3JTZXJ2aWNlSGFuZGxlckZhY3RvcnkuamF2YQ==) | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...e/elasticjob/executor/context/ExecutorContext.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1735/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1lY29zeXN0ZW0vZWxhc3RpY2pvYi1leGVjdXRvci9lbGFzdGljam9iLWV4ZWN1dG9yLWtlcm5lbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9leGVjdXRvci9jb250ZXh0L0V4ZWN1dG9yQ29udGV4dC5qYXZh) | `71.42% <71.42%> (ø)` | `0.00 <0.00> (?)` | |
| [...icjob/error/handler/JobErrorHandlerReloadable.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1735/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1lY29zeXN0ZW0vZWxhc3RpY2pvYi1lcnJvci1oYW5kbGVyL2VsYXN0aWNqb2ItZXJyb3ItaGFuZGxlci10eXBlL2VsYXN0aWNqb2ItZXJyb3ItaGFuZGxlci1nZW5lcmFsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2Vycm9yL2hhbmRsZXIvSm9iRXJyb3JIYW5kbGVyUmVsb2FkYWJsZS5qYXZh) | `82.60% <82.60%> (ø)` | `2.00 <2.00> (?)` | |
| [...ob/infra/concurrent/ExecutorServiceReloadable.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1735/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLWluZnJhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9pbmZyYS9jb25jdXJyZW50L0V4ZWN1dG9yU2VydmljZVJlbG9hZGFibGUuamF2YQ==) | `90.47% <90.47%> (ø)` | `2.00 <2.00> (?)` | |
| [...sphere/elasticjob/executor/ElasticJobExecutor.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1735/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1lY29zeXN0ZW0vZWxhc3RpY2pvYi1leGVjdXRvci9lbGFzdGljam9iLWV4ZWN1dG9yLWtlcm5lbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9leGVjdXRvci9FbGFzdGljSm9iRXhlY3V0b3IuamF2YQ==) | `91.30% <91.66%> (+0.19%)` | `0.00 <0.00> (ø)` | |
| [...e/shardingsphere/elasticjob/infra/env/IpUtils.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1735/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLWluZnJhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9pbmZyYS9lbnYvSXBVdGlscy5qYXZh) | `60.00% <0.00%> (-4.62%)` | `0.00% <0.00%> (ø%)` | |
| [...ticjob/lite/internal/snapshot/SnapshotService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1735/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc25hcHNob3QvU25hcHNob3RTZXJ2aWNlLmphdmE=) | `80.95% <0.00%> (ø)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [2 more](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1735/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1735?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1735?src=pr&el=footer). Last update [1df7bea...1f7d568](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1735?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] codecov-io edited a comment on pull request #1735: Extract all reloadable objects from ElasticJobExecutor
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1735:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1735#issuecomment-735027173
# [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1735?src=pr&el=h1) Report
> Merging [#1735](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1735?src=pr&el=desc) (1f7d568) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/1df7beaac29d4907a176710750f7c3dd56c116b1?el=desc) (1df7bea) will **decrease** coverage by `0.03%`.
> The diff coverage is `83.11%`.
[](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1735?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1735 +/- ##
============================================
- Coverage 86.18% 86.15% -0.04%
- Complexity 105 108 +3
============================================
Files 252 255 +3
Lines 5682 5749 +67
Branches 878 885 +7
============================================
+ Hits 4897 4953 +56
- Misses 471 477 +6
- Partials 314 319 +5
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1735?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...asticjob/error/handler/JobErrorHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1735/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1lY29zeXN0ZW0vZWxhc3RpY2pvYi1lcnJvci1oYW5kbGVyL2VsYXN0aWNqb2ItZXJyb3ItaGFuZGxlci10eXBlL2VsYXN0aWNqb2ItZXJyb3ItaGFuZGxlci1nZW5lcmFsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2Vycm9yL2hhbmRsZXIvSm9iRXJyb3JIYW5kbGVyRmFjdG9yeS5qYXZh) | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...r/threadpool/JobExecutorServiceHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1735/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLWluZnJhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9pbmZyYS9oYW5kbGVyL3RocmVhZHBvb2wvSm9iRXhlY3V0b3JTZXJ2aWNlSGFuZGxlckZhY3RvcnkuamF2YQ==) | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...e/elasticjob/executor/context/ExecutorContext.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1735/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1lY29zeXN0ZW0vZWxhc3RpY2pvYi1leGVjdXRvci9lbGFzdGljam9iLWV4ZWN1dG9yLWtlcm5lbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9leGVjdXRvci9jb250ZXh0L0V4ZWN1dG9yQ29udGV4dC5qYXZh) | `71.42% <71.42%> (ø)` | `0.00 <0.00> (?)` | |
| [...icjob/error/handler/JobErrorHandlerReloadable.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1735/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1lY29zeXN0ZW0vZWxhc3RpY2pvYi1lcnJvci1oYW5kbGVyL2VsYXN0aWNqb2ItZXJyb3ItaGFuZGxlci10eXBlL2VsYXN0aWNqb2ItZXJyb3ItaGFuZGxlci1nZW5lcmFsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2Vycm9yL2hhbmRsZXIvSm9iRXJyb3JIYW5kbGVyUmVsb2FkYWJsZS5qYXZh) | `82.60% <82.60%> (ø)` | `2.00 <2.00> (?)` | |
| [...ob/infra/concurrent/ExecutorServiceReloadable.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1735/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLWluZnJhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9pbmZyYS9jb25jdXJyZW50L0V4ZWN1dG9yU2VydmljZVJlbG9hZGFibGUuamF2YQ==) | `90.47% <90.47%> (ø)` | `2.00 <2.00> (?)` | |
| [...sphere/elasticjob/executor/ElasticJobExecutor.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1735/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1lY29zeXN0ZW0vZWxhc3RpY2pvYi1leGVjdXRvci9lbGFzdGljam9iLWV4ZWN1dG9yLWtlcm5lbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9leGVjdXRvci9FbGFzdGljSm9iRXhlY3V0b3IuamF2YQ==) | `91.30% <91.66%> (+0.19%)` | `0.00 <0.00> (ø)` | |
| [...ticjob/lite/internal/snapshot/SnapshotService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1735/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc25hcHNob3QvU25hcHNob3RTZXJ2aWNlLmphdmE=) | `80.95% <0.00%> (ø)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1 more](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1735/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1735?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1735?src=pr&el=footer). Last update [1df7bea...1f7d568](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1735?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] terrymanu merged pull request #1735: Extract all reloadable objects from ElasticJobExecutor
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #1735:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1735
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org