You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/06/26 13:14:57 UTC
[GitHub] [flink] azagrebin commented on a change in pull request #8648:
[FLINK-12738][network] Remove abstract getPageSize method from InputGate
azagrebin commented on a change in pull request #8648: [FLINK-12738][network] Remove abstract getPageSize method from InputGate
URL: https://github.com/apache/flink/pull/8648#discussion_r297657626
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/InputProcessorUtil.java
##########
@@ -53,16 +54,17 @@ public static CheckpointBarrierHandler createCheckpointBarrierHandler(
+ " must be positive or -1 (infinite)");
}
+ int pageSize = ConfigurationParserUtils.getPageSize(taskManagerConfig);
if (taskManagerConfig.getBoolean(NettyShuffleEnvironmentOptions.NETWORK_CREDIT_MODEL)) {
barrierHandler = new BarrierBuffer(
inputGate,
- new CachedBufferBlocker(inputGate.getPageSize()),
+ new CachedBufferBlocker(pageSize),
Review comment:
True, actually we do the implicit coupling between `taskmanager.memory.segment-size` enforcing all shuffle services to use it with no option to use a separate page size. If we do it with `ShuffleEnvironment#getPageSize` then it will be the same for all gates. Not sure whether we should touch it then at all, actually having it in input gate is probably a right thing. Or maybe page size should somehow come from buffers but I do not see how it is possible.
@pnowojski might have more input here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services