[jira] [Commented] (HADOOP-7556) TaskLogAppender does not check if closed before flushing

["Steve Loughran (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-7556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211101#comment-13211101 ] 

Steve Loughran commented on HADOOP-7556:
----------------------------------------

There's a couple of places the patch should go.

* if you want it in trunk & 0.23, then a patch against trunk will usually work in both
* for the 1.x branch, it'll need to be against hadoop/common/branches/branch-1/

                
> TaskLogAppender does not check if closed before flushing
> --------------------------------------------------------
>
>                 Key: HADOOP-7556
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7556
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.20.203.0
>            Reporter: Aaron Morton
>            Priority: Minor
>         Attachments: HADDOP-7556.diff
>
>
> For background see http://groups.google.com/group/brisk-users/browse_thread/thread/3a18f4679673bea8
> http://mail-archives.apache.org/mod_mbox/hadoop-common-user/201108.mbox/%3C4E370C97-1541-4FDA-8456-1067DDDC4D77@thelastpickle.com%3E
> Cassandra is using a log4j PropertyConfigurator which is closing all existing appenders. After a task has completed the TaskLogAppender.flush() is called and it tries to flush without checking if the writer has been closed. I'll upload a patch to check if the writer is closed, and log and silently fail if it is. 
> The real problem is the log4j config collision, we're looking to different log4j LoggerRepositories for that. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira