You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2019/02/07 22:50:53 UTC
[Impala-ASF-CR] Turn off shell debug tracing for create-load-data.sh
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12398
Change subject: Turn off shell debug tracing for create-load-data.sh
......................................................................
Turn off shell debug tracing for create-load-data.sh
This removes a "set -x" from testdata/bin/create-load-data.sh.
Change-Id: I524ec48d0264f6180a13d6d068832809bcc86596
---
M testdata/bin/create-load-data.sh
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/98/12398/1
--
To view, visit http://gerrit.cloudera.org:8080/12398
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I524ec48d0264f6180a13d6d068832809bcc86596
Gerrit-Change-Number: 12398
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] Turn off shell debug tracing for create-load-data.sh
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12398 )
Change subject: Turn off shell debug tracing for create-load-data.sh
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12398
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I524ec48d0264f6180a13d6d068832809bcc86596
Gerrit-Change-Number: 12398
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Feb 2019 23:25:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Turn off shell debug tracing for create-load-data.sh
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12398 )
Change subject: Turn off shell debug tracing for create-load-data.sh
......................................................................
Patch Set 1: Code-Review+2
Oops, sorry about leaving this in there.
--
To view, visit http://gerrit.cloudera.org:8080/12398
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I524ec48d0264f6180a13d6d068832809bcc86596
Gerrit-Change-Number: 12398
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Feb 2019 16:49:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Turn off shell debug tracing for create-load-data.sh
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12398 )
Change subject: Turn off shell debug tracing for create-load-data.sh
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2029/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12398
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I524ec48d0264f6180a13d6d068832809bcc86596
Gerrit-Change-Number: 12398
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Feb 2019 23:16:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Turn off shell debug tracing for create-load-data.sh
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12398 )
Change subject: Turn off shell debug tracing for create-load-data.sh
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3766/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12398
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I524ec48d0264f6180a13d6d068832809bcc86596
Gerrit-Change-Number: 12398
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Feb 2019 19:26:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Turn off shell debug tracing for create-load-data.sh
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12398 )
Change subject: Turn off shell debug tracing for create-load-data.sh
......................................................................
Turn off shell debug tracing for create-load-data.sh
This removes a "set -x" from testdata/bin/create-load-data.sh.
Change-Id: I524ec48d0264f6180a13d6d068832809bcc86596
Reviewed-on: http://gerrit.cloudera.org:8080/12398
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M testdata/bin/create-load-data.sh
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Joe McDonnell: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/12398
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I524ec48d0264f6180a13d6d068832809bcc86596
Gerrit-Change-Number: 12398
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] Turn off shell debug tracing for create-load-data.sh
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12398 )
Change subject: Turn off shell debug tracing for create-load-data.sh
......................................................................
Patch Set 2: Code-Review+2
Rebase, carry +2
--
To view, visit http://gerrit.cloudera.org:8080/12398
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I524ec48d0264f6180a13d6d068832809bcc86596
Gerrit-Change-Number: 12398
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Feb 2019 19:25:43 +0000
Gerrit-HasComments: No