You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/03/11 13:44:52 UTC

[GitHub] [flink] twalthr commented on a change in pull request #15137: [FLINK-21396][table] Resolve tables when calling Catalog.createTable/alterTable

twalthr commented on a change in pull request #15137:
URL: https://github.com/apache/flink/pull/15137#discussion_r592370699



##########
File path: flink-table/flink-table-planner-blink/src/test/java/org/apache/flink/table/planner/runtime/stream/sql/FunctionITCase.java
##########
@@ -1095,7 +1095,7 @@ public void testTimestampNotNull() {
         TestCollectionTableFactory.initData(sourceData);
 
         tEnv().executeSql(
-                        "CREATE TABLE SourceTable(i INT, ts AS LOCALTIMESTAMP, WATERMARK FOR ts AS ts) "
+                        "CREATE TABLE SourceTable(i INT, ts AS CAST(LOCALTIMESTAMP AS TIMESTAMP(3)), WATERMARK FOR ts AS ts) "

Review comment:
       It was necessary, because the new schema validator is a bit more strict when it comes to precision. Currently, we only support time attributes of precision 3. As documented here: https://ci.apache.org/projects/flink/flink-docs-release-1.12/dev/table/sql/create.html#watermark a couple of locations violated this.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org