You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hama.apache.org by "Edward J. Yoon (JIRA)" <ji...@apache.org> on 2009/02/24 03:00:09 UTC

[jira] Created: (HAMA-156) Add SparseMatrix/Vector classes

Add SparseMatrix/Vector classes
-------------------------------

                 Key: HAMA-156
                 URL: https://issues.apache.org/jira/browse/HAMA-156
             Project: Hama
          Issue Type: Sub-task
          Components: implementation
    Affects Versions: 0.1.0
            Reporter: Edward J. Yoon
            Assignee: Edward J. Yoon
             Fix For: 0.1.0




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (HAMA-156) Add SparseMatrix/Vector classes

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon reopened HAMA-156:
---------------------------------


Oh, there is a bug.

During scan the matrix A, we can miss some rows since it's a sparse. We don't save ZEROs as describe below.

0: (1, 0.4), (8, 0.42), ...
2: (1, 0.44), (2, 0.55), ..
3: (4, 0.34), (6, 0.15), ..

We should seperate them using range.

> Add SparseMatrix/Vector classes
> -------------------------------
>
>                 Key: HAMA-156
>                 URL: https://issues.apache.org/jira/browse/HAMA-156
>             Project: Hama
>          Issue Type: Sub-task
>          Components: implementation
>    Affects Versions: 0.1.0
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>             Fix For: 0.1.0
>
>         Attachments: HAMA-156.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HAMA-156) Add SparseMatrix/Vector classes

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HAMA-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678254#action_12678254 ] 

Edward J. Yoon commented on HAMA-156:
-------------------------------------

We also should know start location for each vector.

> Add SparseMatrix/Vector classes
> -------------------------------
>
>                 Key: HAMA-156
>                 URL: https://issues.apache.org/jira/browse/HAMA-156
>             Project: Hama
>          Issue Type: Sub-task
>          Components: implementation
>    Affects Versions: 0.1.0
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>             Fix For: 0.1.0
>
>         Attachments: HAMA-156.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HAMA-156) Add SparseMatrix/Vector classes

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HAMA-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12676155#action_12676155 ] 

Hudson commented on HAMA-156:
-----------------------------

+1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12400814/HAMA-156.patch
against trunk revision 746907.

    @author +1.  The patch does not contain any @author tags.

    tests included +1.  The patch appears to include 12 new or modified tests.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new javac compiler warnings.

    release audit +1.  The applied patch does not generate any new release audit warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests +1.  The patch passed core unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/160/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hama-Patch/160/artifact/trunk/build/reports/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/160/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hama-Patch/160/console

This message is automatically generated.

> Add SparseMatrix/Vector classes
> -------------------------------
>
>                 Key: HAMA-156
>                 URL: https://issues.apache.org/jira/browse/HAMA-156
>             Project: Hama
>          Issue Type: Sub-task
>          Components: implementation
>    Affects Versions: 0.1.0
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>             Fix For: 0.1.0
>
>         Attachments: HAMA-156.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HAMA-156) Add SparseMatrix/Vector classes

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon updated HAMA-156:
--------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I've committed this.

> Add SparseMatrix/Vector classes
> -------------------------------
>
>                 Key: HAMA-156
>                 URL: https://issues.apache.org/jira/browse/HAMA-156
>             Project: Hama
>          Issue Type: Sub-task
>          Components: implementation
>    Affects Versions: 0.1.0
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>             Fix For: 0.1.0
>
>         Attachments: HAMA-156.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HAMA-156) Add SparseMatrix/Vector classes

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HAMA-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12676199#action_12676199 ] 

Edward J. Yoon commented on HAMA-156:
-------------------------------------

As below:

Map1 : 0~100
Map2 : 101~200
Map3 : 201~300
....


> Add SparseMatrix/Vector classes
> -------------------------------
>
>                 Key: HAMA-156
>                 URL: https://issues.apache.org/jira/browse/HAMA-156
>             Project: Hama
>          Issue Type: Sub-task
>          Components: implementation
>    Affects Versions: 0.1.0
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>             Fix For: 0.1.0
>
>         Attachments: HAMA-156.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HAMA-156) Add SparseMatrix/Vector classes

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HAMA-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12676160#action_12676160 ] 

Edward J. Yoon commented on HAMA-156:
-------------------------------------

few bugs also fixed:

+ since we don't know a start index at DenseVector.add(), should check the key/value.
+ DenseMatrix.get() should throw NullPointerException instead zero when it is null



> Add SparseMatrix/Vector classes
> -------------------------------
>
>                 Key: HAMA-156
>                 URL: https://issues.apache.org/jira/browse/HAMA-156
>             Project: Hama
>          Issue Type: Sub-task
>          Components: implementation
>    Affects Versions: 0.1.0
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>             Fix For: 0.1.0
>
>         Attachments: HAMA-156.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HAMA-156) Add SparseMatrix/Vector classes

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon resolved HAMA-156.
---------------------------------

    Resolution: Fixed

Resolving. 
There is a bug, but added sparse matrix/vector classes. I'll create new issue.


> Add SparseMatrix/Vector classes
> -------------------------------
>
>                 Key: HAMA-156
>                 URL: https://issues.apache.org/jira/browse/HAMA-156
>             Project: Hama
>          Issue Type: Sub-task
>          Components: implementation
>    Affects Versions: 0.1.0
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>             Fix For: 0.1.0
>
>         Attachments: HAMA-156.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HAMA-156) Add SparseMatrix/Vector classes

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon updated HAMA-156:
--------------------------------

    Attachment: HAMA-156.patch

Added SparseMatrix/Vector classes and few methods are implemented.

> Add SparseMatrix/Vector classes
> -------------------------------
>
>                 Key: HAMA-156
>                 URL: https://issues.apache.org/jira/browse/HAMA-156
>             Project: Hama
>          Issue Type: Sub-task
>          Components: implementation
>    Affects Versions: 0.1.0
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>             Fix For: 0.1.0
>
>         Attachments: HAMA-156.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HAMA-156) Add SparseMatrix/Vector classes

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon updated HAMA-156:
--------------------------------

    Status: Patch Available  (was: Open)

Trying hudson.

> Add SparseMatrix/Vector classes
> -------------------------------
>
>                 Key: HAMA-156
>                 URL: https://issues.apache.org/jira/browse/HAMA-156
>             Project: Hama
>          Issue Type: Sub-task
>          Components: implementation
>    Affects Versions: 0.1.0
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>             Fix For: 0.1.0
>
>         Attachments: HAMA-156.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.