You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2022/11/22 14:33:41 UTC
[GitHub] [sling-org-apache-sling-testing-rules] Kronnox opened a new pull request, #2: SLING-11679: Add rule for defining a custom user-agent
Kronnox opened a new pull request, #2:
URL: https://github.com/apache/sling-org-apache-sling-testing-rules/pull/2
**Blocked by [sling-org-apache-sling-testing-clients #41](https://github.com/apache/sling-org-apache-sling-testing-clients/pull/41) and release of [Apache Sling Testing Clients 3.0.18](https://issues.apache.org/jira/issues/?jql=project+%3D+SLING+AND+fixVersion+%3D+%22Apache+Sling+Testing+Clients+3.0.18%22).**
Adds a custom JUnit rule for adjusting the user agent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-rules] joerghoh commented on pull request #2: SLING-11733: Add rule for defining a custom user-agent
Posted by GitBox <gi...@apache.org>.
joerghoh commented on PR #2:
URL: https://github.com/apache/sling-org-apache-sling-testing-rules/pull/2#issuecomment-1375737410
works fine here.
```
Apache Maven 3.8.7 (b89d5959fcde851dcb1c8946a785a163f14e1e29)
Maven home: /opt/homebrew/Cellar/maven/3.8.7/libexec
Java version: 11.0.15, vendor: Eclipse Adoptium, runtime: /Users/joerg/java/jdk-11.0.15+10-amd64/Contents/Home
Default locale: en_DE, platform encoding: UTF-8
OS name: "mac os x", version: "13.1", arch: "x86_64", family: "mac"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-rules] rombert commented on pull request #2: SLING-11733: Add rule for defining a custom user-agent
Posted by GitBox <gi...@apache.org>.
rombert commented on PR #2:
URL: https://github.com/apache/sling-org-apache-sling-testing-rules/pull/2#issuecomment-1354924486
I tried to prepare the release but the tests consistently fail for me locally with
```
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] FilterRuleExcludeCategoryTest.testIgnoreIfPropExistsandExcludedCategoryExists:61 Test should be Ignored
[INFO]
[ERROR] Tests run: 63, Failures: 1, Errors: 0, Skipped: 26
```
I tried Java 8, 11, 17, latest check
```
Apache Maven 3.8.6 (SUSE 3.8.6-2.1)
Maven home: /usr/share/maven
Java version: 1.8.0_352, vendor: IcedTea, runtime: /usr/lib64/jvm/java-1.8.0-openjdk-1.8.0/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "6.0.12-1-default", arch: "amd64", family: "unix"
```
@joerghoh - do the test pass for you? I see Jenkins is happy /cc @dulvac
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-rules] rombert merged pull request #2: SLING-11733: Add rule for defining a custom user-agent
Posted by GitBox <gi...@apache.org>.
rombert merged PR #2:
URL: https://github.com/apache/sling-org-apache-sling-testing-rules/pull/2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-rules] rombert commented on pull request #2: SLING-11679: Add rule for defining a custom user-agent
Posted by GitBox <gi...@apache.org>.
rombert commented on PR #2:
URL: https://github.com/apache/sling-org-apache-sling-testing-rules/pull/2#issuecomment-1347337452
@Kronnox - please open a new Sling Jira issue, SLING-11679 is already used for the testing clients and is closed.
@joerghoh - you cut the testing clients release which included SLING-11679, do you have enough context to review this PR as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-rules] enapps-enorman commented on pull request #2: SLING-11679: Add rule for defining a custom user-agent
Posted by GitBox <gi...@apache.org>.
enapps-enorman commented on PR #2:
URL: https://github.com/apache/sling-org-apache-sling-testing-rules/pull/2#issuecomment-1324328375
I don't have any specific concerns with this solution. I'd just point out that this solution would be only for consumers who are still using junit4.
For those that have migrated to junit5, a [BeforeEachCallback](https://junit.org/junit5/docs/current/api/org.junit.jupiter.api/org/junit/jupiter/api/extension/BeforeEachCallback.html) extension would be needed instead of this new rule.
However, making a fork of the sling-org-apache-sling-testing-rules project that is compatible with junit5 is a larger problem and should probably be considered separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-rules] Kronnox commented on pull request #2: SLING-11679: Add rule for defining a custom user-agent
Posted by GitBox <gi...@apache.org>.
Kronnox commented on PR #2:
URL: https://github.com/apache/sling-org-apache-sling-testing-rules/pull/2#issuecomment-1325065432
> I don't have any specific concerns with this solution. I'd just point out that this solution would be only for consumers who are still using junit4.
>
> For those that have migrated to junit5, a [BeforeEachCallback](https://junit.org/junit5/docs/current/api/org.junit.jupiter.api/org/junit/jupiter/api/extension/BeforeEachCallback.html) extension would be needed instead of this new rule.
>
> However, making a fork of the sling-org-apache-sling-testing-rules project that is compatible with junit5 is a larger problem and should probably be considered separately.
As everything else is still based on junit4 as well I opted for consistency with this PR. So yeah, as you've already mentioned yourself the junit5 migration would be a larger topic on its own.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-rules] Kronnox commented on pull request #2: SLING-11733: Add rule for defining a custom user-agent
Posted by GitBox <gi...@apache.org>.
Kronnox commented on PR #2:
URL: https://github.com/apache/sling-org-apache-sling-testing-rules/pull/2#issuecomment-1354480380
> Do you think that any inline documentation is necessary/helpful?
@joerghoh I added additional javadoc comments where it made sense imo. Everything else (that isn't obvious anyways) should rather be in external documentation if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-rules] sonarcloud[bot] commented on pull request #2: SLING-11733: Add rule for defining a custom user-agent
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #2:
URL: https://github.com/apache/sling-org-apache-sling-testing-rules/pull/2#issuecomment-1354497755
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-rules&pullRequest=2)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-rules&pullRequest=2&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-rules&pullRequest=2&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-rules&pullRequest=2&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-rules&pullRequest=2&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-rules&pullRequest=2&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-rules&pullRequest=2&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-rules&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-rules&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-rules&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-rules&pullRequest=2&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-rules&pullRequest=2&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-rules&pullRequest=2&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-rules&pullRequest=2&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-rules&pullRequest=2&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-rules&pullRequest=2&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-rules&pullRequest=2&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-rules] sonarcloud[bot] commented on pull request #2: SLING-11679: Add rule for defining a custom user-agent
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #2:
URL: https://github.com/apache/sling-org-apache-sling-testing-rules/pull/2#issuecomment-1346827483
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-rules&pullRequest=2)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-rules&pullRequest=2&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-rules&pullRequest=2&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-rules&pullRequest=2&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-rules&pullRequest=2&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-rules&pullRequest=2&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-rules&pullRequest=2&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-rules&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-rules&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-rules&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-rules&pullRequest=2&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-rules&pullRequest=2&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-rules&pullRequest=2&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-rules&pullRequest=2&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-rules&pullRequest=2&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-rules&pullRequest=2&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-rules&pullRequest=2&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-rules] enapps-enorman commented on pull request #2: SLING-11679: Add rule for defining a custom user-agent
Posted by GitBox <gi...@apache.org>.
enapps-enorman commented on PR #2:
URL: https://github.com/apache/sling-org-apache-sling-testing-rules/pull/2#issuecomment-1332657972
> junit5 migration would be a larger topic on its own
FYI: I opened the SLING-11708 ticket for tracking junit5 compatibility separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-rules] joerghoh commented on pull request #2: SLING-11733: Add rule for defining a custom user-agent
Posted by GitBox <gi...@apache.org>.
joerghoh commented on PR #2:
URL: https://github.com/apache/sling-org-apache-sling-testing-rules/pull/2#issuecomment-1352679190
@Kronnox Do you think that any inline documentation is necessary/helpful?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-rules] Kronnox commented on pull request #2: SLING-11733: Add rule for defining a custom user-agent
Posted by GitBox <gi...@apache.org>.
Kronnox commented on PR #2:
URL: https://github.com/apache/sling-org-apache-sling-testing-rules/pull/2#issuecomment-1351092503
> please open a new Sling Jira issue, SLING-11679 is already used for the testing clients and is closed.
@rombert done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-rules] rombert commented on pull request #2: SLING-11733: Add rule for defining a custom user-agent
Posted by GitBox <gi...@apache.org>.
rombert commented on PR #2:
URL: https://github.com/apache/sling-org-apache-sling-testing-rules/pull/2#issuecomment-1354741646
Thanks for the contribution @Kronnox !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org