You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2019/05/31 14:18:14 UTC

[GitHub] [nifi-minifi-cpp] phrocker commented on a change in pull request #577: MINIFICPP-904: Switch to get_separator() in MiNiFi Main

phrocker commented on a change in pull request #577: MINIFICPP-904: Switch to get_separator() in MiNiFi Main
URL: https://github.com/apache/nifi-minifi-cpp/pull/577#discussion_r289408907
 
 

 ##########
 File path: main/Main.h
 ##########
 @@ -128,7 +123,7 @@ extern "C" {
 bool validHome(const std::string &home_path) {
   struct stat stat_result { };
   std::string sep;
-  sep += FILE_SEPARATOR;
+  sep += utils::file::FileUtils::get_separator();
 
 Review comment:
   I think the answer to why was that I didn't notice when I was extracting various commits across different branches and auto submitted the PRs via the CLI. Thanks!
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services