You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by GitBox <gi...@apache.org> on 2021/05/16 12:47:56 UTC

[GitHub] [bigtop] sekikn opened a new pull request #773: BIGTOP-3538. Building GPDB fails on Fedora 33.

sekikn opened a new pull request #773:
URL: https://github.com/apache/bigtop/pull/773


   This PR contains the following fixes so as to satisfy recent stricter compiler:
   
   * Backport https://github.com/greenplum-db/gpdb/pull/10663
   * Remove duplicate variable declarations
   
   Tested on all distros we support using an x86_64 machine.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bigtop] sekikn merged pull request #773: BIGTOP-3538. Building GPDB fails on Fedora 33.

Posted by GitBox <gi...@apache.org>.
sekikn merged pull request #773:
URL: https://github.com/apache/bigtop/pull/773


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bigtop] iwasakims commented on pull request #773: BIGTOP-3538. Building GPDB fails on Fedora 33.

Posted by GitBox <gi...@apache.org>.
iwasakims commented on pull request #773:
URL: https://github.com/apache/bigtop/pull/773#issuecomment-841966078


   ```
   /usr/bin/ld: cdb/SUBSYS.o:(.data+0x3bac): multiple definition of `gp_encoding_check_locale_compatibility'; utils/SUBSYS.o:(.bss+0x4915c): first defined here
   /usr/bin/ld: cdb/SUBSYS.o:(.bss+0x1207f): multiple definition of `Debug_resource_group'; utils/SUBSYS.o:(.bss+0x491dd): first defined here
   ```
   
   @sekikn The cause seems to be the default value change from `-fcommon` to `-fno-common`. I think just adding `-fcommon` to CFLAGS could be safer than modifying code on our own.
   
   ```
   $ git diff
   diff --git a/bigtop-packages/src/common/gpdb/do-component-configure b/bigtop-packages/src/common/gpdb/do-component-configure
   index dc362bb7..93b7b10d 100644
   --- a/bigtop-packages/src/common/gpdb/do-component-configure
   +++ b/bigtop-packages/src/common/gpdb/do-component-configure
   @@ -16,4 +16,4 @@
   
    set -ex
   
   -./configure --prefix=$1 --disable-orca
   +./configure --prefix=$1 --disable-orca CFLAGS=-fcommon
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bigtop] sekikn merged pull request #773: BIGTOP-3538. Building GPDB fails on Fedora 33.

Posted by GitBox <gi...@apache.org>.
sekikn merged pull request #773:
URL: https://github.com/apache/bigtop/pull/773


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bigtop] sekikn commented on pull request #773: BIGTOP-3538. Building GPDB fails on Fedora 33.

Posted by GitBox <gi...@apache.org>.
sekikn commented on pull request #773:
URL: https://github.com/apache/bigtop/pull/773#issuecomment-841982268


   @iwasakims Thanks! I confirmed your fix worked on all distros. Updated the PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bigtop] iwasakims commented on pull request #773: BIGTOP-3538. Building GPDB fails on Fedora 33.

Posted by GitBox <gi...@apache.org>.
iwasakims commented on pull request #773:
URL: https://github.com/apache/bigtop/pull/773#issuecomment-841966078


   ```
   /usr/bin/ld: cdb/SUBSYS.o:(.data+0x3bac): multiple definition of `gp_encoding_check_locale_compatibility'; utils/SUBSYS.o:(.bss+0x4915c): first defined here
   /usr/bin/ld: cdb/SUBSYS.o:(.bss+0x1207f): multiple definition of `Debug_resource_group'; utils/SUBSYS.o:(.bss+0x491dd): first defined here
   ```
   
   @sekikn The cause seems to be the default value change from `-fcommon` to `-fno-common`. I think just adding `-fcommon` to CFLAGS could be safer than modifying code on our own.
   
   ```
   $ git diff
   diff --git a/bigtop-packages/src/common/gpdb/do-component-configure b/bigtop-packages/src/common/gpdb/do-component-configure
   index dc362bb7..93b7b10d 100644
   --- a/bigtop-packages/src/common/gpdb/do-component-configure
   +++ b/bigtop-packages/src/common/gpdb/do-component-configure
   @@ -16,4 +16,4 @@
   
    set -ex
   
   -./configure --prefix=$1 --disable-orca
   +./configure --prefix=$1 --disable-orca CFLAGS=-fcommon
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bigtop] sekikn commented on pull request #773: BIGTOP-3538. Building GPDB fails on Fedora 33.

Posted by GitBox <gi...@apache.org>.
sekikn commented on pull request #773:
URL: https://github.com/apache/bigtop/pull/773#issuecomment-841982268


   @iwasakims Thanks! I confirmed your fix worked on all distros. Updated the PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org