You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ranger.apache.org by ni...@apache.org on 2022/09/09 16:51:02 UTC

[ranger] branch master updated: RANGER-3898:Bug in Ranger Roles Cache

This is an automated email from the ASF dual-hosted git repository.

nikhil pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ranger.git


The following commit(s) were added to refs/heads/master by this push:
     new df608eebe RANGER-3898:Bug in Ranger Roles Cache
df608eebe is described below

commit df608eebeea61447e4654708714f388a08ec65ae
Author: Ramachandran Krishnan <ra...@gmail.com>
AuthorDate: Thu Sep 8 14:14:32 2022 +0530

    RANGER-3898:Bug in Ranger Roles Cache
    
    Signed-off-by: Nikhil Purbhe <ni...@apache.org>
---
 .../src/main/java/org/apache/ranger/common/RangerRoleCache.java      | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/security-admin/src/main/java/org/apache/ranger/common/RangerRoleCache.java b/security-admin/src/main/java/org/apache/ranger/common/RangerRoleCache.java
index d71e97034..f44f0765d 100644
--- a/security-admin/src/main/java/org/apache/ranger/common/RangerRoleCache.java
+++ b/security-admin/src/main/java/org/apache/ranger/common/RangerRoleCache.java
@@ -69,10 +69,8 @@ public class RangerRoleCache {
 		if (lastKnownRoleVersion == null || !lastKnownRoleVersion.equals(rangerRoleVersionInDB)) {
 			roleCacheWrapper = new RangerRoleCacheWrapper();
 			ret              = roleCacheWrapper.getLatestRangerRoles(serviceName, roleDBStore, lastKnownRoleVersion, rangerRoleVersionInDB);
-		} else if (lastKnownRoleVersion.equals(rangerRoleVersionInDB)) {
-			ret = null;
 		} else {
-			ret = roleCacheWrapper.getRoles();
+			ret = null;
 		}
 
 		return ret;
@@ -121,6 +119,7 @@ public class RangerRoleCache {
 						ret.setRoleVersion(rolesVersionInDB);
 
 						rolesVersion = rolesVersionInDB;
+						roles = ret;
 					} else {
 						LOG.error("Could not get Ranger Roles from database ...");
 					}