[GitHub] [pinot] navina commented on a diff in pull request #9977: Emit consumer partition lag from the server

[GitBox <gi...@apache.org>]

navina commented on code in PR #9977:
URL: https://github.com/apache/pinot/pull/9977#discussion_r1046737088


##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java:
##########
@@ -617,6 +624,40 @@ private boolean processStreamEvents(MessageBatch messagesAndOffsets, long idlePi
     return prematureExit;
   }
 
+  private void updateConsumerLagMetrics() {
+    boolean emitRecordsLag = true;
+    boolean emitAvailabilityLag = true;
+    if (_caughtUpWithUpstream) {

Review Comment:
   This is to handle the catch up scenario. If the partition is still "catching up" to the upstream, this metric will spike, even though it is not indicative of any issue with consumption. Thus, we wanted to avoid the potential for false alerts with this metric. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org