You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/07/22 17:56:01 UTC

[GitHub] [superset] zamar-roura opened a new issue, #20832: [SIP-88] BigQuery Estimate Cost Button for SQL Lab

zamar-roura opened a new issue, #20832:
URL: https://github.com/apache/superset/issues/20832

   ## [SIP-88] BigQuery Estimate Cost Button SQL Lab
   
   ### Motivation
   
   There is currently no estimate cost button for Bigquery schemas. Before running a query it would be good to know how many bytes will be processed. In EUW 1TB = 5€ aprox.
   
   ### Proposed Change
   We need to add the three cost estimate methods to bigquery.py
   
   - 1)
   ![image](https://user-images.githubusercontent.com/12966153/180495891-c36604b3-b403-4334-bc06-af0a9532ab9b.png)
   - 2)
   ![image](https://user-images.githubusercontent.com/12966153/180495924-7f47d290-e69f-489c-a6a4-2d16be98c413.png)
   - 3)
   We need to execute a dryrun calling pybigquery api.
   ![image](https://user-images.githubusercontent.com/12966153/180495962-14d6f86d-31f0-4d0c-87b7-d508a27791db.png)
   
   ### New or Changed Public Interfaces
   
   Change:
   
   `estimate_statement_cost(cls, statement: str, cursor: Any)`
   
   to 
   
   `estimate_statement_cost(cls, statement: str, cursor: Any, database: Database)
   `
   
   This is needed because we need the credentials for the API. In postgres.py and presto.py this is done via query. In Bigquery it's not possible.
   
   ### New dependencies
   
   Not needed.
   
   ### Migration Plan and Compatibility
   
   Not needed.
   
   ### Rejected Alternatives
   
   None yet.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] zamar-roura commented on issue #20832: [SIP-88] BigQuery Estimate Cost Button for SQL Lab

Posted by GitBox <gi...@apache.org>.
zamar-roura commented on issue #20832:
URL: https://github.com/apache/superset/issues/20832#issuecomment-1192812117

   I have the code working, should I give a MR to develop? Thanks for reading ^^


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] [SIP-88] BigQuery Estimate Cost Button for SQL Lab [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed issue #20832: [SIP-88] BigQuery Estimate Cost Button for SQL Lab
URL: https://github.com/apache/superset/issues/20832


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] [SIP-88] BigQuery Estimate Cost Button for SQL Lab [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #20832:
URL: https://github.com/apache/superset/issues/20832#issuecomment-1745650765

   It seems the linked PR effectively closes and completes this SIP. Let me know if there's anything else left to be done here, and we can revisit this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] [SIP-88] BigQuery Estimate Cost Button for SQL Lab [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #20832:
URL: https://github.com/apache/superset/issues/20832#issuecomment-1745651894

   Noting for posterity that while the work was implemented, the SIP itself did not go through the discuss/vote process on the Apache mailing list.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org