You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2017/04/10 20:08:15 UTC
Review Request 58314: Removed `thread_local.hpp` from stout.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58314/
-----------------------------------------------------------
Review request for mesos and Anand Mazumdar.
Bugs: MESOS-7373
https://issues.apache.org/jira/browse/MESOS-7373
Repository: mesos
Description
-------
Removed `thread_local.hpp` from stout.
Diffs
-----
3rdparty/stout/include/Makefile.am abe3dcfbd73ffb4dbf9ffbd1b33a587fadf6264c
3rdparty/stout/include/stout/thread_local.hpp 7ffc809c720abe477fb92851d530ae49dcb23f49
Diff: https://reviews.apache.org/r/58314/diff/1/
Testing
-------
`make check`
Thanks,
Neil Conway
Re: Review Request 58314: Removed `thread_local.hpp` from stout.
Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58314/#review173829
-----------------------------------------------------------
Ship it!
Ship It!
- Anand Mazumdar
On May 3, 2017, 9:15 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58314/
> -----------------------------------------------------------
>
> (Updated May 3, 2017, 9:15 p.m.)
>
>
> Review request for mesos and Anand Mazumdar.
>
>
> Bugs: MESOS-7373
> https://issues.apache.org/jira/browse/MESOS-7373
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed `thread_local.hpp` from stout.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/Makefile.am 04273ee65388e09f365ed730aeac757638552473
> 3rdparty/stout/include/stout/thread_local.hpp 7ffc809c720abe477fb92851d530ae49dcb23f49
>
>
> Diff: https://reviews.apache.org/r/58314/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 58314: Removed `thread_local.hpp` from stout.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58314/
-----------------------------------------------------------
(Updated May 3, 2017, 9:15 p.m.)
Review request for mesos and Anand Mazumdar.
Changes
-------
Rebase.
Bugs: MESOS-7373
https://issues.apache.org/jira/browse/MESOS-7373
Repository: mesos
Description
-------
Removed `thread_local.hpp` from stout.
Diffs (updated)
-----
3rdparty/stout/include/Makefile.am 04273ee65388e09f365ed730aeac757638552473
3rdparty/stout/include/stout/thread_local.hpp 7ffc809c720abe477fb92851d530ae49dcb23f49
Diff: https://reviews.apache.org/r/58314/diff/2/
Changes: https://reviews.apache.org/r/58314/diff/1-2/
Testing
-------
`make check`
Thanks,
Neil Conway
Re: Review Request 58314: Removed `thread_local.hpp` from stout.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58314/#review171503
-----------------------------------------------------------
Patch looks great!
Reviews applied: [58310, 58311, 58312, 58313, 58314]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 10, 2017, 8:08 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58314/
> -----------------------------------------------------------
>
> (Updated April 10, 2017, 8:08 p.m.)
>
>
> Review request for mesos and Anand Mazumdar.
>
>
> Bugs: MESOS-7373
> https://issues.apache.org/jira/browse/MESOS-7373
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed `thread_local.hpp` from stout.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/Makefile.am abe3dcfbd73ffb4dbf9ffbd1b33a587fadf6264c
> 3rdparty/stout/include/stout/thread_local.hpp 7ffc809c720abe477fb92851d530ae49dcb23f49
>
>
> Diff: https://reviews.apache.org/r/58314/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>