You are viewing a plain text version of this content. The canonical link for it is here.
Posted to woden-dev@ws.apache.org by John Kaputin <KA...@uk.ibm.com> on 2007/07/09 18:42:37 UTC
Recent fix to DOMWSDLReader
Dims,
you made a small change to DOMWSDLReader.java last week (r554055) but a
diff shows that nearly every source code line has been changed, except for
a few lines in the boilerplate comments. Probably a white space problem.
Could you please reapply this fix with just the intended changes.
thanks,
John Kaputin
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number
741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
Re: Recent fix to DOMWSDLReader
Posted by Jeremy Hughes <hu...@apache.org>.
Hi Dims,
For some reason I had thought 'native' was the default but that's
probably because I haven't read enough. I just read the svn:eol-style
section again in the SVN book and it looks like default is just to
treat as bytes.
The cocoon config file looks good. I think we should use that - and
(of course) add in:
*.wsdl = svn:eol-style=native;svn:keywords=Id
Does anyone know if there's a way of applying the autoprops config to
a whole working copy so it doesn't have to be done manually?
We haven't used svn:keywords=Id before now. I'm OK with using and
applying it to every file that we apply svn:eol-style to ... as long
as we decide where to use $Id$ and apply that consistently ... not
necessarily all at the same time, but at least we should say what
we're aiming for. Personally I'm +0 for svn:keywords - I can see some
people might like to use it, but I've survived so far without it.
Another $Id$ issue to think about is that some files we have include
expanded out CVS style $Id$ (e.g. wsdl20.xsd). We'd need to figure out
what to do about these - remove expanded out CVS $Id$ or make it
clearer that the $Id$ is from the W3C CVS and not from our SVN
Thanks again Dims for pointing out our problem with svn:eol-style
Cheers,
Jeremy
On 10/07/07, Davanum Srinivas <da...@gmail.com> wrote:
> John,
>
> I think you have a bigger problem. A lot of the files don't have
> eol-style set to native. So this kind of problem will keep happening
> especially when we try to get more people on board. So let's tackle
> that problem first. Please see samples here on how to set the
> attribute.
>
> http://wiki.apache.org/cocoon/SVNConfig
>
> thanks,
> dims
>
> On 7/10/07, John Kaputin <KA...@uk.ibm.com> wrote:
> > Dims,
> > I had seen the actual change via viewvc diff, as per your link. However,
> > other tools like Subclipse just show the equivalent of the patch file at
> > this link, which shows all line changes, including the line ending
> > changes. If this revision is reverted and the fix re-applied, the source
> > history will be correctly viewable when using other subversion clients.
> >
> > thanks,
> > John Kaputin
> >
> >
> > "Davanum Srinivas" <da...@gmail.com> wrote on 09/07/2007 19:10:32:
> >
> > > John,
> > >
> > > It's a line endings problem..somehow i messed up. In the meantime,
> > > does this help?
> > >
> > > http://svn.apache.
> > >
> > org/viewvc/incubator/woden/trunk/java/src/org/apache/woden/internal/DOMWSDLReader.
> > > java?r1=521411&r2=554055&pathrev=554055&diff_format=h
> > >
> > > When you use the long colored diff combobox, you can see the real
> > change.
> > >
> > > thanks,
> > > dims
> > >
> > > On 7/9/07, John Kaputin <KA...@uk.ibm.com> wrote:
> > > > Dims,
> > > > you made a small change to DOMWSDLReader.java last week (r554055) but
> > a
> > > > diff shows that nearly every source code line has been changed, except
> > for
> > > > a few lines in the boilerplate comments. Probably a white space
> > problem.
> > > > Could you please reapply this fix with just the intended changes.
> > > >
> > > > thanks,
> > > > John Kaputin
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > > Unless stated otherwise above:
> > > > IBM United Kingdom Limited - Registered in England and Wales with
> > number
> > > > 741598.
> > > > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6
> > 3AU
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
> > > > For additional commands, e-mail: woden-dev-help@ws.apache.org
> > > >
> > > >
> > >
> > >
> > > --
> > > Davanum Srinivas :: http://davanum.wordpress.com
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
> > > For additional commands, e-mail: woden-dev-help@ws.apache.org
> > >
> >
> >
> >
> >
> >
> >
> > Unless stated otherwise above:
> > IBM United Kingdom Limited - Registered in England and Wales with number
> > 741598.
> > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
> >
> >
> >
> >
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
> > For additional commands, e-mail: woden-dev-help@ws.apache.org
> >
> >
>
>
> --
> Davanum Srinivas :: http://davanum.wordpress.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: woden-dev-help@ws.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
Re: Recent fix to DOMWSDLReader
Posted by Davanum Srinivas <da...@gmail.com>.
John,
I think you have a bigger problem. A lot of the files don't have
eol-style set to native. So this kind of problem will keep happening
especially when we try to get more people on board. So let's tackle
that problem first. Please see samples here on how to set the
attribute.
http://wiki.apache.org/cocoon/SVNConfig
thanks,
dims
On 7/10/07, John Kaputin <KA...@uk.ibm.com> wrote:
> Dims,
> I had seen the actual change via viewvc diff, as per your link. However,
> other tools like Subclipse just show the equivalent of the patch file at
> this link, which shows all line changes, including the line ending
> changes. If this revision is reverted and the fix re-applied, the source
> history will be correctly viewable when using other subversion clients.
>
> thanks,
> John Kaputin
>
>
> "Davanum Srinivas" <da...@gmail.com> wrote on 09/07/2007 19:10:32:
>
> > John,
> >
> > It's a line endings problem..somehow i messed up. In the meantime,
> > does this help?
> >
> > http://svn.apache.
> >
> org/viewvc/incubator/woden/trunk/java/src/org/apache/woden/internal/DOMWSDLReader.
> > java?r1=521411&r2=554055&pathrev=554055&diff_format=h
> >
> > When you use the long colored diff combobox, you can see the real
> change.
> >
> > thanks,
> > dims
> >
> > On 7/9/07, John Kaputin <KA...@uk.ibm.com> wrote:
> > > Dims,
> > > you made a small change to DOMWSDLReader.java last week (r554055) but
> a
> > > diff shows that nearly every source code line has been changed, except
> for
> > > a few lines in the boilerplate comments. Probably a white space
> problem.
> > > Could you please reapply this fix with just the intended changes.
> > >
> > > thanks,
> > > John Kaputin
> > >
> > >
> > >
> > >
> > >
> > >
> > > Unless stated otherwise above:
> > > IBM United Kingdom Limited - Registered in England and Wales with
> number
> > > 741598.
> > > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6
> 3AU
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
> > > For additional commands, e-mail: woden-dev-help@ws.apache.org
> > >
> > >
> >
> >
> > --
> > Davanum Srinivas :: http://davanum.wordpress.com
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
> > For additional commands, e-mail: woden-dev-help@ws.apache.org
> >
>
>
>
>
>
>
> Unless stated otherwise above:
> IBM United Kingdom Limited - Registered in England and Wales with number
> 741598.
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
>
>
>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: woden-dev-help@ws.apache.org
>
>
--
Davanum Srinivas :: http://davanum.wordpress.com
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
Re: Recent fix to DOMWSDLReader
Posted by John Kaputin <KA...@uk.ibm.com>.
Dims,
I had seen the actual change via viewvc diff, as per your link. However,
other tools like Subclipse just show the equivalent of the patch file at
this link, which shows all line changes, including the line ending
changes. If this revision is reverted and the fix re-applied, the source
history will be correctly viewable when using other subversion clients.
thanks,
John Kaputin
"Davanum Srinivas" <da...@gmail.com> wrote on 09/07/2007 19:10:32:
> John,
>
> It's a line endings problem..somehow i messed up. In the meantime,
> does this help?
>
> http://svn.apache.
>
org/viewvc/incubator/woden/trunk/java/src/org/apache/woden/internal/DOMWSDLReader.
> java?r1=521411&r2=554055&pathrev=554055&diff_format=h
>
> When you use the long colored diff combobox, you can see the real
change.
>
> thanks,
> dims
>
> On 7/9/07, John Kaputin <KA...@uk.ibm.com> wrote:
> > Dims,
> > you made a small change to DOMWSDLReader.java last week (r554055) but
a
> > diff shows that nearly every source code line has been changed, except
for
> > a few lines in the boilerplate comments. Probably a white space
problem.
> > Could you please reapply this fix with just the intended changes.
> >
> > thanks,
> > John Kaputin
> >
> >
> >
> >
> >
> >
> > Unless stated otherwise above:
> > IBM United Kingdom Limited - Registered in England and Wales with
number
> > 741598.
> > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6
3AU
> >
> >
> >
> >
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
> > For additional commands, e-mail: woden-dev-help@ws.apache.org
> >
> >
>
>
> --
> Davanum Srinivas :: http://davanum.wordpress.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: woden-dev-help@ws.apache.org
>
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number
741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
Re: Recent fix to DOMWSDLReader
Posted by Davanum Srinivas <da...@gmail.com>.
John,
It's a line endings problem..somehow i messed up. In the meantime,
does this help?
http://svn.apache.org/viewvc/incubator/woden/trunk/java/src/org/apache/woden/internal/DOMWSDLReader.java?r1=521411&r2=554055&pathrev=554055&diff_format=h
When you use the long colored diff combobox, you can see the real change.
thanks,
dims
On 7/9/07, John Kaputin <KA...@uk.ibm.com> wrote:
> Dims,
> you made a small change to DOMWSDLReader.java last week (r554055) but a
> diff shows that nearly every source code line has been changed, except for
> a few lines in the boilerplate comments. Probably a white space problem.
> Could you please reapply this fix with just the intended changes.
>
> thanks,
> John Kaputin
>
>
>
>
>
>
> Unless stated otherwise above:
> IBM United Kingdom Limited - Registered in England and Wales with number
> 741598.
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
>
>
>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: woden-dev-help@ws.apache.org
>
>
--
Davanum Srinivas :: http://davanum.wordpress.com
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org