You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/05 15:28:27 UTC
[GitHub] [pulsar] lordcheng10 opened a new pull request, #16408: [improve][broker] support dynamic configuration of the unload interval for shedding
lordcheng10 opened a new pull request, #16408:
URL: https://github.com/apache/pulsar/pull/16408
### Motivation
During the shedding process, support dynamic configuration of the unload interval.
The reasons are as follows：
1. During the load balancing process, two consecutive rounds of unload need a certain interval, otherwise the load information based on the balancing will be inaccurate;
2. Support dynamic configuration of unload interval;
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1204736938
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1214213912
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on a diff in pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on code in PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#discussion_r923344486
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java:
##########
@@ -1032,9 +1030,10 @@ protected void startLeaderElectionService() {
if (loadResourceQuotaTask != null) {
loadResourceQuotaTask.cancel(false);
}
- loadSheddingTask = loadManagerExecutor.scheduleAtFixedRate(
- new LoadSheddingTask(loadManager),
- loadSheddingInterval, loadSheddingInterval, TimeUnit.MILLISECONDS);
+ loadSheddingTask = loadManagerExecutor.schedule(
+ new LoadSheddingTask(loadManager, loadManagerExecutor, config),
+ TimeUnit.MINUTES.toMillis(config.getLoadBalancerSheddingIntervalMinutes()),
+ TimeUnit.MILLISECONDS);
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1187555889
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1186698218
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1210244363
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1210508982
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1188636352
@Jason918 PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1186533515
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1186698344
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1186694187
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jason918 commented on a diff in pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
Jason918 commented on code in PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#discussion_r924288593
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/LoadSheddingTask.java:
##########
@@ -39,6 +49,13 @@ public void run() {
loadManager.get().doLoadShedding();
} catch (Exception e) {
LOG.warn("Error during the load shedding", e);
+ } finally {
+ if (!loadManagerExecutor.isShutdown()) {
+ loadManagerExecutor.schedule(
+ new LoadSheddingTask(loadManager, loadManagerExecutor, config),
Review Comment:
Can we use `this` here?
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java:
##########
@@ -1032,9 +1030,10 @@ protected void startLeaderElectionService() {
if (loadResourceQuotaTask != null) {
loadResourceQuotaTask.cancel(false);
}
- loadSheddingTask = loadManagerExecutor.scheduleAtFixedRate(
- new LoadSheddingTask(loadManager),
- loadSheddingInterval, loadSheddingInterval, TimeUnit.MILLISECONDS);
+ loadSheddingTask = loadManagerExecutor.schedule(
Review Comment:
Previous `loadSheddingTask.cancel()` is called when this broker became follower from leader. `loadManagerExecutor` is only shutdown when broker stops.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1187096405
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1186725961
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1198914504
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1186510972
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1205949645
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1210201976
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [improve][broker] support dynamic configuration of the unload interval for shedding
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1178875512
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [improve][broker] support dynamic configuration of the unload interval for shedding
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1179970315
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1186695017
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1206086779
@Technoboy- PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1204665486
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1204736684
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
codelipenghui merged PR #16408:
URL: https://github.com/apache/pulsar/pull/16408
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1210123225
> Do we have a test for the loadBalancerSheddingIntervalMinutes dynamic support? If no, we need to add a test.
Fixed.PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1215052724
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1186551376
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on a diff in pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on code in PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#discussion_r923347161
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java:
##########
@@ -1032,9 +1030,10 @@ protected void startLeaderElectionService() {
if (loadResourceQuotaTask != null) {
loadResourceQuotaTask.cancel(false);
}
- loadSheddingTask = loadManagerExecutor.scheduleAtFixedRate(
- new LoadSheddingTask(loadManager),
- loadSheddingInterval, loadSheddingInterval, TimeUnit.MILLISECONDS);
+ loadSheddingTask = loadManagerExecutor.schedule(
Review Comment:
fixed! PTAL,thanks! @Jason918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1187023556
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1210717392
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1213643928
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1215052419
> Do we have a test for the loadBalancerSheddingIntervalMinutes dynamic support? If no, we need to add a test.
Fixed.PTAL,thanks! @codelipenghui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jason918 commented on a diff in pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
Jason918 commented on code in PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#discussion_r933784799
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/LoadSheddingTask.java:
##########
@@ -39,6 +51,24 @@ public void run() {
loadManager.get().doLoadShedding();
} catch (Exception e) {
LOG.warn("Error during the load shedding", e);
+ } finally {
+ if (!isCancel) {
+ loadManagerExecutor.schedule(
+ new LoadSheddingTask(loadManager, loadManagerExecutor, config),
+ config.getLoadBalancerSheddingIntervalMinutes(),
+ TimeUnit.MILLISECONDS);
Review Comment:
The time unit seems wrong.
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/LoadSheddingTask.java:
##########
@@ -39,6 +51,24 @@ public void run() {
loadManager.get().doLoadShedding();
} catch (Exception e) {
LOG.warn("Error during the load shedding", e);
+ } finally {
+ if (!isCancel) {
+ loadManagerExecutor.schedule(
+ new LoadSheddingTask(loadManager, loadManagerExecutor, config),
+ config.getLoadBalancerSheddingIntervalMinutes(),
+ TimeUnit.MILLISECONDS);
+ }
}
}
+
+ public void start() {
+ loadManagerExecutor.schedule(
+ new LoadSheddingTask(loadManager, loadManagerExecutor, config),
+ config.getLoadBalancerSheddingIntervalMinutes(),
+ TimeUnit.MILLISECONDS);
Review Comment:
Same here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on a diff in pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on code in PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#discussion_r935049132
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/LoadSheddingTask.java:
##########
@@ -39,6 +51,24 @@ public void run() {
loadManager.get().doLoadShedding();
} catch (Exception e) {
LOG.warn("Error during the load shedding", e);
+ } finally {
+ if (!isCancel) {
+ loadManagerExecutor.schedule(
+ new LoadSheddingTask(loadManager, loadManagerExecutor, config),
+ config.getLoadBalancerSheddingIntervalMinutes(),
+ TimeUnit.MILLISECONDS);
+ }
}
}
+
+ public void start() {
+ loadManagerExecutor.schedule(
+ new LoadSheddingTask(loadManager, loadManagerExecutor, config),
+ config.getLoadBalancerSheddingIntervalMinutes(),
+ TimeUnit.MILLISECONDS);
Review Comment:
fixed. PTAL,thanks! @Jason918
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/LoadSheddingTask.java:
##########
@@ -39,6 +51,24 @@ public void run() {
loadManager.get().doLoadShedding();
} catch (Exception e) {
LOG.warn("Error during the load shedding", e);
+ } finally {
+ if (!isCancel) {
+ loadManagerExecutor.schedule(
+ new LoadSheddingTask(loadManager, loadManagerExecutor, config),
+ config.getLoadBalancerSheddingIntervalMinutes(),
+ TimeUnit.MILLISECONDS);
Review Comment:
fixed. PTAL,thanks! @Jason918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1203400914
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1204736612
@aloyszhang PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1203812446
> LGTM, please resolve the test failure in `org.apache.pulsar.broker.loadbalance.SimpleLoadManagerImplTest`
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1204329459
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1213853659
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1188596058
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1186517205
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1186546116
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1187780985
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1186551477
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1206010736
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [improve][broker] support dynamic configuration of the unload interval for shedding
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1177222868
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [improve][broker] support dynamic configuration of the unload interval for shedding
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1178586224
@codelipenghui @eolivelli @Jason918 PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jason918 commented on a diff in pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
Jason918 commented on code in PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#discussion_r922939459
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java:
##########
@@ -1032,9 +1030,10 @@ protected void startLeaderElectionService() {
if (loadResourceQuotaTask != null) {
loadResourceQuotaTask.cancel(false);
}
- loadSheddingTask = loadManagerExecutor.scheduleAtFixedRate(
- new LoadSheddingTask(loadManager),
- loadSheddingInterval, loadSheddingInterval, TimeUnit.MILLISECONDS);
+ loadSheddingTask = loadManagerExecutor.schedule(
Review Comment:
It seems not right to cancel `loadSheddingTask` like this.
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/LoadSheddingTask.java:
##########
@@ -28,15 +31,25 @@
public class LoadSheddingTask implements Runnable {
private static final Logger LOG = LoggerFactory.getLogger(LoadSheddingTask.class);
private final AtomicReference<LoadManager> loadManager;
+ private final ScheduledExecutorService loadManagerExecutor;
- public LoadSheddingTask(AtomicReference<LoadManager> loadManager) {
+ private final ServiceConfiguration config;
+
+ public LoadSheddingTask(AtomicReference<LoadManager> loadManager,
+ ScheduledExecutorService loadManagerExecutor,
+ ServiceConfiguration config) {
this.loadManager = loadManager;
+ this.loadManagerExecutor = loadManagerExecutor;
+ this.config = config;
}
@Override
public void run() {
try {
loadManager.get().doLoadShedding();
+ loadManagerExecutor.schedule(new LoadSheddingTask(loadManager, loadManagerExecutor, config),
Review Comment:
This re-schedule better in finally?
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java:
##########
@@ -1032,9 +1030,10 @@ protected void startLeaderElectionService() {
if (loadResourceQuotaTask != null) {
loadResourceQuotaTask.cancel(false);
}
- loadSheddingTask = loadManagerExecutor.scheduleAtFixedRate(
- new LoadSheddingTask(loadManager),
- loadSheddingInterval, loadSheddingInterval, TimeUnit.MILLISECONDS);
+ loadSheddingTask = loadManagerExecutor.schedule(
+ new LoadSheddingTask(loadManager, loadManagerExecutor, config),
+ TimeUnit.MINUTES.toMillis(config.getLoadBalancerSheddingIntervalMinutes()),
+ TimeUnit.MILLISECONDS);
Review Comment:
Why not just use `TimeUnit.MINUTES`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [improve][broker] support dynamic configuration of the unload interval for shedding
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1178518063
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [improve][broker] support dynamic configuration of the unload interval for shedding
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1178849778
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1187002846
https://github.com/apache/pulsar/pull/16552
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on a diff in pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on code in PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#discussion_r923345415
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java:
##########
@@ -1032,9 +1030,10 @@ protected void startLeaderElectionService() {
if (loadResourceQuotaTask != null) {
loadResourceQuotaTask.cancel(false);
}
- loadSheddingTask = loadManagerExecutor.scheduleAtFixedRate(
- new LoadSheddingTask(loadManager),
- loadSheddingInterval, loadSheddingInterval, TimeUnit.MILLISECONDS);
+ loadSheddingTask = loadManagerExecutor.schedule(
Review Comment:
like this:
<img width="936" alt="image" src="https://user-images.githubusercontent.com/19296967/179516593-ea1925ae-852a-4f72-99fd-e0b821c578dd.png">
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java:
##########
@@ -1032,9 +1030,10 @@ protected void startLeaderElectionService() {
if (loadResourceQuotaTask != null) {
loadResourceQuotaTask.cancel(false);
}
- loadSheddingTask = loadManagerExecutor.scheduleAtFixedRate(
- new LoadSheddingTask(loadManager),
- loadSheddingInterval, loadSheddingInterval, TimeUnit.MILLISECONDS);
+ loadSheddingTask = loadManagerExecutor.schedule(
Review Comment:
fixed, like this:
<img width="936" alt="image" src="https://user-images.githubusercontent.com/19296967/179516593-ea1925ae-852a-4f72-99fd-e0b821c578dd.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [improve][broker] support dynamic configuration of the unload interval for shedding
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1176041478
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1206009927
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1200076847
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1204736800
@codelipenghui PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1213014503
> Do we have a test for the loadBalancerSheddingIntervalMinutes dynamic support? If no, we need to add a test.
@codelipenghui Fixed, PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1186549310
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1188636173
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1186497580
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1186513319
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1187031451
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on a diff in pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on code in PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#discussion_r923349343
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java:
##########
@@ -1032,9 +1030,10 @@ protected void startLeaderElectionService() {
if (loadResourceQuotaTask != null) {
loadResourceQuotaTask.cancel(false);
}
- loadSheddingTask = loadManagerExecutor.scheduleAtFixedRate(
- new LoadSheddingTask(loadManager),
- loadSheddingInterval, loadSheddingInterval, TimeUnit.MILLISECONDS);
+ loadSheddingTask = loadManagerExecutor.schedule(
+ new LoadSheddingTask(loadManager, loadManagerExecutor, config),
+ TimeUnit.MINUTES.toMillis(config.getLoadBalancerSheddingIntervalMinutes()),
+ TimeUnit.MILLISECONDS);
Review Comment:
fixed! PTAL,thanks! @Jason918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1187918558
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [improve][broker] support dynamic configuration of the unload interval for shedding
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1178585424
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [improve][broker] support dynamic configuration of the unload interval for shedding
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1179958037
> loadBalancerSheddingIntervalMinutes
@Jason918
loadBalancerSheddingIntervalMinutes cannot really be modified dynamically. It is used to initialize the cycle execution time. Once initialized, it cannot be changed：
<img width="1214" alt="image" src="https://user-images.githubusercontent.com/19296967/178189438-81e70d72-a60c-4a54-9f8f-89a12399043d.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [improve][broker] support dynamic configuration of the unload interval for shedding
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1179958107
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [improve][broker] support dynamic configuration of the unload interval for shedding
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1175786766
@eolivelli @hangc0276 @codelipenghui PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1204833597
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1211485614
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1211590588
> Do we have a test for the loadBalancerSheddingIntervalMinutes dynamic support? If no, we need to add a test.
@codelipenghui Fixed, PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1210245339
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1186522397
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on a diff in pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on code in PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#discussion_r923349143
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/LoadSheddingTask.java:
##########
@@ -28,15 +31,25 @@
public class LoadSheddingTask implements Runnable {
private static final Logger LOG = LoggerFactory.getLogger(LoadSheddingTask.class);
private final AtomicReference<LoadManager> loadManager;
+ private final ScheduledExecutorService loadManagerExecutor;
- public LoadSheddingTask(AtomicReference<LoadManager> loadManager) {
+ private final ServiceConfiguration config;
+
+ public LoadSheddingTask(AtomicReference<LoadManager> loadManager,
+ ScheduledExecutorService loadManagerExecutor,
+ ServiceConfiguration config) {
this.loadManager = loadManager;
+ this.loadManagerExecutor = loadManagerExecutor;
+ this.config = config;
}
@Override
public void run() {
try {
loadManager.get().doLoadShedding();
+ loadManagerExecutor.schedule(new LoadSheddingTask(loadManager, loadManagerExecutor, config),
Review Comment:
fixed! PTAL,thanks! @Jason918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1186695048
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1186694364
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1186698151
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1186457417
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1187561427
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1202010183
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [improve][broker] support dynamic configuration of the unload interval for shedding
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1175785201
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [improve][broker] support dynamic configuration of the unload interval for shedding
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1176909765
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1186497850
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1186497807
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1201982910
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on a diff in pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on code in PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#discussion_r932832121
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/LoadSheddingTask.java:
##########
@@ -39,6 +49,13 @@ public void run() {
loadManager.get().doLoadShedding();
} catch (Exception e) {
LOG.warn("Error during the load shedding", e);
+ } finally {
+ if (!loadManagerExecutor.isShutdown()) {
+ loadManagerExecutor.schedule(
+ new LoadSheddingTask(loadManager, loadManagerExecutor, config),
Review Comment:
fixed, PTAL,thanks! @Jason918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1187983993
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1188491037
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1188572853
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on a diff in pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on code in PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#discussion_r923344671
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/LoadSheddingTask.java:
##########
@@ -28,15 +31,25 @@
public class LoadSheddingTask implements Runnable {
private static final Logger LOG = LoggerFactory.getLogger(LoadSheddingTask.class);
private final AtomicReference<LoadManager> loadManager;
+ private final ScheduledExecutorService loadManagerExecutor;
- public LoadSheddingTask(AtomicReference<LoadManager> loadManager) {
+ private final ServiceConfiguration config;
+
+ public LoadSheddingTask(AtomicReference<LoadManager> loadManager,
+ ScheduledExecutorService loadManagerExecutor,
+ ServiceConfiguration config) {
this.loadManager = loadManager;
+ this.loadManagerExecutor = loadManagerExecutor;
+ this.config = config;
}
@Override
public void run() {
try {
loadManager.get().doLoadShedding();
+ loadManagerExecutor.schedule(new LoadSheddingTask(loadManager, loadManagerExecutor, config),
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1210123482
> Do we have a test for the loadBalancerSheddingIntervalMinutes dynamic support? If no, we need to add a test.
Fixed.PTAL,thanks! @codelipenghui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [improve][broker] support dynamic configuration of the unload interval for shedding
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1177572850
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1186798405
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1213013930
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#issuecomment-1218859314
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org