You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jmeter.apache.org by bu...@apache.org on 2013/06/05 19:57:32 UTC

[Bug 55064] New: wasted work in ReportTreeListener.isValidDragAction()

https://issues.apache.org/bugzilla/show_bug.cgi?id=55064

            Bug ID: 55064
           Summary: wasted work in ReportTreeListener.isValidDragAction()
           Product: JMeter
           Version: 2.9
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Main
          Assignee: issues@jmeter.apache.org
          Reporter: nistor1@illinois.edu

Created attachment 30399
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=30399&action=edit
patch

The problem appears in version 2.9 and in revision 1489981.  I
attached a one-line patch that fixes it.  This problem and the patch
are similar to the previously fixed Bug 55056.

In method "ReportTreeListener.isValidDragAction", the loop over "path"
should break immediately after "isValid" is set to "false".  All the
iterations after "isValid" is set to "false" do not perform any useful
work, at best they just set "isValid" again to "false".

Method "include" in class "ClassFilter" has a similar loop (over
"pkgs"), and this loop breaks immediately after "inc" is set to
"true", just like in the proposed patch.  Other methods (e.g.,
"Copy.keepOnlyAncestors", "JMeterThread.getSampleListeners",
"HTTPSamplerBase.getSendParameterValuesAsPostBody",
"LogFilter.incFile") also have similar loops with similar breaks, just
like in the proposed patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 55064] wasted work in ReportTreeListener.isValidDragAction()

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55064

Adrian Nistor <ni...@illinois.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |PatchAvailable
                 CC|                            |nistor1@illinois.edu

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 55064] Useless processing in ReportTreeListener.isValidDragAction()

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55064

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Thanks for patch, applied.

Date: Wed Jun  5 19:04:42 2013
New Revision: 1490008

URL: http://svn.apache.org/r1490008
Log:
Bug 55064 - Useless processing in ReportTreeListener.isValidDragAction()
Bugzilla Id: 55064

Modified:
   
jmeter/trunk/src/reports/org/apache/jmeter/report/gui/tree/ReportTreeListener.java
    jmeter/trunk/xdocs/changes.xml

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 55064] Useless processing in ReportTreeListener.isValidDragAction()

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55064

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 55064] Useless processing in ReportTreeListener.isValidDragAction()

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55064

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |p.mouawad@ubik-ingenierie.c
                   |                            |om
           Hardware|PC                          |All
            Summary|wasted work in              |Useless processing in
                   |ReportTreeListener.isValidD |ReportTreeListener.isValidD
                   |ragAction()                 |ragAction()
                 OS|Linux                       |All
           Severity|normal                      |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.