You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2017/07/12 00:15:49 UTC
Re: Review Request 60423: Renamed method `resources` to
`allocatedResources` in master::Role.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60423/#review180265
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On June 26, 2017, 9:24 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60423/
> -----------------------------------------------------------
>
> (Updated June 26, 2017, 9:24 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This method collects resources allocated to the particular role.
> It's more precise to rename it as such.
>
>
> Diffs
> -----
>
> src/master/http.cpp 4dd43fd7c3fb986f4eed78bce574b6d3af156b67
> src/master/master.hpp 9dd6a530c373516dc81bfd51ee6e95f25588148f
>
>
> Diff: https://reviews.apache.org/r/60423/diff/1/
>
>
> Testing
> -------
>
> no functional change
>
>
> Thanks,
>
> Jay Guo
>
>