[jira] [Commented] (THRIFT-4558) reserved Csharp keywords are not escaped in some cases

["Pierre Mignolet (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16441978#comment-16441978 ] 

Pierre Mignolet commented on THRIFT-4558:
-----------------------------------------

[~jensg] thanks for quick feedback. Do you think it could be possible to backport my fix into 0.9.3. ?

> reserved Csharp keywords are not escaped in some cases
> ------------------------------------------------------
>
>                 Key: THRIFT-4558
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4558
>             Project: Thrift
>          Issue Type: Bug
>          Components: C# - Compiler
>    Affects Versions: 0.9.3, 0.10.0, 0.11.0
>            Reporter: Pierre Mignolet
>            Assignee: Pierre Mignolet
>            Priority: Major
>             Fix For: 0.12.0
>
>
> {code:java}
> struct MeMessage {
>  1: optional string fixed
>  7: required string unchecked
> }{code}
> Here reserved fixed C# keyword is escaped via @ but unchecked is not escaped in C# code so code is just not compilable
> ----
> I had a look in t_csharp_generator.cc and keyword are present and method normalize_name should make the escape



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)