[GitHub] [spark] cloud-fan commented on a change in pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #34123:
URL: https://github.com/apache/spark/pull/34123#discussion_r717518316



##########
File path: core/src/main/java/org/apache/spark/SparkThrowable.java
##########
@@ -39,4 +39,7 @@
   // Portable error identifier across SQL engines
   // If null, error class or SQLSTATE is not set
   String getSqlState();
+
+  // True if this error is an internal error.
+  boolean isInternalError();

Review comment:
       java interface can have default implementation now. Shall we use `SparkThrowableHelper.isInternalError(errorClass)` as the default implementation?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org