You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "Patrick0308 (GitHub)" <gi...@apache.org> on 2019/12/29 17:50:46 UTC

[GitHub] [dubbo-go] Patrick0308 opened pull request #291: Ftr: Generic Implement

**What this PR does**:
Ftr: add Generic Implement

**Which issue(s) this PR fixes**
Fixes #290 

**Special notes for your reviewer**:

**Does this PR introduce a user-facing change?**:
```release-note

```

[ Full content available at: https://github.com/apache/dubbo-go/pull/291 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #291: Ftr: Generic Implement

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=h1) Report
> Merging [#291](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/382169c6d82d4eb97891d49046a7d9d75a34f8bd?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `73.58%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/291/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #291      +/-   ##
===========================================
- Coverage    66.56%   66.56%   -0.01%     
===========================================
  Files          112      113       +1     
  Lines         7175     7228      +53     
===========================================
+ Hits          4776     4811      +35     
- Misses        1935     1947      +12     
- Partials       464      470       +6
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [filter/impl/generic\_service\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvZ2VuZXJpY19zZXJ2aWNlX2ZpbHRlci5nbw==) | `73.58% <73.58%> (ø)` | |
| [config\_center/apollo/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9hcG9sbG8vaW1wbC5nbw==) | `84.41% <0%> (-2.6%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.49% <0%> (-2.16%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=footer). Last update [382169c...f96a30b](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/291 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #291: Ftr: Generic Implement

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`develop@1c5cca4`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `0%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/291/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##             develop     #291   +/-   ##
==========================================
  Coverage           ?   66.56%           
==========================================
  Files              ?      113           
  Lines              ?     7230           
  Branches           ?        0           
==========================================
  Hits               ?     4813           
  Misses             ?     1946           
  Partials           ?      471
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [filter/tps/tps\_limiter\_method\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-ZmlsdGVyL3Rwcy90cHNfbGltaXRlcl9tZXRob2Rfc2VydmljZS5nbw==) | `80% <ø> (ø)` | |
| [filter/tps/tps\_limit\_fix\_window\_strategy.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-ZmlsdGVyL3Rwcy90cHNfbGltaXRfZml4X3dpbmRvd19zdHJhdGVneS5nbw==) | `100% <ø> (ø)` | |
| [filter/tps/tps\_limit\_sliding\_window\_strategy.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-ZmlsdGVyL3Rwcy90cHNfbGltaXRfc2xpZGluZ193aW5kb3dfc3RyYXRlZ3kuZ28=) | `100% <ø> (ø)` | |
| [...r/tps/tps\_limit\_thread\_safe\_fix\_window\_strategy.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-ZmlsdGVyL3Rwcy90cHNfbGltaXRfdGhyZWFkX3NhZmVfZml4X3dpbmRvd19zdHJhdGVneS5nbw==) | `100% <ø> (ø)` | |
| [filter/filter/generic\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlci9nZW5lcmljX2ZpbHRlci5nbw==) | `67.69% <0%> (ø)` | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=footer). Last update [1c5cca4...bd7989a](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/291 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #291: Ftr: Generic Implement

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=h1) Report
> Merging [#291](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/382169c6d82d4eb97891d49046a7d9d75a34f8bd?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `73.58%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/291/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #291      +/-   ##
===========================================
+ Coverage    66.56%   66.58%   +0.02%     
===========================================
  Files          112      113       +1     
  Lines         7175     7228      +53     
===========================================
+ Hits          4776     4813      +37     
- Misses        1935     1946      +11     
- Partials       464      469       +5
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [filter/impl/generic\_service\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvZ2VuZXJpY19zZXJ2aWNlX2ZpbHRlci5nbw==) | `73.58% <73.58%> (ø)` | |
| [config\_center/apollo/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9hcG9sbG8vaW1wbC5nbw==) | `84.41% <0%> (-2.6%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=footer). Last update [382169c...a7a7926](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/291 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on pull request #291: Ftr: Generic Implement

Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
package name is not good.

[ Full content available at: https://github.com/apache/dubbo-go/pull/291 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on pull request #291: Ftr: Generic Implement

Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
split it.

[ Full content available at: https://github.com/apache/dubbo-go/pull/291 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #291: Ftr: Generic Implement

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=h1) Report
> Merging [#291](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/382169c6d82d4eb97891d49046a7d9d75a34f8bd?src=pr&el=desc) will **decrease** coverage by `0.67%`.
> The diff coverage is `70.17%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/291/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #291      +/-   ##
===========================================
- Coverage    66.56%   65.88%   -0.68%     
===========================================
  Files          112      113       +1     
  Lines         7175     7232      +57     
===========================================
- Hits          4776     4765      -11     
- Misses        1935     2000      +65     
- Partials       464      467       +3
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [filter/impl/generic\_service\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvZ2VuZXJpY19zZXJ2aWNlX2ZpbHRlci5nbw==) | `70.17% <70.17%> (ø)` | |
| [protocol/dubbo/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcG9vbC5nbw==) | `59.51% <0%> (-15.13%)` | :arrow_down: |
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `51.19% <0%> (-10.72%)` | :arrow_down: |
| [protocol/dubbo/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY29kZWMuZ28=) | `76.47% <0%> (-5.89%)` | :arrow_down: |
| [protocol/dubbo/readwriter.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcmVhZHdyaXRlci5nbw==) | `67.9% <0%> (-2.47%)` | :arrow_down: |
| [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `50.5% <0%> (-1.02%)` | :arrow_down: |
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `64.45% <0%> (+0.57%)` | :arrow_up: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `47.93% <0%> (+1.03%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=footer). Last update [382169c...527f21e](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/291 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] pantianying commented on pull request #291: Ftr: Generic Implement

Posted by "pantianying (GitHub)" <gi...@apache.org>.
👌

[ Full content available at: https://github.com/apache/dubbo-go/pull/291 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #291: Ftr: Generic Implement

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=h1) Report
> Merging [#291](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/c6f6377ebca2e67b10fd8d9f4589370254fbcd0c?src=pr&el=desc) will **increase** coverage by `0.76%`.
> The diff coverage is `70.17%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/291/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #291      +/-   ##
===========================================
+ Coverage    65.81%   66.58%   +0.76%     
===========================================
  Files          112      113       +1     
  Lines         7173     7230      +57     
===========================================
+ Hits          4721     4814      +93     
+ Misses        1991     1945      -46     
- Partials       461      471      +10
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [filter/impl/hystrix\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvaHlzdHJpeF9maWx0ZXIuZ28=) | `68.64% <ø> (ø)` | :arrow_up: |
| [filter/impl/active\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvYWN0aXZlX2ZpbHRlci5nbw==) | `18.18% <ø> (ø)` | :arrow_up: |
| [filter/impl/tps\_limit\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvdHBzX2xpbWl0X2ZpbHRlci5nbw==) | `88.23% <ø> (ø)` | :arrow_up: |
| [filter/impl/token\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvdG9rZW5fZmlsdGVyLmdv) | `87.5% <ø> (ø)` | :arrow_up: |
| [...impl/tps/impl/tps\_limit\_sliding\_window\_strategy.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvdHBzL2ltcGwvdHBzX2xpbWl0X3NsaWRpbmdfd2luZG93X3N0cmF0ZWd5Lmdv) | `100% <ø> (ø)` | :arrow_up: |
| [.../impl/tps\_limit\_thread\_safe\_fix\_window\_strategy.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvdHBzL2ltcGwvdHBzX2xpbWl0X3RocmVhZF9zYWZlX2ZpeF93aW5kb3dfc3RyYXRlZ3kuZ28=) | `100% <ø> (ø)` | :arrow_up: |
| [filter/impl/tps/impl/tps\_limit\_strategy\_mock.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvdHBzL2ltcGwvdHBzX2xpbWl0X3N0cmF0ZWd5X21vY2suZ28=) | `100% <ø> (ø)` | :arrow_up: |
| [filter/impl/graceful\_shutdown\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvZ3JhY2VmdWxfc2h1dGRvd25fZmlsdGVyLmdv) | `80.64% <ø> (ø)` | :arrow_up: |
| [filter/impl/generic\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvZ2VuZXJpY19maWx0ZXIuZ28=) | `67.69% <ø> (ø)` | :arrow_up: |
| [filter/impl/echo\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvZWNob19maWx0ZXIuZ28=) | `85.71% <ø> (ø)` | :arrow_up: |
| ... and [13 more](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=footer). Last update [c6f6377...8eaeb96](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/291 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] fangyincheng commented on issue #291: Ftr: Generic Implement

Posted by "fangyincheng (GitHub)" <gi...@apache.org>.
Has it been tested with java Dubbo？

[ Full content available at: https://github.com/apache/dubbo-go/pull/291 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on issue #291: Ftr: Generic Implement

Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
> @AlexStocks Do you think I should capitalize the first letter of methodName for generic invoke because the first letter of go's methodName should be upper.

pls give some adives @fangyincheng @hxmhlt @pantianying 

[ Full content available at: https://github.com/apache/dubbo-go/pull/291 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #291: Ftr: Generic Implement

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=h1) Report
> Merging [#291](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/382169c6d82d4eb97891d49046a7d9d75a34f8bd?src=pr&el=desc) will **increase** coverage by `0.05%`.
> The diff coverage is `73.58%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/291/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #291      +/-   ##
===========================================
+ Coverage    66.56%   66.61%   +0.05%     
===========================================
  Files          112      113       +1     
  Lines         7175     7228      +53     
===========================================
+ Hits          4776     4815      +39     
- Misses        1935     1944       +9     
- Partials       464      469       +5
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [filter/impl/generic\_service\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvZ2VuZXJpY19zZXJ2aWNlX2ZpbHRlci5nbw==) | `73.58% <73.58%> (ø)` | |
| [config\_center/apollo/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9hcG9sbG8vaW1wbC5nbw==) | `84.41% <0%> (-2.6%)` | :arrow_down: |
| [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `50.5% <0%> (-1.02%)` | :arrow_down: |
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `64.45% <0%> (+0.57%)` | :arrow_up: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `47.93% <0%> (+1.03%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=footer). Last update [382169c...af31400](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/291 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #291: Ftr: Generic Implement

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=h1) Report
> Merging [#291](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/c6f6377ebca2e67b10fd8d9f4589370254fbcd0c?src=pr&el=desc) will **increase** coverage by `0.76%`.
> The diff coverage is `70.17%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/291/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #291      +/-   ##
===========================================
+ Coverage    65.81%   66.58%   +0.76%     
===========================================
  Files          112      113       +1     
  Lines         7173     7230      +57     
===========================================
+ Hits          4721     4814      +93     
+ Misses        1991     1945      -46     
- Partials       461      471      +10
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [filter/impl/hystrix\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvaHlzdHJpeF9maWx0ZXIuZ28=) | `68.64% <ø> (ø)` | :arrow_up: |
| [filter/impl/active\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvYWN0aXZlX2ZpbHRlci5nbw==) | `18.18% <ø> (ø)` | :arrow_up: |
| [filter/impl/tps\_limit\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvdHBzX2xpbWl0X2ZpbHRlci5nbw==) | `88.23% <ø> (ø)` | :arrow_up: |
| [filter/impl/token\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvdG9rZW5fZmlsdGVyLmdv) | `87.5% <ø> (ø)` | :arrow_up: |
| [...impl/tps/impl/tps\_limit\_sliding\_window\_strategy.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvdHBzL2ltcGwvdHBzX2xpbWl0X3NsaWRpbmdfd2luZG93X3N0cmF0ZWd5Lmdv) | `100% <ø> (ø)` | :arrow_up: |
| [.../impl/tps\_limit\_thread\_safe\_fix\_window\_strategy.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvdHBzL2ltcGwvdHBzX2xpbWl0X3RocmVhZF9zYWZlX2ZpeF93aW5kb3dfc3RyYXRlZ3kuZ28=) | `100% <ø> (ø)` | :arrow_up: |
| [filter/impl/tps/impl/tps\_limit\_strategy\_mock.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvdHBzL2ltcGwvdHBzX2xpbWl0X3N0cmF0ZWd5X21vY2suZ28=) | `100% <ø> (ø)` | :arrow_up: |
| [filter/impl/graceful\_shutdown\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvZ3JhY2VmdWxfc2h1dGRvd25fZmlsdGVyLmdv) | `80.64% <ø> (ø)` | :arrow_up: |
| [filter/impl/generic\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvZ2VuZXJpY19maWx0ZXIuZ28=) | `67.69% <ø> (ø)` | :arrow_up: |
| [filter/impl/echo\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvZWNob19maWx0ZXIuZ28=) | `85.71% <ø> (ø)` | :arrow_up: |
| ... and [13 more](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=footer). Last update [c6f6377...1c5cca4](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/291 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] Patrick0308 commented on issue #291: Ftr: Generic Implement

Posted by "Patrick0308 (GitHub)" <gi...@apache.org>.
@fangyincheng In java sdk, generic filter is default filter. In go, do we need to control it be working?

[ Full content available at: https://github.com/apache/dubbo-go/pull/291 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on pull request #291: Ftr: Generic Implement

Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
okay. use impl as usual.

[ Full content available at: https://github.com/apache/dubbo-go/pull/291 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #291: Ftr: Generic Implement

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=h1) Report
> Merging [#291](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/382169c6d82d4eb97891d49046a7d9d75a34f8bd?src=pr&el=desc) will **decrease** coverage by `0.67%`.
> The diff coverage is `70.17%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/291/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #291      +/-   ##
===========================================
- Coverage    66.56%   65.88%   -0.68%     
===========================================
  Files          112      113       +1     
  Lines         7175     7232      +57     
===========================================
- Hits          4776     4765      -11     
- Misses        1935     2000      +65     
- Partials       464      467       +3
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [filter/impl/generic\_service\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvZ2VuZXJpY19zZXJ2aWNlX2ZpbHRlci5nbw==) | `70.17% <70.17%> (ø)` | |
| [protocol/dubbo/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcG9vbC5nbw==) | `59.51% <0%> (-15.13%)` | :arrow_down: |
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `51.19% <0%> (-10.72%)` | :arrow_down: |
| [protocol/dubbo/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY29kZWMuZ28=) | `76.47% <0%> (-5.89%)` | :arrow_down: |
| [protocol/dubbo/readwriter.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcmVhZHdyaXRlci5nbw==) | `67.9% <0%> (-2.47%)` | :arrow_down: |
| [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `50.5% <0%> (-1.02%)` | :arrow_down: |
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `64.45% <0%> (+0.57%)` | :arrow_up: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `47.93% <0%> (+1.03%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=footer). Last update [382169c...4854646](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/291 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] fangyincheng closed pull request #291: Ftr: Generic Implement

Posted by "fangyincheng (GitHub)" <gi...@apache.org>.
[ pull request closed by fangyincheng ]

[ Full content available at: https://github.com/apache/dubbo-go/pull/291 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] Patrick0308 commented on issue #291: Ftr: Generic Implement

Posted by "Patrick0308 (GitHub)" <gi...@apache.org>.
@AlexStocks Do you think I should capitalize the first letter of methodName for generic invoke because the first letter of go's methodName should be upper.

[ Full content available at: https://github.com/apache/dubbo-go/pull/291 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #291: Ftr: Generic Implement

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=h1) Report
> Merging [#291](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/382169c6d82d4eb97891d49046a7d9d75a34f8bd?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `73.58%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/291/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #291      +/-   ##
===========================================
+ Coverage    66.56%   66.58%   +0.02%     
===========================================
  Files          112      113       +1     
  Lines         7175     7228      +53     
===========================================
+ Hits          4776     4813      +37     
- Misses        1935     1946      +11     
- Partials       464      469       +5
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [filter/impl/generic\_service\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvZ2VuZXJpY19zZXJ2aWNlX2ZpbHRlci5nbw==) | `73.58% <73.58%> (ø)` | |
| [config\_center/apollo/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9hcG9sbG8vaW1wbC5nbw==) | `84.41% <0%> (-2.6%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=footer). Last update [382169c...527f21e](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/291 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] pantianying commented on pull request #291: Ftr: Generic Implement

Posted by "pantianying (GitHub)" <gi...@apache.org>.
It is better to declare the length of these arrays

[ Full content available at: https://github.com/apache/dubbo-go/pull/291 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #291: Ftr: Generic Implement

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=h1) Report
> Merging [#291](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/382169c6d82d4eb97891d49046a7d9d75a34f8bd?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `73.58%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/291/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #291      +/-   ##
===========================================
+ Coverage    66.56%   66.58%   +0.02%     
===========================================
  Files          112      113       +1     
  Lines         7175     7228      +53     
===========================================
+ Hits          4776     4813      +37     
- Misses        1935     1946      +11     
- Partials       464      469       +5
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [filter/impl/generic\_service\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvZ2VuZXJpY19zZXJ2aWNlX2ZpbHRlci5nbw==) | `73.58% <73.58%> (ø)` | |
| [config\_center/apollo/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9hcG9sbG8vaW1wbC5nbw==) | `84.41% <0%> (-2.6%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=footer). Last update [382169c...b786517](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/291 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] Patrick0308 commented on issue #291: Ftr: Generic Implement

Posted by "Patrick0308 (GitHub)" <gi...@apache.org>.
> > @AlexStocks Do you think I should capitalize the first letter of methodName for generic invoke because the first letter of go's methodName should be upper.
> 
> dubbo-go support lowercase method to provide a service.
> 
> ![image](https://user-images.githubusercontent.com/18375310/71643284-a9298600-2cf2-11ea-8a9e-675b8bbbe474.png)

I see.

[ Full content available at: https://github.com/apache/dubbo-go/pull/291 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #291: Ftr: Generic Implement

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=h1) Report
> Merging [#291](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/1c5cca4474ce75419c4c93db5ffa9a1bb1fb8377?src=pr&el=desc) will **increase** coverage by `0.76%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/291/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #291      +/-   ##
===========================================
+ Coverage    65.81%   66.58%   +0.76%     
===========================================
  Files          112      113       +1     
  Lines         7173     7230      +57     
===========================================
+ Hits          4721     4814      +93     
+ Misses        1991     1945      -46     
- Partials       461      471      +10
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [filter/impl/hystrix\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvaHlzdHJpeF9maWx0ZXIuZ28=) | `68.64% <ø> (ø)` | :arrow_up: |
| [filter/impl/active\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvYWN0aXZlX2ZpbHRlci5nbw==) | `18.18% <ø> (ø)` | :arrow_up: |
| [filter/impl/tps\_limit\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvdHBzX2xpbWl0X2ZpbHRlci5nbw==) | `88.23% <ø> (ø)` | :arrow_up: |
| [filter/impl/token\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvdG9rZW5fZmlsdGVyLmdv) | `87.5% <ø> (ø)` | :arrow_up: |
| [...impl/tps/impl/tps\_limit\_sliding\_window\_strategy.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvdHBzL2ltcGwvdHBzX2xpbWl0X3NsaWRpbmdfd2luZG93X3N0cmF0ZWd5Lmdv) | `100% <ø> (ø)` | :arrow_up: |
| [.../impl/tps\_limit\_thread\_safe\_fix\_window\_strategy.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvdHBzL2ltcGwvdHBzX2xpbWl0X3RocmVhZF9zYWZlX2ZpeF93aW5kb3dfc3RyYXRlZ3kuZ28=) | `100% <ø> (ø)` | :arrow_up: |
| [filter/impl/tps/impl/tps\_limit\_strategy\_mock.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvdHBzL2ltcGwvdHBzX2xpbWl0X3N0cmF0ZWd5X21vY2suZ28=) | `100% <ø> (ø)` | :arrow_up: |
| [filter/impl/generic\_service\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvZ2VuZXJpY19zZXJ2aWNlX2ZpbHRlci5nbw==) | `70.17% <ø> (ø)` | |
| [filter/impl/graceful\_shutdown\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvZ3JhY2VmdWxfc2h1dGRvd25fZmlsdGVyLmdv) | `80.64% <ø> (ø)` | :arrow_up: |
| [filter/impl/generic\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvZ2VuZXJpY19maWx0ZXIuZ28=) | `67.69% <ø> (ø)` | :arrow_up: |
| ... and [13 more](https://codecov.io/gh/apache/dubbo-go/pull/291/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=footer). Last update [1c5cca4...bd7989a](https://codecov.io/gh/apache/dubbo-go/pull/291?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/291 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] pantianying commented on pull request #291: Ftr: Generic Implement

Posted by "pantianying (GitHub)" <gi...@apache.org>.
The type assertion here is not safe and will cause the program to crash

[ Full content available at: https://github.com/apache/dubbo-go/pull/291 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] fangyincheng commented on issue #291: Ftr: Generic Implement

Posted by "fangyincheng (GitHub)" <gi...@apache.org>.
you need a switch to control whether `generic_service` should be working, instead of default

[ Full content available at: https://github.com/apache/dubbo-go/pull/291 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org