You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "mason-gordon (via GitHub)" <gi...@apache.org> on 2026/05/18 19:50:34 UTC
[I] Select All in a dashboard filter incorrectly displays how many values it is selecting if there are null values [superset]
mason-gordon opened a new issue, #40228:
URL: https://github.com/apache/superset/issues/40228
## Screenshot
<img width="486" height="398" alt="Image" src="https://github.com/user-attachments/assets/f187fb90-7f29-4427-b986-fb8d0b7911cd" />
[drag & drop image(s) here!]
<img width="545" height="438" alt="Image" src="https://github.com/user-attachments/assets/c15e958b-3435-44b7-b602-7e8b18ad1ce3" />
## Description
**Version:** Superset 6.0.0
When selecting values for a dashboard filter, "Select All" does not actually select *every* displayed value if `<NULL>` is one of the options. In the screenshots above, you can see that it says **Select All (3)**. When I click on that option, only the 2 "real" values were actually selected. The **Deselect All (2)** option displays the correct amount of values to deselect.
## Design input
I would imagine it's intentional that Select All doesn't select `NULL` values. I wasn't sure if this was a bug or just an oversight, but if Select All shouldn't select `NULL` values, then I think Select All should not include it in the total number of options to select. This isn't too challenging to work around on our end, since we can just coalesce the null values into some other placeholder. It is misleading, though, and may affect the experience of dashboard users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Select All in a dashboard filter incorrectly displays how many values it is selecting if there are null values [superset]
Posted by "mason-gordon (via GitHub)" <gi...@apache.org>.
mason-gordon commented on issue #40228:
URL: https://github.com/apache/superset/issues/40228#issuecomment-4501147530
@sadpandajoe this is incorrect
> Select all is 3 because there are 3 total items in the list so if you select that you would be selecting all 3 items
The second screenshot is the result of clicking "Select All" - only two items were selected, not 3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Select All in a dashboard filter incorrectly displays how many values it is selecting if there are null values [superset]
Posted by "dosubot[bot] (via GitHub)" <gi...@apache.org>.
dosubot[bot] commented on issue #40228:
URL: https://github.com/apache/superset/issues/40228#issuecomment-4481478876
<!-- Greeting -->
Hi @mason-gordon! I'm [Dosu](https://go.dosu.dev/dosubot) and Iām helping the superset team.
<!-- Answer -->
This looks like a legitimate bug. The issue is a mismatch between how `bulkSelectCounts.selectable` is calculated versus how `handleSelectAll` actually selects items.
**The count** (`bulkSelectCounts.selectable`) iterates over `visibleOptions` and counts any option that is not disabled (or is already selected) and is not a new unsaved option ā it does **not** exclude null/falsy values [[1]](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/packages/superset-ui-core/src/components/Select/Select.tsx#L241-L264).
**The selection** (`handleSelectAll`) filters with `option.value &&`, which excludes null/falsy values from actually being selected [[2]](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/packages/superset-ui-core/src/components/Select/Select.tsx#L419).
So `<NULL>` gets counted in the display number but is skipped during actual selection ā exactly the behavior you're seeing.
A fix would be to align the two by adding the same falsy-value check to the `bulkSelectCounts` computation, e.g.:
```typescript
if (
option.value && // ā add this to match handleSelectAll
(!isDisabled || isSelected) &&
((isNew && isSelected) || !isNew)
) {
acc.selectable += 1;
}
```
This is in [`superset-frontend/packages/superset-ui-core/src/components/Select/Select.tsx`](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/packages/superset-ui-core/src/components/Select/Select.tsx).
<!-- Dosu Comment Footer -->
*To reply, just mention [@dosu](https://go.dosu.dev/dosubot?utm_source=github&utm_medium=bot-comment&utm_campaign=github-comment-footer-20260415&utm_content=reply-with-mention&utm_term=apache%2Fsuperset).*
---
Share context across your team and agents. Try [Dosu](https://dosu.dev?utm_source=github&utm_medium=bot-comment&utm_campaign=github-comment-footer-20260415&utm_content=knowledge-infrastructure-tagline&utm_term=apache%2Fsuperset).
[](https://app.dosu.dev/response-feedback?utm_source=github&utm_medium=bot-comment&utm_campaign=github-comment-footer-20260415&utm_content=knowledge-infrastructure-feedback&utm_term=apache%2Fsuperset&message_id=08ea5f0c-f2e3-45f6-908c-ae7381dfa530) [](https://github.dosu.com/apache/superset?utm_source=github&utm_medium=bot-comment&utm_campaign=github-comment-footer-20260415&utm_content=knowledge-infrastructure-learn-repo&utm_term=apache%2Fsuperset) [](https://app.dosu.dev/signup?referrer=openSource&source=github-footer&utm_source=github&utm_medium=bot-comment&utm_campaign=github-comment-footer-20260415&utm_content=knowledge-infrastructure-add-team&utm_term=apache%2Fsuperset)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Select All in a dashboard filter incorrectly displays how many values it is selecting if there are null values [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on issue #40228:
URL: https://github.com/apache/superset/issues/40228#issuecomment-4501109822
@mason-gordon this looks like correct functionality to me unless if i'm seeing it wrong.
First screenshot:
- 3 options in the dropdown helper text looks right as you have 3 options
- Select all text is right as you would be selecting all 3 options
- Deselect all is correct as you have not selected any options
Second screenshot:
- Tier 1 and Tier 2 have been selected, so you see a 2 in the helper field
- Select all is 3 because there are 3 total items in the list so if you select that you would be selecting all 3 items
- Deselect is correct since you have 2 items selected already, so if you click that it will unselect tier 1 and tier 2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Select All in a dashboard filter incorrectly displays how many values it is selecting if there are null values [superset]
Posted by "AoLiGei1221 (via GitHub)" <gi...@apache.org>.
AoLiGei1221 commented on issue #40228:
URL: https://github.com/apache/superset/issues/40228#issuecomment-4483151442
Hi Community! I am willing to help with this issue. Please assign to me. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Select All in a dashboard filter incorrectly displays how many values it is selecting if there are null values [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed issue #40228: Select All in a dashboard filter incorrectly displays how many values it is selecting if there are null values
URL: https://github.com/apache/superset/issues/40228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org