[GitHub] [airflow] potiuk commented on a change in pull request #17397: Update to Celery 5

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #17397:
URL: https://github.com/apache/airflow/pull/17397#discussion_r684608167



##########
File path: Dockerfile.ci
##########
@@ -278,7 +278,7 @@ ENV AIRFLOW_REPO=${AIRFLOW_REPO}\
 # * lazy-object-proxy<1.5.0: required by astroid
 # * pyjwt<2.0.0: flask-jwt-extended requires it
 # * dill<0.3.3 required by apache-beam
-ARG EAGER_UPGRADE_ADDITIONAL_REQUIREMENTS="lazy-object-proxy<1.5.0 pyjwt<2.0.0 dill<0.3.3 certifi<2021.0.0"
+ARG EAGER_UPGRADE_ADDITIONAL_REQUIREMENTS="lazy-object-proxy<1.5.0 pyjwt<2.0.0 dill<0.3.3 certifi<2021.0.0 botocore>=1.20.107,<1.21.0"

Review comment:
       Generally speaking here i think only upper bounds should be stated and only when this requirement is one of the transitive dependencies of 'airflow' package - so if you want to upper-bounds limit botocore in one of the  extras, AND setup.cfg install-requires already add botocore as transitive dependency, then you need to add the upper-bound limit here for botocore. You should never need to have lower-bound limit here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org