You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by "Seetharam Venkatesh (JIRA)" <ji...@apache.org> on 2012/08/16 20:23:38 UTC
[jira] [Created] (SQOOP-580) Add Open-ended "teardown" routine that
is called after the job execution for cleanup
Seetharam Venkatesh created SQOOP-580:
-----------------------------------------
Summary: Add Open-ended "teardown" routine that is called after the job execution for cleanup
Key: SQOOP-580
URL: https://issues.apache.org/jira/browse/SQOOP-580
Project: Sqoop
Issue Type: Improvement
Components: connectors
Affects Versions: 1.4.1-incubating
Reporter: Seetharam Venkatesh
Priority: Minor
org.apache.sqoop.mapreduce.ImportJobBase.runImport -
There is a jobSetup that is called after the job is configured but just before it is submitted to MapReduce. I'm adding a jobTeardown method in the finally block.
I think the same applies to org.apache.sqoop.mapreduce.ExportJobBase.runExport. But the setup isnt called there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SQOOP-580) Add Open-ended "teardown" routine
that is called after the job execution for cleanup
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438502#comment-13438502 ]
Hudson commented on SQOOP-580:
------------------------------
Integrated in Sqoop-ant-jdk-1.6-hadoop20 #12 (See [https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop20/12/])
SQOOP-580. Add Open-ended "teardown" routine that is called after the job execution for cleanup.
(Seetharam Venkatesh via Jarek Jarcec Cecho) (Revision 1375399)
Result = SUCCESS
jarcec :
Files :
* /sqoop/trunk/src/java/org/apache/sqoop/mapreduce/ExportJobBase.java
* /sqoop/trunk/src/java/org/apache/sqoop/mapreduce/ImportJobBase.java
> Add Open-ended "teardown" routine that is called after the job execution for cleanup
> ------------------------------------------------------------------------------------
>
> Key: SQOOP-580
> URL: https://issues.apache.org/jira/browse/SQOOP-580
> Project: Sqoop
> Issue Type: Improvement
> Components: connectors
> Affects Versions: 1.4.1-incubating
> Reporter: Seetharam Venkatesh
> Assignee: Seetharam Venkatesh
> Priority: Minor
> Fix For: 1.4.3
>
> Attachments: SQOOP-580.patch
>
>
> org.apache.sqoop.mapreduce.ImportJobBase.runImport -
> There is a jobSetup that is called after the job is configured but just before it is submitted to MapReduce. I'm adding a jobTeardown method in the finally block.
> I think the same applies to org.apache.sqoop.mapreduce.ExportJobBase.runExport. But the setup isnt called there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (SQOOP-580) Add Open-ended "teardown" routine
that is called after the job execution for cleanup
Posted by "Seetharam Venkatesh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Seetharam Venkatesh reassigned SQOOP-580:
-----------------------------------------
Assignee: Seetharam Venkatesh
> Add Open-ended "teardown" routine that is called after the job execution for cleanup
> ------------------------------------------------------------------------------------
>
> Key: SQOOP-580
> URL: https://issues.apache.org/jira/browse/SQOOP-580
> Project: Sqoop
> Issue Type: Improvement
> Components: connectors
> Affects Versions: 1.4.1-incubating
> Reporter: Seetharam Venkatesh
> Assignee: Seetharam Venkatesh
> Priority: Minor
> Attachments: SQOOP-580.patch
>
>
> org.apache.sqoop.mapreduce.ImportJobBase.runImport -
> There is a jobSetup that is called after the job is configured but just before it is submitted to MapReduce. I'm adding a jobTeardown method in the finally block.
> I think the same applies to org.apache.sqoop.mapreduce.ExportJobBase.runExport. But the setup isnt called there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SQOOP-580) Add Open-ended "teardown" routine
that is called after the job execution for cleanup
Posted by "Seetharam Venkatesh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438114#comment-13438114 ]
Seetharam Venkatesh commented on SQOOP-580:
-------------------------------------------
bq. Moving those methods to JobBase make sense to me as it seems as unnecessary code repetition.
I thought of this as well but if you look at the exceptions, they are different.
ImportJobBase throws ImportException while ExportJobBase throws ExportException apart from IOException. I could very well wrap these into IOException but there is an implementation in org.apache.sqoop.mapreduce.HBaseImportJob that uses the specific ImportException and wanted to leave it in there.
Makes sense?
Any thoughts on eliminating repetition are welcome.
> Add Open-ended "teardown" routine that is called after the job execution for cleanup
> ------------------------------------------------------------------------------------
>
> Key: SQOOP-580
> URL: https://issues.apache.org/jira/browse/SQOOP-580
> Project: Sqoop
> Issue Type: Improvement
> Components: connectors
> Affects Versions: 1.4.1-incubating
> Reporter: Seetharam Venkatesh
> Assignee: Seetharam Venkatesh
> Priority: Minor
> Attachments: SQOOP-580.patch
>
>
> org.apache.sqoop.mapreduce.ImportJobBase.runImport -
> There is a jobSetup that is called after the job is configured but just before it is submitted to MapReduce. I'm adding a jobTeardown method in the finally block.
> I think the same applies to org.apache.sqoop.mapreduce.ExportJobBase.runExport. But the setup isnt called there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SQOOP-580) Add Open-ended "teardown" routine
that is called after the job execution for cleanup
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438514#comment-13438514 ]
Hudson commented on SQOOP-580:
------------------------------
Integrated in Sqoop-ant-jdk-1.6-hadoop100 #12 (See [https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop100/12/])
SQOOP-580. Add Open-ended "teardown" routine that is called after the job execution for cleanup.
(Seetharam Venkatesh via Jarek Jarcec Cecho) (Revision 1375399)
Result = SUCCESS
jarcec :
Files :
* /sqoop/trunk/src/java/org/apache/sqoop/mapreduce/ExportJobBase.java
* /sqoop/trunk/src/java/org/apache/sqoop/mapreduce/ImportJobBase.java
> Add Open-ended "teardown" routine that is called after the job execution for cleanup
> ------------------------------------------------------------------------------------
>
> Key: SQOOP-580
> URL: https://issues.apache.org/jira/browse/SQOOP-580
> Project: Sqoop
> Issue Type: Improvement
> Components: connectors
> Affects Versions: 1.4.1-incubating
> Reporter: Seetharam Venkatesh
> Assignee: Seetharam Venkatesh
> Priority: Minor
> Fix For: 1.4.3
>
> Attachments: SQOOP-580.patch
>
>
> org.apache.sqoop.mapreduce.ImportJobBase.runImport -
> There is a jobSetup that is called after the job is configured but just before it is submitted to MapReduce. I'm adding a jobTeardown method in the finally block.
> I think the same applies to org.apache.sqoop.mapreduce.ExportJobBase.runExport. But the setup isnt called there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SQOOP-580) Add Open-ended "teardown" routine
that is called after the job execution for cleanup
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438511#comment-13438511 ]
Hudson commented on SQOOP-580:
------------------------------
Integrated in Sqoop-ant-jdk-1.6-hadoop23 #142 (See [https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop23/142/])
SQOOP-580. Add Open-ended "teardown" routine that is called after the job execution for cleanup.
(Seetharam Venkatesh via Jarek Jarcec Cecho) (Revision 1375399)
Result = SUCCESS
jarcec :
Files :
* /sqoop/trunk/src/java/org/apache/sqoop/mapreduce/ExportJobBase.java
* /sqoop/trunk/src/java/org/apache/sqoop/mapreduce/ImportJobBase.java
> Add Open-ended "teardown" routine that is called after the job execution for cleanup
> ------------------------------------------------------------------------------------
>
> Key: SQOOP-580
> URL: https://issues.apache.org/jira/browse/SQOOP-580
> Project: Sqoop
> Issue Type: Improvement
> Components: connectors
> Affects Versions: 1.4.1-incubating
> Reporter: Seetharam Venkatesh
> Assignee: Seetharam Venkatesh
> Priority: Minor
> Fix For: 1.4.3
>
> Attachments: SQOOP-580.patch
>
>
> org.apache.sqoop.mapreduce.ImportJobBase.runImport -
> There is a jobSetup that is called after the job is configured but just before it is submitted to MapReduce. I'm adding a jobTeardown method in the finally block.
> I think the same applies to org.apache.sqoop.mapreduce.ExportJobBase.runExport. But the setup isnt called there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SQOOP-580) Add Open-ended "teardown" routine that
is called after the job execution for cleanup
Posted by "Seetharam Venkatesh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Seetharam Venkatesh updated SQOOP-580:
--------------------------------------
Attachment: SQOOP-580.patch
> Add Open-ended "teardown" routine that is called after the job execution for cleanup
> ------------------------------------------------------------------------------------
>
> Key: SQOOP-580
> URL: https://issues.apache.org/jira/browse/SQOOP-580
> Project: Sqoop
> Issue Type: Improvement
> Components: connectors
> Affects Versions: 1.4.1-incubating
> Reporter: Seetharam Venkatesh
> Assignee: Seetharam Venkatesh
> Priority: Minor
> Attachments: SQOOP-580.patch
>
>
> org.apache.sqoop.mapreduce.ImportJobBase.runImport -
> There is a jobSetup that is called after the job is configured but just before it is submitted to MapReduce. I'm adding a jobTeardown method in the finally block.
> I think the same applies to org.apache.sqoop.mapreduce.ExportJobBase.runExport. But the setup isnt called there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SQOOP-580) Add Open-ended "teardown" routine
that is called after the job execution for cleanup
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438506#comment-13438506 ]
Hudson commented on SQOOP-580:
------------------------------
Integrated in Sqoop-ant-jdk-1.6-hadoop200 #3 (See [https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop200/3/])
SQOOP-580. Add Open-ended "teardown" routine that is called after the job execution for cleanup.
(Seetharam Venkatesh via Jarek Jarcec Cecho) (Revision 1375399)
Result = SUCCESS
jarcec :
Files :
* /sqoop/trunk/src/java/org/apache/sqoop/mapreduce/ExportJobBase.java
* /sqoop/trunk/src/java/org/apache/sqoop/mapreduce/ImportJobBase.java
> Add Open-ended "teardown" routine that is called after the job execution for cleanup
> ------------------------------------------------------------------------------------
>
> Key: SQOOP-580
> URL: https://issues.apache.org/jira/browse/SQOOP-580
> Project: Sqoop
> Issue Type: Improvement
> Components: connectors
> Affects Versions: 1.4.1-incubating
> Reporter: Seetharam Venkatesh
> Assignee: Seetharam Venkatesh
> Priority: Minor
> Fix For: 1.4.3
>
> Attachments: SQOOP-580.patch
>
>
> org.apache.sqoop.mapreduce.ImportJobBase.runImport -
> There is a jobSetup that is called after the job is configured but just before it is submitted to MapReduce. I'm adding a jobTeardown method in the finally block.
> I think the same applies to org.apache.sqoop.mapreduce.ExportJobBase.runExport. But the setup isnt called there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SQOOP-580) Add Open-ended "teardown" routine
that is called after the job execution for cleanup
Posted by "Abhijeet Gaikwad (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13437481#comment-13437481 ]
Abhijeet Gaikwad commented on SQOOP-580:
----------------------------------------
Can we move these methods up in JobBase Class. Let me know.
Thanks.
> Add Open-ended "teardown" routine that is called after the job execution for cleanup
> ------------------------------------------------------------------------------------
>
> Key: SQOOP-580
> URL: https://issues.apache.org/jira/browse/SQOOP-580
> Project: Sqoop
> Issue Type: Improvement
> Components: connectors
> Affects Versions: 1.4.1-incubating
> Reporter: Seetharam Venkatesh
> Assignee: Seetharam Venkatesh
> Priority: Minor
> Attachments: SQOOP-580.patch
>
>
> org.apache.sqoop.mapreduce.ImportJobBase.runImport -
> There is a jobSetup that is called after the job is configured but just before it is submitted to MapReduce. I'm adding a jobTeardown method in the finally block.
> I think the same applies to org.apache.sqoop.mapreduce.ExportJobBase.runExport. But the setup isnt called there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SQOOP-580) Add Open-ended "teardown" routine
that is called after the job execution for cleanup
Posted by "Jarek Jarcec Cecho (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13437687#comment-13437687 ]
Jarek Jarcec Cecho commented on SQOOP-580:
------------------------------------------
Moving those methods to JobBase make sense to me as it seems as unnecessary code repetition.
Jarcec
> Add Open-ended "teardown" routine that is called after the job execution for cleanup
> ------------------------------------------------------------------------------------
>
> Key: SQOOP-580
> URL: https://issues.apache.org/jira/browse/SQOOP-580
> Project: Sqoop
> Issue Type: Improvement
> Components: connectors
> Affects Versions: 1.4.1-incubating
> Reporter: Seetharam Venkatesh
> Assignee: Seetharam Venkatesh
> Priority: Minor
> Attachments: SQOOP-580.patch
>
>
> org.apache.sqoop.mapreduce.ImportJobBase.runImport -
> There is a jobSetup that is called after the job is configured but just before it is submitted to MapReduce. I'm adding a jobTeardown method in the finally block.
> I think the same applies to org.apache.sqoop.mapreduce.ExportJobBase.runExport. But the setup isnt called there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SQOOP-580) Add Open-ended "teardown" routine
that is called after the job execution for cleanup
Posted by "Jarek Jarcec Cecho (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438495#comment-13438495 ]
Jarek Jarcec Cecho commented on SQOOP-580:
------------------------------------------
I see, I've missed different exceptions. Let's keep it as it for now. It's pretty simple patch, so I'm skipping review board and giving my +1 here.
Jarcec
> Add Open-ended "teardown" routine that is called after the job execution for cleanup
> ------------------------------------------------------------------------------------
>
> Key: SQOOP-580
> URL: https://issues.apache.org/jira/browse/SQOOP-580
> Project: Sqoop
> Issue Type: Improvement
> Components: connectors
> Affects Versions: 1.4.1-incubating
> Reporter: Seetharam Venkatesh
> Assignee: Seetharam Venkatesh
> Priority: Minor
> Attachments: SQOOP-580.patch
>
>
> org.apache.sqoop.mapreduce.ImportJobBase.runImport -
> There is a jobSetup that is called after the job is configured but just before it is submitted to MapReduce. I'm adding a jobTeardown method in the finally block.
> I think the same applies to org.apache.sqoop.mapreduce.ExportJobBase.runExport. But the setup isnt called there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira