You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by kumarvishal09 <gi...@git.apache.org> on 2018/02/02 12:25:10 UTC
[GitHub] carbondata pull request #1912: [WIP]Fixed is null filter issue
GitHub user kumarvishal09 opened a pull request:
https://github.com/apache/carbondata/pull/1912
[WIP]Fixed is null filter issue
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kumarvishal09/incubator-carbondata FixedIsNullIssue
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1912.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1912
----
commit 02cc511bf83abd1a8a3b48344c6e9ac32cb77eae
Author: kumarvishal <ku...@...>
Date: 2018-02-02T12:23:57Z
Fixed is null filter issue
----
---
[GitHub] carbondata pull request #1912: [CARBONDATA-2120]Fixed is null filter issue
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1912
---
[GitHub] carbondata issue #1912: [CARBONDATA-2120]Fixed is null filter issue
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1912
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3329/
---
[GitHub] carbondata issue #1912: [CARBONDATA-2120]Fixed is null filter issue
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1912
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2208/
---
[GitHub] carbondata pull request #1912: [CARBONDATA-2120]Fixed is null filter issue
Posted by scwf <gi...@git.apache.org>.
Github user scwf commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1912#discussion_r165809798
--- Diff: core/src/main/java/org/apache/carbondata/core/util/path/CarbonTablePath.java ---
@@ -75,7 +75,7 @@ public CarbonTablePath(CarbonTableIdentifier carbonTableIdentifier, String table
* @param carbonFilePath
*/
public static String getFolderContainingFile(String carbonFilePath) {
- return carbonFilePath.substring(0, carbonFilePath.lastIndexOf(File.separator));
+ return carbonFilePath.substring(0, carbonFilePath.lastIndexOf('/'));
--- End diff --
why this change?
---
[GitHub] carbondata issue #1912: [CARBONDATA-2120]Fixed is null filter issue
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1912
LGTM
---
[GitHub] carbondata issue #1912: [CARBONDATA-2120]Fixed is null filter issue
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/1912
retest sdv please
---
[GitHub] carbondata issue #1912: [CARBONDATA-2120]Fixed is null filter issue
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1912
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3313/
---
[GitHub] carbondata issue #1912: [CARBONDATA-2120]Fixed is null filter issue
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1912
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3449/
---