You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/10/13 01:30:20 UTC

[jira] [Commented] (CB-12005) Orientation wrong, Exif not changing after the correct orientation is applied

    [ https://issues.apache.org/jira/browse/CB-12005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15570480#comment-15570480 ] 

ASF GitHub Bot commented on CB-12005:
-------------------------------------

GitHub user opbokel opened a pull request:

    https://github.com/apache/cordova-plugin-camera/pull/239

    CB-12005: (android) Fix picture orientation from camera

    ### Platforms affected
    Android (tested on 6.0.1)
    
    ### What does this PR do?
    Resets the Exif orientation of the picture taken by the camera if it was successfully rotated 
    
    ### What testing has been done on this change?
    It was a very small change, I tested in two devices, also tested using the gallery.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/opbokel/cordova-plugin-camera master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-camera/pull/239.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #239
    
----
commit d04d11d30437ed9c9043a58163d539e75b6ae1d2
Author: opbokel <do...@gmail.com>
Date:   2016-10-12T04:07:30Z

    Fix orientation Bug on Android
    
    When getting the picture from camera and asking to correct orientation, the android devices I tested was returning the picture in the right orientation, but keeping the old exif orientation info. This made the picture to be incorrect rotated on devices that respected the exif (tested IOS).

commit c974490dd08a491bba6fc7f600313abbe2a78e3f
Author: opbokel <do...@gmail.com>
Date:   2016-10-12T04:20:50Z

    Fix typo

----


> Orientation wrong, Exif not changing after the correct orientation is applied
> -----------------------------------------------------------------------------
>
>                 Key: CB-12005
>                 URL: https://issues.apache.org/jira/browse/CB-12005
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Camera
>    Affects Versions: 2.3.0
>         Environment: Android 6.0.1
>            Reporter: Octavio Pinho Bokel
>              Labels: camera
>             Fix For: Master
>
>
> I recently updated the camera plugin to 2.3.0.
> My app (Woopter) use the camera plugin with FILE_URI and correctOrientation = true and the source is the CAMERA
> I noticed that the pictures were showing correctly only on android. On IOS and on the server they were WRONGLY ROTATED.
> What happened is that the picture is keeping the ORIGINAL EXIF after the orientation was corrected. So, in systems that uses the Exif, the picture was being rotated twice. (The Exif is making the correct oriented picture to rotated).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org