You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2015/05/21 11:18:27 UTC
svn commit: r1680775 -
/tomcat/trunk/java/org/apache/coyote/http2/StreamProcessor.java
Author: markt
Date: Thu May 21 09:18:26 2015
New Revision: 1680775
URL: http://svn.apache.org/r1680775
Log:
Mark a couple of TODOs as unimplemented.
Modified:
tomcat/trunk/java/org/apache/coyote/http2/StreamProcessor.java
Modified: tomcat/trunk/java/org/apache/coyote/http2/StreamProcessor.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http2/StreamProcessor.java?rev=1680775&r1=1680774&r2=1680775&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/coyote/http2/StreamProcessor.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http2/StreamProcessor.java Thu May 21 09:18:26 2015
@@ -63,20 +63,6 @@ public class StreamProcessor extends Abs
@Override
- public SocketState process(SocketWrapperBase<?> socket) throws IOException {
- // TODO Auto-generated method stub
- return null;
- }
-
-
- @Override
- public SocketState dispatch(SocketStatus status) {
- // TODO Auto-generated method stub
- return null;
- }
-
-
- @Override
public void action(ActionCode actionCode, Object param) {
switch (actionCode) {
case REQ_HOST_ADDR_ATTRIBUTE: {
@@ -112,16 +98,20 @@ public class StreamProcessor extends Abs
@Override
- public void recycle() {
+ public void setSslSupport(SSLSupport sslSupport) {
// TODO Auto-generated method stub
}
@Override
- public void setSslSupport(SSLSupport sslSupport) {
- // TODO Auto-generated method stub
-
+ public void recycle() {
+ // StreamProcessor instances are not re-used.
+ // Clear fields that can be cleared to aid GC and trigger NPEs if this
+ // is reused
+ setSocketWrapper(null);
+ setAdapter(null);
+ setClientCertProvider(null);
}
@@ -137,6 +127,20 @@ public class StreamProcessor extends Abs
}
+ @Override
+ public SocketState process(SocketWrapperBase<?> socket) throws IOException {
+ // Should never happen
+ throw new IllegalStateException(sm.getString("streamProcessor.httpupgrade.notsupported"));
+ }
+
+
+ @Override
+ public SocketState dispatch(SocketStatus status) {
+ // Should never happen
+ throw new IllegalStateException(sm.getString("streamProcessor.httpupgrade.notsupported"));
+ }
+
+
@Override
public HttpUpgradeHandler getHttpUpgradeHandler() {
// Should never happen
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org