You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/03/13 08:33:47 UTC
[GitHub] [hadoop-ozone] bshashikant opened a new pull request #671:
HDDS-3086. Failure running integration test it-freon.
bshashikant opened a new pull request #671: HDDS-3086. Failure running integration test it-freon.
URL: https://github.com/apache/hadoop-ozone/pull/671
## What changes were proposed in this pull request?
Added configs for rpc and watch timeouts for ratis clent and server.
Also, added a method to wait for atleast one ratis pipeline to get into open state before client IO starts.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3086
## How was this patch tested?
Ran he unit tests and verified.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] bshashikant commented on a change in pull request
#671: HDDS-3086. Failure running integration test it-freon.
Posted by GitBox <gi...@apache.org>.
bshashikant commented on a change in pull request #671: HDDS-3086. Failure running integration test it-freon.
URL: https://github.com/apache/hadoop-ozone/pull/671#discussion_r392150148
##########
File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/freon/TestDataValidate.java
##########
@@ -33,9 +38,28 @@
private static MiniOzoneCluster cluster = null;
static void startCluster(OzoneConfiguration conf) throws Exception {
+ conf.setTimeDuration(
+ RatisHelper.HDDS_DATANODE_RATIS_SERVER_PREFIX_KEY + "." +
+ DatanodeRatisServerConfig.RATIS_SERVER_REQUEST_TIMEOUT_KEY,
+ 3, TimeUnit.SECONDS);
+ conf.setTimeDuration(
+ RatisHelper.HDDS_DATANODE_RATIS_SERVER_PREFIX_KEY + "." +
+ DatanodeRatisServerConfig.
+ RATIS_SERVER_WATCH_REQUEST_TIMEOUT_KEY,
+ 10, TimeUnit.SECONDS);
+ conf.setTimeDuration(
+ RatisHelper.HDDS_DATANODE_RATIS_CLIENT_PREFIX_KEY+ "." +
+ "rpc.request.timeout",
+ 3, TimeUnit.SECONDS);
+ conf.setTimeDuration(
+ RatisHelper.HDDS_DATANODE_RATIS_CLIENT_PREFIX_KEY+ "." +
+ "watch.request.timeout",
+ 10, TimeUnit.SECONDS);
Review comment:
yes, i think we can do that..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] bshashikant commented on a change in pull request
#671: HDDS-3086. Failure running integration test it-freon.
Posted by GitBox <gi...@apache.org>.
bshashikant commented on a change in pull request #671: HDDS-3086. Failure running integration test it-freon.
URL: https://github.com/apache/hadoop-ozone/pull/671#discussion_r392150148
##########
File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/freon/TestDataValidate.java
##########
@@ -33,9 +38,28 @@
private static MiniOzoneCluster cluster = null;
static void startCluster(OzoneConfiguration conf) throws Exception {
+ conf.setTimeDuration(
+ RatisHelper.HDDS_DATANODE_RATIS_SERVER_PREFIX_KEY + "." +
+ DatanodeRatisServerConfig.RATIS_SERVER_REQUEST_TIMEOUT_KEY,
+ 3, TimeUnit.SECONDS);
+ conf.setTimeDuration(
+ RatisHelper.HDDS_DATANODE_RATIS_SERVER_PREFIX_KEY + "." +
+ DatanodeRatisServerConfig.
+ RATIS_SERVER_WATCH_REQUEST_TIMEOUT_KEY,
+ 10, TimeUnit.SECONDS);
+ conf.setTimeDuration(
+ RatisHelper.HDDS_DATANODE_RATIS_CLIENT_PREFIX_KEY+ "." +
+ "rpc.request.timeout",
+ 3, TimeUnit.SECONDS);
+ conf.setTimeDuration(
+ RatisHelper.HDDS_DATANODE_RATIS_CLIENT_PREFIX_KEY+ "." +
+ "watch.request.timeout",
+ 10, TimeUnit.SECONDS);
Review comment:
yes, i think we can do that..But we need to ensure all other tests work with this config
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai merged pull request #671: HDDS-3086.
Failure running integration test it-freon.
Posted by GitBox <gi...@apache.org>.
adoroszlai merged pull request #671: HDDS-3086. Failure running integration test it-freon.
URL: https://github.com/apache/hadoop-ozone/pull/671
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on issue #671: HDDS-3086.
Failure running integration test it-freon.
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on issue #671: HDDS-3086. Failure running integration test it-freon.
URL: https://github.com/apache/hadoop-ozone/pull/671#issuecomment-599486690
Thanks @bshashikant for the update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request
#671: HDDS-3086. Failure running integration test it-freon.
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #671: HDDS-3086. Failure running integration test it-freon.
URL: https://github.com/apache/hadoop-ozone/pull/671#discussion_r392123166
##########
File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/freon/TestDataValidate.java
##########
@@ -33,9 +38,28 @@
private static MiniOzoneCluster cluster = null;
static void startCluster(OzoneConfiguration conf) throws Exception {
+ conf.setTimeDuration(
+ RatisHelper.HDDS_DATANODE_RATIS_SERVER_PREFIX_KEY + "." +
+ DatanodeRatisServerConfig.RATIS_SERVER_REQUEST_TIMEOUT_KEY,
+ 3, TimeUnit.SECONDS);
+ conf.setTimeDuration(
+ RatisHelper.HDDS_DATANODE_RATIS_SERVER_PREFIX_KEY + "." +
+ DatanodeRatisServerConfig.
+ RATIS_SERVER_WATCH_REQUEST_TIMEOUT_KEY,
+ 10, TimeUnit.SECONDS);
+ conf.setTimeDuration(
+ RatisHelper.HDDS_DATANODE_RATIS_CLIENT_PREFIX_KEY+ "." +
+ "rpc.request.timeout",
+ 3, TimeUnit.SECONDS);
+ conf.setTimeDuration(
+ RatisHelper.HDDS_DATANODE_RATIS_CLIENT_PREFIX_KEY+ "." +
+ "watch.request.timeout",
+ 10, TimeUnit.SECONDS);
Review comment:
Can we make these configs to be the default, somewhere around `MiniOzoneCluster`? Eg. let `Builder.build()` add them if they are not explicitly set. I hope that would let us avoid repeating them for all integration tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org