Re: cvs commit: httpd-2.0/modules/generators mod_cgi.c mod_cgi.h

[Cliff Woolley <cl...@yahoo.com>]

On 24 Nov 2001 rbb@apache.org wrote:

> rbb         01/11/23 16:17:01
>
>   Modified:    .        CHANGES
>                modules/arch/win32 mod_win32.c
>                modules/generators mod_cgi.c mod_cgi.h
>   Log:
>   Fix the cmd command for mod_include.  When we are processing
>   a cmd command, we do not want to use the r->filename to set
>   the command name.  The command comes from the SSI tag.  To do this,
>   I added a variable to the function that builds the command line
>   in mod_cgi.  This allows the include_cmd function to specify
>   the command line itself.
>
>   PR:	8772

Like I said in my comments on the PR, I was never able to duplicate this,
and the test I added to httpd-test for exec cmd passed on my system.  Was
that test failing on your system?  If not, could you give me a test case
that DID fail on your system so I can improve the test program?

Thanks,
Cliff

Re: cvs commit: httpd-2.0/modules/generators mod_cgi.c mod_cgi.h

[Ryan Bloom <rb...@covalent.net>]

On Saturday 24 November 2001 09:17 pm, Cliff Woolley wrote:
> On 24 Nov 2001 rbb@apache.org wrote:
> > rbb         01/11/23 16:17:01
> >
> >   Modified:    .        CHANGES
> >                modules/arch/win32 mod_win32.c
> >                modules/generators mod_cgi.c mod_cgi.h
> >   Log:
> >   Fix the cmd command for mod_include.  When we are processing
> >   a cmd command, we do not want to use the r->filename to set
> >   the command name.  The command comes from the SSI tag.  To do this,
> >   I added a variable to the function that builds the command line
> >   in mod_cgi.  This allows the include_cmd function to specify
> >   the command line itself.
> >
> >   PR:	8772
>
> Like I said in my comments on the PR, I was never able to duplicate this,
> and the test I added to httpd-test for exec cmd passed on my system.  Was
> that test failing on your system?  If not, could you give me a test case
> that DID fail on your system so I can improve the test program?

Every test I tried failed on my system.  When I traced through the code, I
found that we were trying to set the command variable using the r->filename
variable, and that is never going to work for cmd.  I wish I could give more
information, but you test case failed everytime on my computer.

Ryan

______________________________________________________________
Ryan Bloom				rbb@apache.org
Covalent Technologies			rbb@covalent.net
--------------------------------------------------------------