[GitHub] [doris] hust-hhb commented on a diff in pull request #18686: [performance](stream-load) use vector instead of skiplist when insert dup keys

["hust-hhb (via GitHub)" <gi...@apache.org>]

hust-hhb commented on code in PR #18686:
URL: https://github.com/apache/doris/pull/18686#discussion_r1172506516


##########
be/src/olap/memtable.cpp:
##########
@@ -243,11 +242,23 @@ void MemTable::_collect_vskiplist_results() {
     VecTable::Iterator it(_vec_skip_list.get());
     vectorized::Block in_block = _input_mutable_block.to_block();
     if (_keys_type == KeysType::DUP_KEYS) {
+        vectorized::MutableBlock mutable_block =
+                vectorized::MutableBlock::build_mutable_block(&in_block);
+        _vec_row_comparator->set_block(&mutable_block);
+        std::sort(_row_in_blocks.begin(), _row_in_blocks.end(),

Review Comment:
   compare _row_pos can ensure that the sorting is stable, in my test the output order is equal with skiplist, so i think std::sort is enough.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org