You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by srowen <gi...@git.apache.org> on 2017/12/15 13:49:00 UTC

[GitHub] spark pull request #19988: [Spark-22795] [ML] Raise error when line search i...

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19988#discussion_r157204320
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/optim/NormalEquationSolver.scala ---
    @@ -17,10 +17,10 @@
     package org.apache.spark.ml.optim
     
     import scala.collection.mutable
    -
     import breeze.linalg.{DenseVector => BDV}
     import breeze.optimize.{CachedDiffFunction, DiffFunction, LBFGS => BreezeLBFGS, OWLQN => BreezeOWLQN}
    -
    +import org.apache.spark.SparkException
    --- End diff --
    
    This will fail style checks. Restore the empty lines between groups.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org