You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/10/12 17:47:33 UTC
[GitHub] [nifi] thenatog opened a new pull request, #6517: NiFi-10576 - ParquetRecordSetWriter doesn't write avro schema to attribute
thenatog opened a new pull request, #6517:
URL: https://github.com/apache/nifi/pull/6517
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NiFi-10576](https://issues.apache.org/jira/browse/NiFi-10576)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NiFi-10576`
- [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NiFi-10576`
### Pull Request Formatting
- [x] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `mvn clean install -P contrib-check`
- [ ] JDK 8
- [x] JDK 11
- [ ] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on pull request #6517: NiFi-10576 - ParquetRecordSetWriter doesn't write avro schema to attribute
Posted by GitBox <gi...@apache.org>.
mattyb149 commented on PR #6517:
URL: https://github.com/apache/nifi/pull/6517#issuecomment-1276595864
Looks good. Is there any way to add a unit test for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] thenatog commented on pull request #6517: NIFI-10576 - ParquetRecordSetWriter doesn't write avro schema to attribute
Posted by GitBox <gi...@apache.org>.
thenatog commented on PR #6517:
URL: https://github.com/apache/nifi/pull/6517#issuecomment-1344598862
Thanks, if the avro.schema attribute is coming through on flowfiles coming out of the runner, then that sounds good to me. The simplest test would be to see that the attributes are now returned from the method I added, but I noticed that at run time it didn't come through until I added a schema cache service. Entirely possible I didn't understand how the schemas worked, and that setting it to use schema name(?) should work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory closed pull request #6517: NIFI-10576 - ParquetRecordSetWriter doesn't write avro schema to attribute
Posted by GitBox <gi...@apache.org>.
exceptionfactory closed pull request #6517: NIFI-10576 - ParquetRecordSetWriter doesn't write avro schema to attribute
URL: https://github.com/apache/nifi/pull/6517
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org