You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by daserge <gi...@git.apache.org> on 2015/12/29 20:16:43 UTC

[GitHub] cordova-plugin-splashscreen pull request: CB-9240 Cordova splash s...

GitHub user daserge opened a pull request:

    https://github.com/apache/cordova-plugin-splashscreen/pull/72

    CB-9240 Cordova splash screen plugin iPad landscape mode issue

    [Jira issue](https://issues.apache.org/jira/browse/CB-9240)
    
    Aligns `shouldAutoRotate` default value with [parent CDVViewController behavior](https://github.com/apache/cordova-ios/blob/d3c5519719d172bfcf6d994c740615b6fdfa91e6/CordovaLib/Classes/Public/CDVViewController.m#L352-L355).
    
    This fix also does not break iPhone rotation behavior - it's being turned on after splashscreen hide and swizzling dismissal.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-plugin-splashscreen CB-9240

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-splashscreen/pull/72.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #72
    
----
commit 3b2e9e59124e345c61235ca132e8f519d7df8ead
Author: daserge <v-...@microsoft.com>
Date:   2015-12-29T19:08:02Z

    CB-9240 Cordova splash screen plugin iPad landscape mode issue
    
    Aligns shouldRotate default value with parent CDVViewController behavior

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: CB-9240 Cordova splash s...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-plugin-splashscreen/pull/72


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: CB-9240 Cordova splash s...

Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:

    https://github.com/apache/cordova-plugin-splashscreen/pull/72#issuecomment-167857941
  
    @shazron, could you please take a look?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org